From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MbVMN7h6GmkBuQoAWB0awg (envelope-from ) for ; Sun, 16 Nov 2025 20:30:32 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=pazH624Q; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DA7601E08D; Sun, 16 Nov 2025 20:30:32 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1842B1E08D for ; Sun, 16 Nov 2025 20:30:32 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B60CA3858406 for ; Mon, 17 Nov 2025 01:30:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B60CA3858406 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=pazH624Q Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 8240B3858D21 for ; Mon, 17 Nov 2025 01:28:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8240B3858D21 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8240B3858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763342895; cv=none; b=l9xKoxWl/iqrEir+fD7rdnEGfOguhcMqvHfzQS0L6/5XYMaIAB5wsgPuqG3az+DP1XtUa1zL9JiolKXNBSZWRvFCRpu72ISNREzKl/Vyg4lP+U6LCPNQRtto5+EuReSZutbeScR6K32hmg8bOzhw33Tm6nhog6zjyqoFFxpbVp4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763342895; c=relaxed/simple; bh=bxMej27bD+FqNo76vYgA6gAxmSBlzP+Okxzkl3vG8xc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=J70lNSmhtxFz22DJw7xzO3tu3uoQbozFwGkkd75joMPPRsJyJ48C4t8z3Ko+3EtKV3cM7WwYVDu9SS+rSJk/LsPwK1s8n+RMiSlRuDQZd5U3pjJIyxEDHCM0sDVuko3GbRbvqqKKcYfmbf13M35lO9Y46Hc/mwzlXmZY9+XfU2g= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8240B3858D21 Received: from eig-obgw-5001b.ext.cloudfilter.net ([10.0.29.181]) by cmsmtp with ESMTPS id KmDVvrS6GKXDJKo2RvWtdZ; Mon, 17 Nov 2025 01:28:15 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Ko2QvYKUHFb22Ko2QvYIDD; Mon, 17 Nov 2025 01:28:15 +0000 X-Authority-Analysis: v=2.4 cv=OPcn3TaB c=1 sm=1 tr=0 ts=691a7a2f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=6UeiqGixMTsA:10 a=ItBw4LHWJt0A:10 a=obPOZBTxATpot33972wA:9 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KapE/O3k3a+W69orEih8jp4z0kvNrwMI64Dg6CpnnKY=; b=pazH624Q5zImcO6O2pB29ljgxb D2iZL10tLcksm580zkb+hr1xnbqEMzdZCTYL/bslEVddKTlhI0jUT6PBLPxQqONLoMwEOCHRQF6tm Fz8dOuS7fnY2K9hatC0u0HGOT; Received: from 97-122-120-205.hlrn.qwest.net ([97.122.120.205]:41170 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vKo2K-00000000Q3v-2D7P; Sun, 16 Nov 2025 18:28:08 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 1/7] Reformat gdb.objc tests Date: Sun, 16 Nov 2025 18:27:00 -0700 Message-ID: <20251117012752.2657208-2-tom@tromey.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20251117012752.2657208-1-tom@tromey.com> References: <20251117012752.2657208-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.120.205 X-Source-L: No X-Exim-ID: 1vKo2K-00000000Q3v-2D7P X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-120-205.hlrn.qwest.net (localhost.localdomain) [97.122.120.205]:41170 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJfxghRrX60EIvhBj9Z7LmZ/lSjOlK+Ks2sZi1PyI9zU5PL7MPlklqZ0XHFmRDOBgxCxfQjWevk8riWh3s+SwC3BCgrw7lXty+iP/iur7PiC1euijwtG ecyn0PS1v5zfC5A2a+wbD6+oqSy13wJujw6E/UPqUlsCKCDkEllZJPIQQyHYOn8Gtn7RFhcF5Qq+uZpEXsYDG4tQlpkWLRuR3i0= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This patch applies some minor formatting changes and cleanups to the gdb.objc tests. --- gdb/testsuite/gdb.objc/basicclass.exp | 9 ++++----- gdb/testsuite/gdb.objc/nondebug.exp | 9 ++++----- gdb/testsuite/gdb.objc/objcdecode.exp | 11 +++++------ 3 files changed, 13 insertions(+), 16 deletions(-) diff --git a/gdb/testsuite/gdb.objc/basicclass.exp b/gdb/testsuite/gdb.objc/basicclass.exp index 9e40c7138dc..d1fb64a42de 100644 --- a/gdb/testsuite/gdb.objc/basicclass.exp +++ b/gdb/testsuite/gdb.objc/basicclass.exp @@ -21,8 +21,9 @@ standard_testfile .m # Objective-C program compilation isn't standard. We need to figure out # which libraries to link in. Most of the time it uses pthread # -if {[gdb_compile_objc "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [list debug ]] != "" } { - return -1 +if {[gdb_compile_objc "${srcdir}/${subdir}/${srcfile}" "${binfile}" \ + executable {debug}] != ""} { + return } # @@ -147,7 +148,7 @@ gdb_test "break hiddenMethod" \ # gdb_test continue \ "Continuing\\..*Breakpoint \[0-9\]+, -.BasicClass\\(Private\\) hiddenMethod. \\(self=.*, _cmd=.*\\) at .*$srcfile:61.*" \ - "continue until category method" + "continue until category method" # # Test calling Objective-C methods @@ -170,5 +171,3 @@ gdb_test "print-object object" \ gdb_test "po self" \ "BasicClass gdb test object" \ "use of the po (print-object) command" - - diff --git a/gdb/testsuite/gdb.objc/nondebug.exp b/gdb/testsuite/gdb.objc/nondebug.exp index 9ca86ff8189..321aa229045 100644 --- a/gdb/testsuite/gdb.objc/nondebug.exp +++ b/gdb/testsuite/gdb.objc/nondebug.exp @@ -23,8 +23,9 @@ standard_testfile .m # Objective-C program compilation isn't standard. We need to figure out # which libraries to link in. Most of the time it uses pthread # -if {[gdb_compile_objc "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [list ] ] != "" } { - return -1 +if {[gdb_compile_objc "${srcdir}/${subdir}/${srcfile}" "${binfile}" \ + executable {}] != ""} { + return } proc do_objc_tests {} { @@ -42,8 +43,7 @@ gdb_test "set breakpoint pending off" "" "set breakpoint pending" # Break on multiply defined non-debuggable symbol (PR objc/1236) # set name "break on non-debuggable method" -gdb_test_multiple "break someMethod" $name \ -{ +gdb_test_multiple "break someMethod" $name { -re "\\\[0\\\] cancel\r\n\\\[1\\\] all\r\n\\\[2\\\]\[ \]+-.NonDebug someMethod.*\\\[3\\\]\[ \]+-.NonDebug2 someMethod.*" { send_gdb "2\n" exp_continue @@ -55,4 +55,3 @@ gdb_test_multiple "break someMethod" $name \ -re "Breakpoint \[0-9\]+ at 0x\[0-9a-f\]+.*$gdb_prompt $" { pass $name } -re ".*$gdb_prompt $" { kfail "gdb/1236" $name } } - diff --git a/gdb/testsuite/gdb.objc/objcdecode.exp b/gdb/testsuite/gdb.objc/objcdecode.exp index 5414f0f96f3..7840a2ed5d3 100644 --- a/gdb/testsuite/gdb.objc/objcdecode.exp +++ b/gdb/testsuite/gdb.objc/objcdecode.exp @@ -23,8 +23,9 @@ standard_testfile .m # Objective-C program compilation isn't standard. We need to figure out # which libraries to link in. Most of the time it uses pthread # -if {[gdb_compile_objc "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [list debug ]] != "" } { - return -1 +if {[gdb_compile_objc "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable \ + {debug}] != ""} { + return } proc do_objc_tests {} { @@ -40,8 +41,7 @@ gdb_test_no_output "set multiple-symbols ask" # Break on multiply defined method (PR objc/1236) # set name "break on multiply defined method" -gdb_test_multiple "break multipleDef" $name \ -{ +gdb_test_multiple "break multipleDef" $name { -re "\\\[0\\\] cancel\r\n\\\[1\\\] all\r\n\\\[2\\\] .*${srcfile}:-.Decode multipleDef.\r\n\\\[3\\\] .*${srcfile}:multipleDef\r\n> $" { send_gdb "3\n" exp_continue @@ -52,8 +52,7 @@ gdb_test_multiple "break multipleDef" $name \ set name "continue after break on multiply defined symbol" gdb_run_cmd -gdb_test_multiple "" $name \ -{ +gdb_test_multiple "" $name { -re "Breakpoint \[0-9\]+, multipleDef \\\(\\\) at .*\r\n$gdb_prompt $" { pass $name } -- 2.49.0