From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aB0XCaG/BWk/8BYAWB0awg (envelope-from ) for ; Sat, 01 Nov 2025 04:06:57 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=stackframe.org header.i=@stackframe.org header.a=rsa-sha256 header.s=duo-1634547266507-560c42ae header.b=tPHvvL9o; dkim=pass (2048-bit key; unprotected) header.d=outbound.mailhop.org header.i=@outbound.mailhop.org header.a=rsa-sha256 header.s=dkim-high header.b=UBqXUYLp; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=stackframe.org header.i=@stackframe.org header.a=rsa-sha256 header.s=dkim1 header.b=Ib+D/NTS; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 183981E057; Sat, 01 Nov 2025 04:06:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AE1E91E057 for ; Sat, 01 Nov 2025 04:06:55 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 13346385086F for ; Sat, 1 Nov 2025 08:06:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 13346385086F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, secure) header.d=stackframe.org header.i=@stackframe.org header.a=rsa-sha256 header.s=duo-1634547266507-560c42ae header.b=tPHvvL9o; dkim=pass (2048-bit key, unprotected) header.d=outbound.mailhop.org header.i=@outbound.mailhop.org header.a=rsa-sha256 header.s=dkim-high header.b=UBqXUYLp; dkim=fail reason="signature verification failed" (2048-bit key, secure) header.d=stackframe.org header.i=@stackframe.org header.a=rsa-sha256 header.s=dkim1 header.b=Ib+D/NTS Received: from baboon.maple.relay.mailchannels.net (baboon.maple.relay.mailchannels.net [23.83.214.8]) by sourceware.org (Postfix) with ESMTPS id 898F2385B507 for ; Sat, 1 Nov 2025 08:05:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 898F2385B507 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=stackframe.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=stackframe.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 898F2385B507 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=23.83.214.8 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1761984354; cv=pass; b=Yqlm4CMdQkzFEjyAYcDBbUSCL50WSkUdeUsfe22d/JPBb3N3sktTeC5wf0JZs1+5M+OIDl52hHlgPE9oZFnJI0pkCSnOftyMTRzkZUPqf6fSM4o/GXkm05DGSPVfxwRLXHCIPOLm8lteXgMHfJRM3W5DJSkXMvwDK0dcvez6lB4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1761984354; c=relaxed/simple; bh=W4yapOrgiHScuZ3z03AQFgJWzwhOQIWU/uhp4lztldw=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:From:To:Subject:Date: Message-ID:MIME-Version; b=JqiyP0W3QjU/XCPRTfrtWgJcZSdVIpeazO9ZQ4XQ0edZERvCc9mS/SRE3ziNmI2RA2xpq8vvja5tQIHMZ+UwxdfZx9xRQfOwgb/I7nIB+14tw0j5B9mlfhgVeCmnlKdxl5ffrN5686JR18Q0BbXIaNXE7b5JAdNWGr7EqEi/pLA= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 898F2385B507 X-Sender-Id: _forwarded-from|130.180.31.158 Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 690CE8C1144 for ; Sat, 01 Nov 2025 08:05:52 +0000 (UTC) Received: from outbound1g.eu.mailhop.org (trex-green-0.trex.outbound.svc.cluster.local [100.124.152.27]) (Authenticated sender: duocircle) by relay.mailchannels.net (Postfix) with ESMTPA id 7DF728C14A6 for ; Sat, 01 Nov 2025 08:05:51 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1761984351; a=rsa-sha256; cv=none; b=h9RFlhq/Tkf0+9UEj5w2KlkhHqS3zAbixsoSJNoe3hv8+n6MhAzhMFGCEs3uB0ESoxXYN4 /s4FKg1IhLlqhHf0yyKrT0BLOSCWD7rMa/pBZii+B5AxvT0aplyZeW0QRgukk39UZE8Tl1 qsIWe5dv6L8k88NOs51AzQBtVCIMlcWze2RJmG6mBYN5s6hF4oysZWS65QASTioQhgopqA 6/7xIJb9Oj0E8Gv6z71m8Kwq58B/yGmKryT3XwX+KKBI0vHyQnQhJPaplMAqO3APA3fv7R hf58WaIewbiHcBS6QFJdx/qa3lQkqjjuCuQQajDyDL7P0hNQSopIvnXwkDd3aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1761984351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:dkim-signature; bh=k+8Jg+8mDcbnfMMeOFjX/GnWC50VmVmZo07pCkYp+7I=; b=Mhxw7Q/fFfv/0CoA0p75DFxBgdLTNC950WabZbzRenJ5MbpvT3q3yexiqLICX155Haiok5 n+FffnNydICNAgRWD81tWiBGmXdMxgGRCYyC3BdAc7QQPIAXHiaYud93VDev/pA7F728Vc d9rAY0hbgKAZAO4usHyMdhvtXX7O21ir9EtKvhkixOzlD/2g40eHIx54r2iUl4Y85GXiat Jl8qmjQ5U0Fmw1cBcM9U56hod203ecDoINqGXEDqfpz0agss+sQ4ZcTSoa9Ajngz2yMVJW kV59FnhCXdO6xZyb3QimVKiO97ZLUp19p1fbTIi7wIG6hyf0mWnCUVgAvnp0WQ== ARC-Authentication-Results: i=1; rspamd-77bb85d8d5-jhjg8; auth=pass smtp.auth=duocircle smtp.mailfrom=svens@stackframe.org X-Sender-Id: _forwarded-from|130.180.31.158 X-MC-Relay: Forwarding X-MailChannels-SenderId: _forwarded-from|130.180.31.158 X-MailChannels-Auth-Id: duocircle X-Shrill-Blushing: 2b78737604515ed9_1761984352310_3941795847 X-MC-Loop-Signature: 1761984352310:74516249 X-MC-Ingress-Time: 1761984352310 Received: from outbound1g.eu.mailhop.org (outbound1g.eu.mailhop.org [52.28.6.212]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.124.152.27 (trex/7.1.3); Sat, 01 Nov 2025 08:05:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stackframe.org; s=duo-1634547266507-560c42ae; h=content-transfer-encoding:mime-version:message-id:date:subject:cc:to:from: cfbl-address:cfbl-feedback-id:from; bh=k+8Jg+8mDcbnfMMeOFjX/GnWC50VmVmZo07pCkYp+7I=; b=tPHvvL9osgaz5p4sbW8OUA5eESC/PKZ8qTwI4PvVWT9+SxANZ2Jt0shOFFZsfuIFIZfiYbcoX4MvS 9JvnUa330f4oh6bchlsd3UgCBNdG0ad++mN6o2xlKP0g/B5mzlG87VQKgvLkCbBEf8TsLkRV2zPvvZ B0YRNUxGyqnScpv4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:message-id:date:subject:cc:to:from: cfbl-address:cfbl-feedback-id:from; bh=k+8Jg+8mDcbnfMMeOFjX/GnWC50VmVmZo07pCkYp+7I=; b=UBqXUYLpEyIlyj3WklgErvDnL0Wocp6/TljlhBlVDWXjt8HV4ErdJNMgVb2noSeaUoYEtMHbawvW4 LQq7a6I2AEtwpSkMYSZVJrUKz5034VpjivL0YfOxd97CmK9luarSTJzav62sD10TwyWWQiXFZxTZt3 ljqim98hZOECUkKFIWGXFxPsN9FPMnG2lGeQ04JUy5SvFQBK1DLNZWjKgTjCVees11v1h5AKMiHI5G 6CfJld4dgrvfTGZi0wt4OS482Gh6zOKq5t/iPgpXKWeQuAb6zSP4sPaVDjC5bKNhH9y9H8cpesMoyV UcxXbBvJ5Xlrsu25XFrT/7eazT99eTw== X-Originating-IP: 130.180.31.158 X-MHO-RoutePath: dG9ta2lzdG5lcm51 X-MHO-User: 91f32b5c-b6f9-11f0-b6fc-5f56af36decb X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Mail-Handler: DuoCircle Outbound SMTP CFBL-Feedback-ID: 91f32b5c-b6f9-11f0-b6fc-5f56af36decb:5 CFBL-Address: prvs=04004e5b2d=abuse@outbound.mailhop.org; report=arf Received: from mail.duncanthrax.net (mail.duncanthrax.net [130.180.31.158]) by outbound3.eu.mailhop.org (Halon) with ESMTPSA id 91f32b5c-b6f9-11f0-b6fc-5f56af36decb; Sat, 01 Nov 2025 08:05:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stackframe.org; s=dkim1; h=Content-Transfer-Encoding:MIME-Version: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=k+8Jg+8mDcbnfMMeOFjX/GnWC50VmVmZo07pCkYp+7I=; b=Ib+D/NTSi7KN9y/E44ZVSvE+AT PRjiX9huPi3fcKCA7U/mZGENyz3VTwds1cZftXdiLfqrlhu7XGjLSnfRx+2nZbNJHSI1+vdeiywiX UzSv4Yvgpb9ndy0ybZweKVoWEc5t0W1fZl1OfTuACw62q3O5STth+Zn/3qh7g280qp8DWxTx+3J4C ZECF0yHDc+DBhONMVkNZ2ziK4sadkfvUN4d5hr84x/TNu2/RXKisMrNWOMQnBDS0ESS/8e7K9E7Ou TD6WwbQ03aoDMeSH63zsxdp9nwhzbHdiqxu9E3o9EfI3xHwLVFUO87o1qLxXcLVkHx6QgYEv4S4qm Lg+/ERlg==; Received: from [134.3.93.166] (helo=debian.stackframe.org) by mail.duncanthrax.net with esmtpa (Exim 4.97) (envelope-from ) id 1vF6cL-00000002QUc-32X9; Sat, 01 Nov 2025 09:05:45 +0100 From: Sven Schnelle To: gdb-patches@sourceware.org Cc: Helge Deller , John David Anglin , binutils@sourceware.org, Sven Schnelle Subject: [PATCH RESEND] gdb/hppa: guess g packet size Date: Sat, 1 Nov 2025 09:05:38 +0100 Message-ID: <20251101080538.857188-1-svens@stackframe.org> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org With qemu supporting 64 bit now, add some code to determine the register size of a hppa remote target. Signed-off-by: Sven Schnelle --- gdb/hppa-tdep.c | 46 +++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 41 insertions(+), 5 deletions(-) diff --git a/gdb/hppa-tdep.c b/gdb/hppa-tdep.c index 96cb797c023..ca59fc63d1d 100644 --- a/gdb/hppa-tdep.c +++ b/gdb/hppa-tdep.c @@ -33,6 +33,8 @@ #include "trad-frame.h" #include "frame-unwind.h" #include "frame-base.h" +#include "remote.h" +#include "target-descriptions.h" #include "gdbcore.h" #include "cli/cli-cmds.h" @@ -43,6 +45,14 @@ static bool hppa_debug = false; +/* Properties (for struct target_desc) describing the g/G packet + layout. */ +#define PROPERTY_GP32 "internal: transfers-32bit-registers" +#define PROPERTY_GP64 "internal: transfers-64bit-registers" + +struct target_desc *hppa_tdesc32; +struct target_desc *hppa_tdesc64; + /* Some local constants. */ static const int hppa32_num_regs = 128; static const int hppa64_num_regs = 96; @@ -2978,6 +2988,17 @@ hppa_skip_trampoline_code (const frame_info_ptr &frame, CORE_ADDR pc) -- chastain 2003-12-18 */ +static void +hppa_register_g_packet_guesses (struct gdbarch *gdbarch) +{ + /* If the size matches the set of 32-bit or 64-bit integer registers, + assume that's what we've got. */ + register_remote_g_packet_guess (gdbarch, hppa32_num_regs * 4, hppa_tdesc32); + register_remote_g_packet_guess (gdbarch, hppa64_num_regs * 8, hppa_tdesc64); + + /* Otherwise we don't have a useful guess. */ +} + static struct gdbarch * hppa_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) { @@ -2991,14 +3012,24 @@ hppa_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) = gdbarch_alloc (&info, gdbarch_tdep_up (new hppa_gdbarch_tdep)); hppa_gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); - /* Determine from the bfd_arch_info structure if we are dealing with - a 32 or 64 bits architecture. If the bfd_arch_info is not available, - then default to a 32bit machine. */ - if (info.bfd_arch_info != NULL) + /* Determine from the target description if we are dealing with + a 32 or 64 bits architecture. If the target description is not + available, then check whether bfd_arch_info could be used. + Otherwise default to a 32bit machine. + */ + if (info.target_desc != NULL) { + if (tdesc_property (info.target_desc, PROPERTY_GP64) != NULL) + tdep->bytes_per_address = 8; + else if (tdesc_property (info.target_desc, PROPERTY_GP32) != NULL) + tdep->bytes_per_address = 4; + } else if (info.bfd_arch_info != NULL) { tdep->bytes_per_address = info.bfd_arch_info->bits_per_address / info.bfd_arch_info->bits_per_byte; - else + } else { tdep->bytes_per_address = 4; + } + + hppa_register_g_packet_guesses (gdbarch); tdep->find_global_pointer = hppa_find_global_pointer; @@ -3122,6 +3153,11 @@ hppa_dump_tdep (struct gdbarch *gdbarch, struct ui_file *file) INIT_GDB_FILE (hppa_tdep) { gdbarch_register (bfd_arch_hppa, hppa_gdbarch_init, hppa_dump_tdep); + hppa_tdesc32 = allocate_target_description ().release (); + set_tdesc_property (hppa_tdesc32, PROPERTY_GP32, ""); + + hppa_tdesc64 = allocate_target_description ().release (); + set_tdesc_property (hppa_tdesc64, PROPERTY_GP64, ""); add_cmd ("unwind", class_maintenance, unwind_command, _("Print unwind table entry at given address."), -- 2.51.0