From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2CwlJkmEBWnufxYAWB0awg (envelope-from ) for ; Fri, 31 Oct 2025 23:53:45 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ybq9F5oS; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8DC411E057; Fri, 31 Oct 2025 23:53:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B6AC81E057 for ; Fri, 31 Oct 2025 23:53:44 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D2AC7385B50A for ; Sat, 1 Nov 2025 03:53:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D2AC7385B50A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ybq9F5oS Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 3414E3856DE3 for ; Sat, 1 Nov 2025 03:53:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3414E3856DE3 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3414E3856DE3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761969192; cv=none; b=K3ry+ZfkowO13IuBMvhwl04TBQACklbvGoDs7bK/qHr6CB5msDgPQ+4nFKJ1di+GzmxqXgv+fp0XbLZYr27JCEoahwjG8jInwRNxDTfGtRb95nx/WeCq/vsTnSbAb53yj69eJ6rkLHbJFOHCHb34SvKy8sCfO5LkeG5c1w0fzRs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761969192; c=relaxed/simple; bh=DPpIksDdpX25EJRNTV6RrYPsc2fUCuSvqECNEQVSTbY=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=WCskqqB4ruPMYypRyy2OnFIrCddoW7Ebtx0KQhzzA2ZcmP12hkPhNnTGwUMOf0YYn++i41DsXqE1VXbpgE/Ha4/XJpEbO0RtxFAwZGLWJyMt914PR1KOtUkpzK4a2hlXqk3GnFwukih4Jg9U2ZTzZ9e+bMZH8NqfrmWBGUelw9E= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3414E3856DE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761969191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EwxpRyVMh4BjsELsJmmBvUD2w4XDpQwua8wRfavDn7Y=; b=Ybq9F5oShDmE7x+9iqKIen5t1HpfzBFjhjc+03Q7cHszPvAwMJjyje/y1fZpo4g9kg6GDA MFWykgVAPQypldyxUd6k8DbXfXcyADD1lQJW9jTPr+FkqExy88yHXqc0EqUNpF2w/3psT0 2626VzXUoD+iZJCJwjIVrWQwqdPzhos= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-458-bswz31f2On240anZ42YypQ-1; Fri, 31 Oct 2025 23:53:10 -0400 X-MC-Unique: bswz31f2On240anZ42YypQ-1 X-Mimecast-MFC-AGG-ID: bswz31f2On240anZ42YypQ_1761969189 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 73856180060D; Sat, 1 Nov 2025 03:53:09 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.64.25]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 91F1519540DA; Sat, 1 Nov 2025 03:53:08 +0000 (UTC) Date: Fri, 31 Oct 2025 20:53:05 -0700 From: Kevin Buettner To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Clean up "return -1" in gdb.rust Message-ID: <20251031205305.12b3b6bd@f41-zbm-amd> In-Reply-To: <20251031193102.2661619-1-tromey@adacore.com> References: <20251031193102.2661619-1-tromey@adacore.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Vn7D5NdPaQDFRgakFDSzJeJD67ysvZv9Gw_9gBjf0wk_1761969189 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Fri, 31 Oct 2025 13:30:58 -0600 Tom Tromey wrote: > This changes gdb.rust tests to use plain "return" rather than > "return -1". In these spots, the "-1" has no meaning. LGTM. Approved-by: Kevin Buettner