Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Luis Machado <luis.machado@amd.com>
To: <gdb-patches@sourceware.org>
Cc: Luis Machado <luis.machado@amd.com>
Subject: [PATCH] [gdb/testsuite] Fix device index in gdb.rocm/addr-bp-gpu-no-deb-info.exp
Date: Thu, 30 Oct 2025 09:54:04 +0000	[thread overview]
Message-ID: <20251030095404.422806-1-luis.machado@amd.com> (raw)

On a system with a single GPU, I spotted this test failing. The environment
variable ROCR_VISIBLE_DEVICES can be a bit misleading, as it actually expects
a list of device id's as opposed to a literal number of devices to make
visible.

This test sets it to 1, which is the second GPU on the system. As a result,
systems with a single GPU will have no visible GPU's and the test will FAIL.

Set ROCR_VISIBLE_DEVICES to 0 to make use of the first GPU on the system.
---
 gdb/testsuite/gdb.rocm/addr-bp-gpu-no-deb-info.exp | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gdb/testsuite/gdb.rocm/addr-bp-gpu-no-deb-info.exp b/gdb/testsuite/gdb.rocm/addr-bp-gpu-no-deb-info.exp
index be459673dc9..2719f0d8b13 100644
--- a/gdb/testsuite/gdb.rocm/addr-bp-gpu-no-deb-info.exp
+++ b/gdb/testsuite/gdb.rocm/addr-bp-gpu-no-deb-info.exp
@@ -28,9 +28,10 @@ if {[build_executable "failed to prepare" $testfile $srcfile {hip}]} {
 
 clean_restart $::testfile
 
-# We may have multiple GPUs, resulting in many possible locations. This is
-# needed to ensure we get a single address to break on.
-gdb_test_no_output "set environment ROCR_VISIBLE_DEVICES=1"
+# We may have multiple GPUs, resulting in many possible locations.  This is
+# needed to ensure we get a single address to break on, so make device 0 the
+# only visible one.
+gdb_test_no_output "set environment ROCR_VISIBLE_DEVICES=0"
 
 # Make the HIP runtime load all the GPU code objects during initialization.
 gdb_test_no_output "set environment HIP_ENABLE_DEFERRED_LOADING=0"
-- 
2.43.0


             reply	other threads:[~2025-10-30  9:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-30  9:54 Luis Machado [this message]
2025-10-30 14:51 ` [PATCH] " Lancelot SIX
2025-10-30 15:13   ` Machado, Luis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251030095404.422806-1-luis.machado@amd.com \
    --to=luis.machado@amd.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox