From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UfkxIPEPAmntlA8AWB0awg (envelope-from ) for ; Wed, 29 Oct 2025 09:00:33 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HMcmf2+0; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 80E991E0BC; Wed, 29 Oct 2025 09:00:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A71441E04C for ; Wed, 29 Oct 2025 09:00:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 560493858416 for ; Wed, 29 Oct 2025 13:00:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 560493858416 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HMcmf2+0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id D5E223858CD1 for ; Wed, 29 Oct 2025 12:58:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D5E223858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D5E223858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761742725; cv=none; b=Vd8UD60xZ5o2CoYKKVMsqXj/7fRy+UuHDaUQtMExYtZd7nLCe1KsTPNmVUQtKgalrGQ5kC5+xI6C5wG/+8tOB/LvcU/CN1dUaJK8D9NdeDVujnK2oTLMYIzaYygXsjHkzqMsrHqSLPY9C86yh7f8yqw8RYEvzVOzW0KfQbJoHyc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761742725; c=relaxed/simple; bh=T6afFgXIvlKezVFoK3uMBImdmUayPVa3kZVysLE47nI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=snI033pW4R9oy+AFWwl250A3Bae7WhCwAssuAfZgCCScvKgnIxTbjzbBD3Kljwy7RKvUjaaJfnXXKryLbJvLCe++J8NJNGvOy2uC5E4VmkRWP59b7QY+4kPpbW3Bk/J0o+J7SSsJLLmWtMiEuCb20Vt1/8n4TQAWy/GG6wuav58= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D5E223858CD1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761742725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z+u1rIg7dVI6xVDTBY5uNCXToz72usDQ+1QIvfxgOag=; b=HMcmf2+0f5QchyF7TEZRlYgn8iJTSX+ndKjnYXlHNxU3bWndQQ3jj0IFZKBLJqwtsMTx0A 0pNklu2NtZrRunTIkY85FOSJFMIQC1UkdQCg/27BrDBwONJJQu32QLe4ZCdDZ99N1j5pC7 ppExmLpMTxEbh1CTxbQplAW4NhTIYMY= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-qAEE6keMM5iCKYYBmncKCg-1; Wed, 29 Oct 2025 08:58:44 -0400 X-MC-Unique: qAEE6keMM5iCKYYBmncKCg-1 X-Mimecast-MFC-AGG-ID: qAEE6keMM5iCKYYBmncKCg_1761742723 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 903F41953991 for ; Wed, 29 Oct 2025 12:58:43 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.96.134.120]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ECC6F30001A2; Wed, 29 Oct 2025 12:58:41 +0000 (UTC) From: Guinevere Larsen To: gdb-patches@sourceware.org Cc: Guinevere Larsen Subject: [PATCH v6 1/3] gdb: make lookup_minimal_symbol_linkage work with linker namespaces Date: Wed, 29 Oct 2025 09:58:29 -0300 Message-ID: <20251029125831.2102647-2-guinevere@redhat.com> In-Reply-To: <20251029125831.2102647-1-guinevere@redhat.com> References: <20251029125831.2102647-1-guinevere@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1ifMd7xhEmNncAgVPER7DwViMUuRuamGT6_wy48BNwA_1761742723 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org When a symbol found by GDB may have copy relocation, GDB calculates the address of the symbol by checking all the objfiles in the current program space for another instance of the same symbol, and returns the address of the first instance found. This works well when linker namespaces are not involved, but fails when a symbol is present in more than one namespace. That's because copy relocations respect linker namespace boundaries, and so if we're trying to find the symbol in namespace N, the symbol from a different namespace M may be returned, if the SO containing the symbol was loaded in M before N. To make the search work correctly, lookup_minimal_symbol_linkage would need to also respect linker namespace boundaries. However, to avoid leaking solib knowledge to minsyms, and because of how little information is passed to the function, this commit instead makes the function take a vector of objfiles to search, in place of the program space. This makes it so symbol::get_maybe_copied_address (and the equivalent of minimal_symbol) need to request the objfiles for the correct namespace, since they have enough context to figure out the namespace. Creating the vector is left as a function in solib.c Since minimal_symbol::get_maybe_copied_address only searches main_file objfiles, if we can guarantee that only one is loaded for each program space, we could avoid the work of constructing an std::vector that will be mostly ignored. However, I couldn't convince myself that that is the case, so I decided to keep the behavior exactly as is. Ideally, lookup_minimal_symbol_linkage would receive an iterator instead of a vector, but as of now it isn't possible to do forward declarations of nested types (we'd need program_space::objfiles_range) and progspace.h can't be included into minsyms.h, so we're stuck constructing a vector for it. Finally, as some minor refactoring, find_solib_for_objfile is moved to solib.c to simplify looking for which namespace contains the objfile where we found the symbol the user was looking for. --- gdb/dwarf2/ada-imported.c | 8 +++- gdb/minsyms.c | 15 ++++--- gdb/minsyms.h | 9 ++-- gdb/solib-svr4.c | 20 --------- gdb/solib.c | 86 ++++++++++++++++++++++++++++++++++++++- gdb/solib.h | 19 +++++++++ gdb/symtab.c | 13 +++++- 7 files changed, 136 insertions(+), 34 deletions(-) diff --git a/gdb/dwarf2/ada-imported.c b/gdb/dwarf2/ada-imported.c index 48e6fccdb73..15ecfdaf6ce 100644 --- a/gdb/dwarf2/ada-imported.c +++ b/gdb/dwarf2/ada-imported.c @@ -35,9 +35,13 @@ static struct value * ada_imported_read_variable (struct symbol *symbol, const frame_info_ptr &frame) { const char *name = get_imported_name (symbol); + + std::vector objfiles_to_search; + for (objfile &objf : symbol->objfile ()->pspace ()->objfiles ()) + objfiles_to_search.push_back (&objf); + bound_minimal_symbol minsym - = lookup_minimal_symbol_linkage (symbol->objfile ()->pspace (), name, - true, false); + = lookup_minimal_symbol_linkage (objfiles_to_search, name, true, false); if (minsym.minsym == nullptr) error (_("could not find imported name %s"), name); return value_at (symbol->type (), minsym.value_address ()); diff --git a/gdb/minsyms.c b/gdb/minsyms.c index 90a0c601c59..7e4f47b8c3f 100644 --- a/gdb/minsyms.c +++ b/gdb/minsyms.c @@ -54,6 +54,7 @@ #include "gdbsupport/cxx-thread.h" #include "gdbsupport/parallel-for.h" #include "inferior.h" +#include "solib.h" /* Return true if MINSYM is a cold clone symbol. Recognize f.i. these symbols (mangled/demangled): @@ -584,19 +585,21 @@ lookup_minimal_symbol_linkage (const char *name, struct objfile *objf, /* See minsyms.h. */ bound_minimal_symbol -lookup_minimal_symbol_linkage (program_space *pspace, const char *name, - bool match_static_type, bool only_main) +lookup_minimal_symbol_linkage (gdb::array_view objfiles_to_search, + const char *name, bool match_static_type, + bool only_main) { - for (objfile &objfile : pspace->objfiles ()) + for (objfile *objfile : objfiles_to_search) { - if (objfile.separate_debug_objfile_backlink != nullptr) + if (objfile == nullptr + || objfile->separate_debug_objfile_backlink != nullptr) continue; - if (only_main && (objfile.flags & OBJF_MAINLINE) == 0) + if (only_main && (objfile->flags & OBJF_MAINLINE) == 0) continue; bound_minimal_symbol minsym - = lookup_minimal_symbol_linkage (name, &objfile, match_static_type); + = lookup_minimal_symbol_linkage (name, objfile, match_static_type); if (minsym.minsym != nullptr) return minsym; } diff --git a/gdb/minsyms.h b/gdb/minsyms.h index ed38044a38c..4aa8a428470 100644 --- a/gdb/minsyms.h +++ b/gdb/minsyms.h @@ -237,11 +237,14 @@ extern bound_minimal_symbol lookup_minimal_symbol_linkage /* A variant of lookup_minimal_symbol_linkage that iterates over all objfiles of PSPACE. If ONLY_MAIN is true, then only an objfile with - OBJF_MAINLINE will be considered. */ + OBJF_MAINLINE will be considered. This function should receive a + program_space::objfile_ranges instead, but we can't include progspace.h + here, nor can we do forward declarations of nested types, so std::vector + will waste a bit of memory to work around that issue. */ extern bound_minimal_symbol lookup_minimal_symbol_linkage - (program_space *pspace, const char *name, bool match_static_type, - bool only_main) ATTRIBUTE_NONNULL (1); + (gdb::array_view objfiles_to_search, const char *name, + bool match_static_type, bool only_main); /* Look through all the current minimal symbol tables and find the first minimal symbol that matches NAME and PC. If OBJF is non-NULL, diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c index c91e0b2c37b..49d2b207c36 100644 --- a/gdb/solib-svr4.c +++ b/gdb/solib-svr4.c @@ -3595,26 +3595,6 @@ lp64_svr4_solib_ops::fetch_link_map_offsets () const } -/* Return the DSO matching OBJFILE or nullptr if none can be found. */ - -static const solib * -find_solib_for_objfile (struct objfile *objfile) -{ - if (objfile == nullptr) - return nullptr; - - /* If OBJFILE is a separate debug object file, look for the original - object file. */ - if (objfile->separate_debug_objfile_backlink != nullptr) - objfile = objfile->separate_debug_objfile_backlink; - - for (const solib &so : current_program_space->solibs ()) - if (so.objfile == objfile) - return &so; - - return nullptr; -} - /* Return the address of the r_debug object for the namespace containing SOLIB or zero if it cannot be found. This may happen when symbol files are added manually, for example, or with the main executable. diff --git a/gdb/solib.c b/gdb/solib.c index dade2a76a48..34b0d6b3f9c 100644 --- a/gdb/solib.c +++ b/gdb/solib.c @@ -1825,8 +1825,92 @@ solib_linker_namespace_count (program_space *pspace) return 0; } -/* Implementation of the linker_namespace convenience variable. +/* See solib.h. */ + +const solib * +find_solib_for_objfile (struct objfile *objfile) +{ + if (objfile == nullptr) + return nullptr; + + /* If OBJFILE is a separate debug object file, look for the original + object file. */ + if (objfile->separate_debug_objfile_backlink != nullptr) + objfile = objfile->separate_debug_objfile_backlink; + + for (const solib &so : objfile->pspace ()->solibs ()) + if (so.objfile == objfile) + return &so; + + return nullptr; +} + +/* See solib.h. */ + +std::vector +get_objfiles_in_linker_namespace (int nsid, program_space *pspace) +{ + std::vector objfiles_in_ns; + const solib_ops *ops = pspace->solib_ops (); + + gdb_assert (ops->supports_namespaces ()); + + /* If we're looking at the default namespace, we also need + to add the mainline objfiles by hand, since there is no + solib associated with those files. We add them first + because if we're searching for copy relocations, they + should be in the main file, so we'll find it faster. */ + if (nsid == 0) + for (objfile &objf : pspace->objfiles ()) + if ((objf.flags & OBJF_MAINLINE) != 0) + objfiles_in_ns.push_back (&objf); + + std::vector solibs = ops->get_solibs_in_ns (nsid); + /* Reserve for efficiency. */ + objfiles_in_ns.reserve (solibs.size () + objfiles_in_ns.size ()); + for (const solib *so : solibs) + objfiles_in_ns.push_back (so->objfile); + + return objfiles_in_ns; +} + +/* See solib.h. */ + +std::vector +get_objfiles_in_linker_namespace (objfile *objfile) +{ + program_space *pspace = objfile->pspace (); + const solib_ops *ops = pspace->solib_ops (); + const solib *so = find_solib_for_objfile (objfile); + + /* If the inferior hasn't started yet, the solib_ops won't be + set for the program space. Since namespaces only make sense + when the inferior has already created some, we can just skip + it here. */ + if (ops != nullptr && ops->supports_namespaces () + /* If we're searching for a symbol from the linker, we'll reach here + before having any namespaces. Return all objfiles since the + boundaries haven't been setup yet. */ + && ops->num_active_namespaces () > 0 + /* When trying to load libthread_db, we can search for a symbol in an + objfile with no associated solib. In that case, again, we should + return all objfiles. */ + && so != nullptr) + { + return get_objfiles_in_linker_namespace (ops->find_solib_ns (*so), + pspace); + } + + /* If any of the previous conditions isn't satisfied, we return + the full list of objfiles in the inferior. */ + std::vector found_objfiles; + for (struct objfile &objf : objfile->pspace ()->objfiles ()) + found_objfiles.push_back (&objf); + return found_objfiles; +} + +/* Implementation of the linker_namespace convenience variable. This returns the GDB internal identifier of the linker namespace, for the selected frame, as an integer. If the inferior doesn't support linker namespaces, this always returns 0. */ diff --git a/gdb/solib.h b/gdb/solib.h index 85ea6675b79..81389da6267 100644 --- a/gdb/solib.h +++ b/gdb/solib.h @@ -20,6 +20,9 @@ #ifndef GDB_SOLIB_H #define GDB_SOLIB_H +/* Forward decl's for prototypes */ +struct objfile; + #include "gdb_bfd.h" #include "gdbsupport/function-view.h" #include "gdbsupport/intrusive_list.h" @@ -409,4 +412,20 @@ extern void handle_solib_event (void); extern int solib_linker_namespace_count (program_space *pspace); +/* Return a vector with pointers of all objfiles in the namespace + NSID. This version assumes that the inferior supports namespaces. */ + +std::vector get_objfiles_in_linker_namespace + (int nsid, program_space *pspace); + +/* Return a vector with pointers of all objfiles in the same namespace + as OBJFILE. If the inferior doesn't support namespaces, return all + objfiles in the program_space. */ + +std::vector get_objfiles_in_linker_namespace (objfile *objfile); + +/* Return the DSO matching OBJFILE or nullptr if none can be found. */ + +const solib *find_solib_for_objfile (struct objfile *objfile); + #endif /* GDB_SOLIB_H */ diff --git a/gdb/symtab.c b/gdb/symtab.c index 3b0687c0750..786dd9f56ba 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -74,6 +74,7 @@ #include "gdbsupport/common-utils.h" #include #include "gdbsupport/unordered_set.h" +#include "solib.h" /* Forward declarations for local functions. */ @@ -6575,8 +6576,12 @@ symbol::get_maybe_copied_address () const gdb_assert (this->loc_class () == LOC_STATIC); const char *linkage_name = this->linkage_name (); + + std::vector objfiles_to_search + (get_objfiles_in_linker_namespace (this->objfile ())); + bound_minimal_symbol minsym - = lookup_minimal_symbol_linkage (this->objfile ()->pspace (), linkage_name, + = lookup_minimal_symbol_linkage (objfiles_to_search, linkage_name, false, false); if (minsym.minsym != nullptr) return minsym.value_address (); @@ -6593,8 +6598,12 @@ minimal_symbol::get_maybe_copied_address (objfile *objf) const gdb_assert ((objf->flags & OBJF_MAINLINE) == 0); const char *linkage_name = this->linkage_name (); + + std::vector objfiles_to_search + (get_objfiles_in_linker_namespace (objf)); + bound_minimal_symbol found - = lookup_minimal_symbol_linkage (objf->pspace (), linkage_name, + = lookup_minimal_symbol_linkage (objfiles_to_search, linkage_name, false, true); if (found.minsym != nullptr) return found.value_address (); -- 2.51.0