From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ljBZGslb/GjZdgcAWB0awg (envelope-from ) for ; Sat, 25 Oct 2025 01:10:33 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=iRSG/aIb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 530EE1E057; Sat, 25 Oct 2025 01:10:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 30E111E057 for ; Sat, 25 Oct 2025 01:10:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 879273858039 for ; Sat, 25 Oct 2025 05:10:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 879273858039 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=iRSG/aIb Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id A56313858C52 for ; Sat, 25 Oct 2025 05:09:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A56313858C52 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A56313858C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761368999; cv=none; b=WOODZ/p58DNFbfv8Y7MmNozCeJOGUXa/K4jIayQNP9ehQ7sr3VYkLkVVtuN03M5dIIbTH6JylTuDPH0NsnMHFoEgXPVRZYGuu59DGCdga2X7SN8tzXiT+AKmFttO4MX6vX8dP1Qt9DGkBOAfds2T6H8MH/cairCNpeWTlRzmLBA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761368999; c=relaxed/simple; bh=lUYMDfjHXUyliHodSp4+az16Eg34rSIAlDp28fe06QQ=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=h/gxMu5XZDRmHL8SzFDXPQ6k63E64VXJGGSp5WCeFcCTp0v7q3Df3+CeXtPCSP7ulzLoCQvlYcNiJwVwuaMDpUqBmWB2z3utUIQaqArKdtUvrC+s6d2x0I2hCfeuPMsl8u+/+fLK4SDGsebzdRf0G6SjL/VN6jpOH+TnrZ38MSk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A56313858C52 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761368999; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0RiYCtUueMar6X/oB18Ft8BOjOnqQ3EnxwT6msEjGw4=; b=iRSG/aIb31bdpSAbWdEpuoFkue2OcKYbn3giYokdnMZcAcqER8pmklvt8f+JQjIRdS1Wuf wcA/PEAOtEPCbOmhyHDD/70RouDpA2tq/0KxceIDzdH1o9w21Gsvf1XeEh6SWiXYDrHtTc 3INN9p3gHY8HaBGLjARsLP1B1llcook= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-295-VvWLbnvQNY2U1QIhddHhvw-1; Sat, 25 Oct 2025 01:09:57 -0400 X-MC-Unique: VvWLbnvQNY2U1QIhddHhvw-1 X-Mimecast-MFC-AGG-ID: VvWLbnvQNY2U1QIhddHhvw_1761368997 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 083C719560AB for ; Sat, 25 Oct 2025 05:09:57 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.81.154]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 355CE180045B; Sat, 25 Oct 2025 05:09:55 +0000 (UTC) Date: Fri, 24 Oct 2025 22:09:53 -0700 From: Kevin Buettner To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: fix git repository check in gdb.src/pre-commit.exp Message-ID: <20251024220953.03422a3d@f41-zbm-amd> In-Reply-To: <5fa8de4b2b28278dbc3bf4ae78709ee9e71c3aa0.1761340690.git.aburgess@redhat.com> References: <5fa8de4b2b28278dbc3bf4ae78709ee9e71c3aa0.1761340690.git.aburgess@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: u280_eoBhVFXxqYAur5toXnsS_9sNAXlPjNrpd5flE0_1761368997 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Fri, 24 Oct 2025 22:18:19 +0100 Andrew Burgess wrote: > In the recently added gdb.src/pre-commit.exp test, we check if the > source directory is a git repository like this: > > if {![file isdirectory $repodir/.git]} { > unsupported "Not in a git repository" > return > } > > I make extensive use of git worktrees for development. In a worktree > .git is a file containing the location of the actual .git directory, > it is not itself a directory. As such, the above check fails, > claiming my source tree is not a git repository, when in fact, it is. > > Fix this by relaxing the check to 'file exists $repodir/.git', which > will cover the directory and file case. Makes sense to me... Approved-by: Kevin Buettner