From: "Kévin Le Gouguec" <legouguec@adacore.com>
To: gdb-patches@sourceware.org
Cc: "Kévin Le Gouguec" <legouguec@adacore.com>
Subject: [PATCH] Drop bashism from configure script
Date: Mon, 20 Oct 2025 17:23:10 +0200 [thread overview]
Message-ID: <20251020152310.1016355-1-legouguec@adacore.com> (raw)
In-Reply-To: <20251014164458.2000229-3-matthieu.longo@arm.com>
Results of evaluating 'test "no" == yes' in non-Bash shells range from
unfortunate (dash: "test: no: unexpected operator") to comically wrong
(AdaCore's gsh: returns 0).
---
FTR: formatted with -- ':!gdb/configure' to honor wiki recommendation
to drop generated files from list submission; local commit also
contains the regenerated gdb/configure.
gdb/configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/configure.ac b/gdb/configure.ac
index 5e5a3a01d06..9c258eedc75 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -1077,7 +1077,7 @@ AC_ARG_ENABLE([py-limited-api],
[GDB_CHECK_YES_NO_VAL([$enableval], [--enable-py-limited-api])],
[enable_py_limited_api=no])
-if test "$enable_py_limited_api" == yes; then
+if test "$enable_py_limited_api" = yes; then
# The minimal Python limited API version is currently set to 3.11 for the
# support of PyBuffer_FillInfo and PyBuffer_Release.
# The choice of the minimal version for the Python limited API won't be frozen
--
2.43.0
next prev parent reply other threads:[~2025-10-20 15:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 16:44 [PATCH v2 0/2] Add experimental option --enable-py-limited-api Matthieu Longo
2025-10-14 16:44 ` [PATCH v2 1/2] gdb: make Python conftest compatible with Python limited C API Matthieu Longo
2025-10-14 16:44 ` [PATCH v2 2/2] gdb: add experimental option --enable-py-limited-api Matthieu Longo
2025-10-20 15:23 ` Kévin Le Gouguec [this message]
2025-10-20 15:31 ` [PATCH] Drop bashism from configure script Tom Tromey
2025-10-20 15:46 ` Kévin Le Gouguec
2025-10-14 17:22 ` [PATCH v2 0/2] Add experimental option --enable-py-limited-api Eli Zaretskii
2025-10-15 9:03 ` Matthieu Longo
2025-10-15 14:01 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251020152310.1016355-1-legouguec@adacore.com \
--to=legouguec@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox