From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0dFaHB068GjtZjYAWB0awg (envelope-from ) for ; Wed, 15 Oct 2025 20:19:41 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=iQrREnvu; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7053C1E047; Wed, 15 Oct 2025 20:19:41 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 88C361E047 for ; Wed, 15 Oct 2025 20:19:40 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1FC943857C7B for ; Thu, 16 Oct 2025 00:19:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1FC943857C7B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=iQrREnvu Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id BB5CF3858286 for ; Thu, 16 Oct 2025 00:12:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BB5CF3858286 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BB5CF3858286 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760573525; cv=none; b=CQhfFGQZAQ2nwqOcAS5AdHiAhKKhFDiu563SHruSPtlpVLFFzhv70Z304weUDYlbOGC5FNDvNk5X4wH/VHmnpfoB/qlRWkcIflte9Hz77P9fAZqSbeiKzytXX7b4tfmpdOijfr7HoaDj+qcTwnxqlhbYmvmRcGHGChQTQlvMJ3w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760573525; c=relaxed/simple; bh=y4S+vrtLWVjrkyx2iZlLv2uFB1wgD3uoLc4aq5jWESk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Q4N3AEDSC9EwfEnEkMbwGfWdE8O1HUup7b1K7RvCA5Q6eNlSFzof+LdB4w5SF6xPtEU9xGtOXNWlcPZ37JqhxsTkjOtFW+N3OGCIKz5JJVagChuUvaPHb8S3QePLU4u4ubGrqoCMv0WkaNrYrc9PTwLwG2ZYCQQdJdk9TDRn2gs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB5CF3858286 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 59G0Bwpc069744 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Oct 2025 20:12:02 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 59G0Bwpc069744 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1760573523; bh=gLOApku/zuodvCM3vES3ubelRhEbb5yJuH7zMRaq3rE=; h=From:To:Cc:Subject:Date:From; b=iQrREnvufCeMAu5INpNa+j+o63bOB0sSh7GUlVUREYNbNIqoUbv3cVeFWq0RgCIBA w5vQ7srcxqYRsDT/Eaj4HmoisjZ4t+G0c2cStImAkg2mhgWYOcG/l9NGbdVdkakQ7d gg8sbmI6mNZRtQ/EfsKeg3BMwFychzpFVnlZ+Is0qpaYgGCBjG+HwaZzDK6c3CEiU1 +aqnLlDcx5FrDxB3Q9eJBAAxOg6pi6r+E6VOPyo5AXf3fXJzK9cZIuPLzvc+el+S2j opH7mhLaonXQYXHeyE9D3cr14lfs+jWDA70t9vNANbjpnjJwskwuMqrT7uGK9MmFXG kxzriyOXo+D8g== Received: by simark.ca (Postfix) id 3461D1E047; Wed, 15 Oct 2025 20:11:58 -0400 (EDT) From: simon.marchi@polymtl.ca To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 00/10] Rename some symtab find functions Date: Wed, 15 Oct 2025 20:07:54 -0400 Message-ID: <20251016001154.3969223-1-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 16 Oct 2025 00:11:58 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Simon Marchi I have long been confused by the names of the functions to look up things in symtab. For a function named find_foo_bar, it's not obvious if it finds a foo from a bar or vice-versa (answer: it finds a bar for a given foo). When asking around on IRC a while ago, a few people agreed. I'm therefore proposing to rename those functions to be of the form find_bar_for_foo. Simon Marchi (10): gdb: rename find_pc_function -> find_symbol_for_pc gdb: rename find_pc_sect_function -> find_symbol_for_pc_sect gdb: rename find_pc_sect_containing_function -> find_symbol_for_pc_sect_maybe_inline gdb: rename find_pc_compunit_symtab -> find_compunit_symtab_for_pc gdb: rename find_pc_sect_compunit_symtab -> find_compunit_symtab_for_pc_sect gdb: rename find_pc_line_pc_range -> find_line_pc_range_for_pc gdb: rename find_pc_line -> find_sal_for_pc gdb: rename find_pc_sect_line -> find_sal_for_pc_sect gdb: rename find_pc_line_symtab -> find_symtab_for_pc gdb: rename find_line_pc_range -> find_pc_range_for_sal gdb/aarch64-tdep.c | 2 +- gdb/alpha-tdep.c | 2 +- gdb/amd64-tdep.c | 10 ++-- gdb/amdgpu-tdep.c | 2 +- gdb/arc-tdep.c | 2 +- gdb/arm-linux-tdep.c | 2 +- gdb/arm-tdep.c | 4 +- gdb/block.c | 4 +- gdb/blockframe.c | 14 +++--- gdb/breakpoint.c | 24 +++++----- gdb/btrace.c | 2 +- gdb/c-exp.y | 2 +- gdb/cli/cli-cmds.c | 6 +-- gdb/compile/compile-c-support.c | 2 +- gdb/compile/compile.c | 2 +- gdb/cp-namespace.c | 2 +- gdb/cris-tdep.c | 2 +- gdb/disasm.c | 10 ++-- gdb/dwarf2/frame.c | 2 +- gdb/dwarf2/loc.c | 2 +- gdb/elfread.c | 2 +- gdb/eval.c | 2 +- gdb/frame.c | 6 +-- gdb/frv-tdep.c | 2 +- gdb/ft32-tdep.c | 2 +- gdb/guile/scm-block.c | 2 +- gdb/guile/scm-frame.c | 2 +- gdb/guile/scm-symtab.c | 2 +- gdb/h8300-tdep.c | 2 +- gdb/hppa-tdep.c | 2 +- gdb/i386-tdep.c | 4 +- gdb/ia64-tdep.c | 4 +- gdb/infcall.c | 2 +- gdb/infcmd.c | 24 +++++----- gdb/infrun.c | 16 +++---- gdb/iq2000-tdep.c | 6 +-- gdb/linespec.c | 6 +-- gdb/linux-fork.c | 2 +- gdb/loongarch-tdep.c | 2 +- gdb/m32r-tdep.c | 2 +- gdb/m68hc11-tdep.c | 2 +- gdb/macroscope.c | 2 +- gdb/mi/mi-cmd-disas.c | 2 +- gdb/mi/mi-main.c | 2 +- gdb/microblaze-tdep.c | 2 +- gdb/moxie-tdep.c | 2 +- gdb/namespace.c | 2 +- gdb/or1k-tdep.c | 2 +- gdb/printcmd.c | 6 +-- gdb/python/py-finishbreakpoint.c | 2 +- gdb/python/py-progspace.c | 4 +- gdb/python/py-record-btrace.c | 2 +- gdb/record-btrace.c | 4 +- gdb/reverse.c | 2 +- gdb/rs6000-tdep.c | 4 +- gdb/solib-frv.c | 2 +- gdb/source.c | 2 +- gdb/sparc-tdep.c | 4 +- gdb/sparc64-tdep.c | 2 +- gdb/symmisc.c | 2 +- gdb/symtab.c | 78 ++++++++++++++++---------------- gdb/symtab.h | 28 ++++++------ gdb/tracepoint.c | 16 +++---- gdb/tui/tui-disasm.c | 2 +- gdb/tui/tui-source.c | 6 +-- gdb/tui/tui-winsource.c | 10 ++-- gdb/v850-tdep.c | 2 +- gdb/xstormy16-tdep.c | 2 +- gdb/xtensa-tdep.c | 4 +- gdb/z80-tdep.c | 2 +- 70 files changed, 196 insertions(+), 196 deletions(-) base-commit: b6753354fbbe7c2c66ae9f452ba7aa049db0fe0c -- 2.51.0