From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WTCTO0ji6GhWVicAWB0awg (envelope-from ) for ; Fri, 10 Oct 2025 06:39:05 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=EgEJO/KD; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E27801E0B6; Fri, 10 Oct 2025 06:39:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BC7621E047 for ; Fri, 10 Oct 2025 06:39:03 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 24B07385843E for ; Fri, 10 Oct 2025 10:39:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 24B07385843E Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=EgEJO/KD Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 97D54385843E for ; Fri, 10 Oct 2025 10:38:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 97D54385843E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 97D54385843E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::632 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760092696; cv=none; b=tNfeVAeiWiQ2GbyiDcSVuyxOSUjH3NCOp+38gu7GeJBnw4yA/k2ZfPevGyTH/Y1K6MLAyMvSw5KEfBtRhXmyMq0qbZx2B+WdBB3R45+gIqgbQVlq2YRlCNtqhtHksB5wNFGnNR1manbGY0ppJXjVHbTwvnNlwE+WCFPcjOu7B7Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760092696; c=relaxed/simple; bh=7DcF3bUUsf/+tLB5Mq4/uOV/j1Fib2PWmiDrSGvn+OU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=V0B9rPrm1E9aqwFK1Quid/p8KHjI/DZn88h7iyJFR8p0N3ucBACsfvAwNZXTEy6qG07PDpaP+4Dt/VekkESF1TKuEgSgJF9peK4xBlgGB4Lv8vKOrnjY6ncxII9CiF2hwAUQeXOekkINzrpda5AyMSXxlaPuKhtjdDygqnoFaiM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 97D54385843E Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-27ee41e0798so31151535ad.1 for ; Fri, 10 Oct 2025 03:38:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760092695; x=1760697495; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wBcBDwAboD6iZj4vtb3M6Q3v1jPIdVzLYHTL3y8B7dE=; b=EgEJO/KDVS9mmcO4RfMubRVn1t+tKYvZBLVJO0xS7CsqDET5qniDuaSYXdTQOEsKQP xB9gOrzQDpGt/qRC7D4pjah+zvtN/2mJ9N80ds4ZDcFMi5Vh/onusSB3iOj5dKQf/llj JdAAbg2fQVuKAH7fFVcxwWJBdP00HnOyKg96khKALnGgeoDB5UPuonlY3j3/H34mc0fJ B9CEvjhttdQHS8EQVvcGkyxU15aHG6Z+5FmjTSiOmy6Uvg9RgNr03icp7KUAgQz9m7eG m7ithokZ6QvWRUy9sFyq+/HvcMTmRi80zDcOCjD7FFctvz1BquoixBpwV3OXG28IJmcV 9vow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760092695; x=1760697495; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wBcBDwAboD6iZj4vtb3M6Q3v1jPIdVzLYHTL3y8B7dE=; b=TLVJHSFwa93PY1BLOVXAb4pwvLyiS5F+jCUZ2gs3FxWKjs2pOglfMyy3CTDRJMFPt4 cvMlyXch7yOMTQbbhKXnhglTuFtjYUhWqDSnXj7vuL9iBQupFxvPuOZMxYQypBaez1/9 OE25m8ewMaGXIjIzpeA1ZJmS9S8uKOm+uX+7ZVSqMjVjxK0JOMbkvnd7YmizIM7GaBTP n7ezlyvJ4cISPNYwjDAlmAw+a7qSYdzah6wMoAjG8wI4gMdIqWTM1Ny3N9lNVzg/7pRn PGRXNh0haIZaDUCg3waMAbDIFalmAgqnzhL2r2FeRuZ3zzp66IVXy0vSJaD02g5Wno6P RLgg== X-Gm-Message-State: AOJu0YwP3nKhj82J3Emm5bIzaLg+UO9eh+5hsGTDZzVSOPMX2dudjVEr c2MoGuAJhDYyA/C+TioVcSRhHRsu39jhG7EnenhtgEa7MsuX3auIeeAz X-Gm-Gg: ASbGncvlNdI3MZ9PVwDGdiqY+A/aoNcBzKPc3ho0UfMPMW6xNbmgmOqsdEIYKZfZh0M BogpDVTA2U/GByEWusA04IeXDJf0WZrSihWPAD/Q4Ti/NnZn9FeJN1WzYbEtv6HndKt2d6gn84u ExWrN2b15dRmIUeUjE3yeeHxCquv9pr83Q2c17IP6w3zUDfFllUIovdgY/wgBrCSXqM0CgLbOKy StGkUk9gPFGs5Dn8QixOEDAiILnftwFT7sjxfrzb2z/pHLw14fujaifu7pJV1BWNkkitbNkBU2L WUHENpcU4v4qsoGtnsoC6i3L1eW4RnqgejVs4Q2+rWB/B7bh3UKTTQ/qJ7l0nSqrDSFdIN/jLXb iIS/axvkISVep03S55lsbAECYupeSFliI+1sm2wdrARXPOpIhJp76Arrz+RcvNdxSid0sGmY//Y LHMg== X-Google-Smtp-Source: AGHT+IEtQuJTeZO7l9wEbfe9FUQieaohxqUXWmZZmfrQth9vYcF7gG4GOZf1S2pqgEX1repeYmfE3g== X-Received: by 2002:a17:903:298c:b0:265:982a:d450 with SMTP id d9443c01a7336-290273ffbf1mr147295975ad.40.1760092695526; Fri, 10 Oct 2025 03:38:15 -0700 (PDT) Received: from localhost.localdomain ([129.41.58.0]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29034e20e8esm53526845ad.50.2025.10.10.03.38.13 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 10 Oct 2025 03:38:15 -0700 (PDT) From: Aditya Vidyadhar Kamath To: ulrich.weigand@de.ibm.com, tom@tromey.com Cc: gdb-patches@sourceware.org, Aditya.Kamath1@ibm.com, sangamesh.swamy@in.ibm.com, Aditya Vidyadhar Kamath Subject: [PATCH] Fix AIX CI build break. Date: Fri, 10 Oct 2025 16:06:39 +0530 Message-ID: <20251010103638.51128-2-akamath996@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Aditya Vidyadhar Kamath Recently AIX internal CI is broken. The error is as follows: -------------------------------- aix-thread.c: In function 'void sync_threadlists(pid_t)': aix-thread.c:857:53: error: cannot convert 'thread_info' to 'thread_info*' in initialization 857 | for (struct thread_info *it : all_threads_safe ()) | ^ aix-thread.c: In lambda function: aix-thread.c:899:61: warning: declaration of 'thread' shadows a previous local [-Wshadow=compatible-local] 899 | thread = iterate_over_threads ([&] (struct thread_info *thread) ---------------------------------- This patch is similar to the commit https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=675a17a8a5cde1d8be86536df2ae6366ef0ec759 all_threads_safe() returns an all_threads_safe_range which is like an iterator to iterate for loops. AIX is adjusting its code in aix-thread.c for the same. After applying this patch, Sample test case output: ------------ gmake check RUNTESTFLAGS='gdb.threads/thread_events.exp CC_FOR_TARGET="/opt/freeware/bin/gcc" CXX_FOR_TARGET="/opt/freeware/bin/g++" CXXFLAGS_FOR_TARGET="-O0 -w -g -gdwarf -maix64" CFLAGS_FOR_TARGET="-O0 -w -g -gdwarf -maix64"' gmake check-single gmake[1]: Entering directory '/upstream_gdb/binutils-gdb/gdb/testsuite' rm -f *core* gdb.sum gdb.log === gdb tests === Schedule of variations: unix Running target unix Using /opt/freeware/share/dejagnu/baseboards/unix.exp as board description file for target. Using /opt/freeware/share/dejagnu/config/unix.exp as generic interface file for target. Using /upstream_gdb/binutils-gdb/gdb/testsuite/config/unix.exp as tool-and-target-specific interface file. Running /upstream_gdb/binutils-gdb/gdb/testsuite/gdb.threads/thread_events.exp ... === gdb Summary === /upstream_gdb/binutils-gdb/gdb/gdb version 18.0.50.20251010-git -nw -nx -q -iex "set height 0" -iex "set width 0" -data-directory /upstream_gdb/binutils-gdb/gdb/data-directory -iex "set interactive-mode on" === gdb Summary === /upstream_gdb/binutils-gdb/gdb/gdb version 18.0.50.20251010-git -nw -nx -q -iex "set height 0" -iex "set width 0" -data-directory /upstream_gdb/binutils-gdb/gdb/data-directory -iex "set interactive-mode on" gmake[1]: Leaving directory '/upstream_gdb/binutils-gdb/gdb/testsuite' ---------------- --- gdb/aix-thread.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gdb/aix-thread.c b/gdb/aix-thread.c index 1e3015d77b0..7007f76b85a 100644 --- a/gdb/aix-thread.c +++ b/gdb/aix-thread.c @@ -854,14 +854,14 @@ sync_threadlists (pid_t pid) thread exits and gets into a PST_UNKNOWN state. So this thread will not run in the above for loop. Therefore the below for loop is to manually delete such threads. */ - for (struct thread_info *it : all_threads_safe ()) + for (thread_info &it : all_threads_safe ()) { - aix_thread_info *priv = get_aix_thread_info (it); + aix_thread_info *priv = get_aix_thread_info (&it); if (in_queue_threads.count (priv->pdtid) == 0 - && in_thread_list (proc_target, it->ptid) - && pid == it->ptid.pid ()) + && in_thread_list (proc_target, it.ptid) + && pid == it.ptid.pid ()) { - delete_thread (it); + delete_thread (&it); data->exited_threads.insert (priv->pdtid); } } -- 2.41.0