From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FAMPCWVj4GgiVx4AWB0awg (envelope-from ) for ; Fri, 03 Oct 2025 19:59:33 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dvF/jNFe; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 12CBC1E0BA; Fri, 03 Oct 2025 19:59:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3CCF81E04C for ; Fri, 03 Oct 2025 19:59:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BE9DA385781B for ; Fri, 3 Oct 2025 23:59:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BE9DA385781B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dvF/jNFe Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id CB7E53858D33 for ; Fri, 3 Oct 2025 23:58:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB7E53858D33 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CB7E53858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759535933; cv=none; b=P/lVhtGXvFVl3oFpEtaRMs9DLIoTvE53UIzisvifeubtUBpuN7v3oV0EG4tolxLW0yWUZSy0YasZJfvYXn+E0aiNSNM0uQqYOm+t54ujcDv0xcJ8+C9nb45eXjVFmcJ4dPynqZASfEHbUYpjgU41HN1kFK3D0aZqd3Rt/eoD2Ng= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759535933; c=relaxed/simple; bh=R/VAT1HWEwXK5A4uqOBWDMZWx667HrEnPP1TKJUkl4A=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=IW595Trg+6Qsh5ycbR+oOlC+2tkJ1hKNWL+fKglBDssVs92vW1f6nKs52Dj3c9PQlI8OmmczU/IujKQ6WBr7IrPFkpAKHZD2fKg8+9/P25MW9DqNa/rbvf4WuIGdGJkgEhichRCUjMS5KOdrD3SMIoYFLn3zwcES0vKVkuAgdDs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CB7E53858D33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759535933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0bKHn2PrIpBRaakabFYyMago5qsxInhWlPjZ4zLph4Y=; b=dvF/jNFeNEma0k1Q8DycmW25A7Ewf05aQ/pCZXl2oN19R7F0btGqqfLKAf8brie61A8mwi I2lu8gRiA/boK2xd9CsD2esNn9zbBwk9kr6Mq9LLlWIFRS+bs2rRBf9E1zEFVx9xFQTLDU HoJfM1rBXDcmu1+CpJcgR9U5X2IBYJY= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-272-o3n4L0R0Pdy8gEKtiD-bnQ-1; Fri, 03 Oct 2025 19:58:49 -0400 X-MC-Unique: o3n4L0R0Pdy8gEKtiD-bnQ-1 X-Mimecast-MFC-AGG-ID: o3n4L0R0Pdy8gEKtiD-bnQ_1759535929 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ED29319560B2; Fri, 3 Oct 2025 23:58:48 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.64.96]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DCF9518004D8; Fri, 3 Oct 2025 23:58:47 +0000 (UTC) Date: Fri, 3 Oct 2025 16:58:43 -0700 From: Kevin Buettner To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] More "return" cleanup in gdb.ada Message-ID: <20251003165843.6f8b1586@f41-zbm-amd> In-Reply-To: <20251003181554.2763633-1-tromey@adacore.com> References: <20251003181554.2763633-1-tromey@adacore.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: F51DYvXn9VpLpUxhlcbElTVf5d0LLrgYXSPaUEDxge0_1759535929 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Fri, 3 Oct 2025 12:15:54 -0600 Tom Tromey wrote: > I found some more spots in gdb.ada where a "return" has a value but > does not need one. This patch cleans these up. LGTM. Approved-by: Kevin Buettner