From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ofhBB+bZ0WhEmg4AWB0awg (envelope-from ) for ; Mon, 22 Sep 2025 19:21:10 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=uofr.net header.i=@uofr.net header.a=rsa-sha256 header.s=selector-1 header.b=Yv585bO7; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 189161E0BA; Mon, 22 Sep 2025 19:21:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5BCB41E04C for ; Mon, 22 Sep 2025 19:21:09 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EFD653858C2F for ; Mon, 22 Sep 2025 23:21:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EFD653858C2F Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (1024-bit key, unprotected) header.d=uofr.net header.i=@uofr.net header.a=rsa-sha256 header.s=selector-1 header.b=Yv585bO7 Received: from uofr.net (uofr.net [50.116.51.30]) by sourceware.org (Postfix) with ESMTPS id CDB363858D38 for ; Mon, 22 Sep 2025 23:18:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CDB363858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=malsyned.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=malsyned.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CDB363858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=50.116.51.30 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758583112; cv=none; b=xiPeRbpTeyahwXSjl1GLB381dJjm58lYyHxOqwVmVSP7libtWxhgwmpVkQl/nr1fNKURw/Dh3Q3AYnAtoAPxc1bpyZR/WObxAcQqbBJYEXjGGRxfVvTncwQ90vqHMtOL5tCqh3X7bkdj1qDMYCBRQD9uB3rWxsmxUREyXJcWU8M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758583112; c=relaxed/simple; bh=wDbJ3xqCFd7W3u1H5IUeJc3vhTBAlv+mE6uEGwcVWX4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=cKo+GWQ/btFMdlCYD6KXYhFVLnvw7dFIcPOqBxHrkCHNU7UuTJlV+gNWv63XH4qNX9jfy/ucrJYkOfcspPSY0HNk5QrrVfRj1tkfnWt5QWDIbKPPyw+pWY1wa7k080ZupQfdvwsIHL6ncl1ubLgSzvhm6HvDJ7rK2Z9biVOEJNs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CDB363858D38 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=uofr.net; s=selector-1; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To :Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3Crn2ZourDPj5o5uwOxeu7pIMeTlYyfMmPZO8FUAo48=; b=Yv585bO77J+2FE7FBQ921i/wcD UpuOFjrRO9u0ovsTC/s38U1bxRSGCV/qiL6F+m/vG5eA+0tS0KqK5tUJbtsvsT6czTxig7DlS3Vbd XLAP+DArCKn+iUhfGX7ICTopQVUVl/2K4oEpqReJSVx0Id+xNDZo6SmwUOG8BKJUVWzc=; Received: from c-75-67-96-172.hsd1.ma.comcast.net ([75.67.96.172] helo=malsyned.hsd1.ma.comcast.net) by uofr.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1v0pne-00B0ww-BH for gdb-patches@sourceware.org; Mon, 22 Sep 2025 19:18:26 -0400 From: "Dennis Lambe Jr." To: gdb-patches@sourceware.org Subject: [RFC][PATCH 1/5] [PR gdb/33469] ui_out: add optional async param to redirect() Date: Mon, 22 Sep 2025 19:18:16 -0400 Message-ID: <20250922231820.2667505-2-malsyned@malsyned.net> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250922231820.2667505-1-malsyned@malsyned.net> References: <20250922231820.2667505-1-malsyned@malsyned.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This adds a new overload of the protected do_redirect(), rather than adding an extra optional parameter, so that it can provide a default implementation of the two-parameter form without disturbing implementations that don't care about this distinction (which is all but one of them). Most uses of redirect(), such as in buffered_streams, assume that this sort of state won't change during the redirect, so the default for the one-parameter overload is to forward to the two-parameter form with async = false. --- gdb/ui-out.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gdb/ui-out.h b/gdb/ui-out.h index 1796e9c9eb3..f7d6be2b026 100644 --- a/gdb/ui-out.h +++ b/gdb/ui-out.h @@ -263,7 +263,8 @@ class ui_out void flush () { do_flush (); } /* Redirect the output of a ui_out object temporarily. */ - void redirect (ui_file *outstream) { do_redirect (outstream); } + void redirect (ui_file *outstream, bool async = false) + { do_redirect (outstream, async); } ui_out_flags test_flags (ui_out_flags mask) { return m_flags & mask; } @@ -368,6 +369,8 @@ class ui_out virtual void do_wrap_hint (int indent) = 0; virtual void do_flush () = 0; virtual void do_redirect (struct ui_file *outstream) = 0; + virtual void do_redirect (struct ui_file *outstream, bool async) + { do_redirect (outstream); } virtual void do_progress_start () = 0; virtual void do_progress_notify (const std::string &, const char *, -- 2.51.0