From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UmI1HjLLymg9BQgAWB0awg (envelope-from ) for ; Wed, 17 Sep 2025 10:52:34 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=Ia7+q/aG; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6B3B71E04C; Wed, 17 Sep 2025 10:52:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AD50D1E04C for ; Wed, 17 Sep 2025 10:52:33 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3FA98385703B for ; Wed, 17 Sep 2025 14:52:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3FA98385703B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=Ia7+q/aG Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by sourceware.org (Postfix) with ESMTPS id 74B303857737 for ; Wed, 17 Sep 2025 14:51:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 74B303857737 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 74B303857737 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::135 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758120717; cv=none; b=K+aVvQy7wStBMANbZoxuPQpiXRHgCg6HI8YAxOmBxLX5CKfGXM+hGLMpPUqorFDqzJMcHnmi913ewOdpCtAPJulrt7O8sTqUH9Aq4h8w8dAttJrI3Ftq78hyHVMc/OySr6i7c9b3aC17ArXowZmh9W1pGKklvEsSlBQUhzsqPXg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758120717; c=relaxed/simple; bh=wf0lSYAsIZfxn+nExY/3H79sjvaJwMXulY93T+IkAfA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=nzevsMlMYX7rX960JnXLwiciLjS3J0EmmJ3/YX3C9+KWWUClZp/q7jmqNSKqOUvth9IrrcOGm4fl7WSJZilFILHOepYCWLUYotYBGYR+IDjMG92iRxqk1rW0B9ZKbeXgCY0zJ0XFSYukn9vF4FDYvuGW1mD5y7KX8odp6tveuF8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 74B303857737 Received: by mail-il1-x135.google.com with SMTP id e9e14a558f8ab-423fb9a534cso26051115ab.3 for ; Wed, 17 Sep 2025 07:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1758120716; x=1758725516; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Bb1OTrFCqfBvWgsroxp2a3TzqSDWVRM60g9+Jnak22w=; b=Ia7+q/aGJzjQkNmDngLlTBaz5TpwdZneYns+q3FXjKStlJMv3MfGG4pVIHwY0SPUV6 GwT9gWQwiy9ZwXhRWHMPiAD2Y8SLWxdZ+wECeYuxqDSBrKMSj8yJs5Zld6+NGBrH92Hs RqF8r5dMfLtft7lMBxaw4M1vCBqCSNUOY5NUysQm6nT7z/Li6ZbC2wfPjz579dt34MtM /B+xPU5dRYBovRoNOmZARQscAb985y7TdUy/e3z5fFJb9bDM4p5rup7fzA5uoEnGF5AK 3ybZunEDw/Pjxpjk6bMwYFwnjBIpnI4X9mdQMgd7mK26MIm0RBViNXfhpkc8dkQbysuD fEgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758120716; x=1758725516; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Bb1OTrFCqfBvWgsroxp2a3TzqSDWVRM60g9+Jnak22w=; b=lh4g2B+CxRbT2aCgn7lgG5ZLeHlVdaRpM2wMCXK9jMdEnn1+kNBQaR7E+kdEwy2lEc w7UtKMh7ZbJafLToj0i+jBy5/gzdSheIWnVlOwL2S9z43gjKlulIr5EmIdZxtuGNc2K4 43u+F/2qDkTTepP/vD8cAiNR1d2VAn36TzjDJaEmRoe8So1xpfLaoSWp9wKMDu6bQFvJ Gf+46vBe1N0qED+bZxSwugSTXHV1OJ4Qlza379RAde0EFtYPBnp2ZilpOmeS5Aq9YBvV w1ZzLVo/j4Y1F/khJPnLR3c1Z3FVYc0HC7QKxMCHTxsoqwpXd/RzGWXpiBhBoZAlyZvC clNQ== X-Gm-Message-State: AOJu0YxeGgcbZJSs7pJL5ix20T+Z30h8eZEX6R9SvOPTr5eGBUCxdint UOMr2ICHVkGRlp5Xy6W2MaPqf15GvY4wAmDIINeWQ7z6RqB0irfoy7uARvR9nRkz7EFKu4ZE8n5 +qfo= X-Gm-Gg: ASbGncucQq7oP3BXZjTLvl6PH9QdhKk8EuuEOiS73F4Wkdgbz1CuTXRsbOFAKm+Qo+k UkgVO8fyn7NQNqwjcD4TfrLGtrr4+dlwblt/debmzqsb4tYn2LcY6OQ7dU73AlTAvAXXEDZ6nxl lT9pc7jC8hCFezMqRD2bun9Z8Q6+aBGke9Vy1/O9Q/nAuE85OjlFOUrFjsdQNPbog2esmN5PEKp drKtbbG9puW0oRp8zyy8dJmRxNnTnwRrZXGjBmnB9cjR2fxN2v6V1QekcEqB4SScFM4hgWK/YP2 BHhpQKphlh9lu5Rp21G4PFKfB3k9DeHuNigX5t7cErXKDhn7uUpS6cPu2gpb8ThsuIat/uDp4cH azSZtJ7FXDU9kKfriNAkHWbBor7T6rPbRZGGVwBk4jQ== X-Google-Smtp-Source: AGHT+IGCGUoyxZOWal30bWAryRWaWibi/isI5wJKDebW99w7qlIAP2DGN70ZBxSjyl+nrVYpBwGlIg== X-Received: by 2002:a92:cd84:0:b0:423:fd07:d3f0 with SMTP id e9e14a558f8ab-4241a5263d1mr26887945ab.26.1758120716489; Wed, 17 Sep 2025 07:51:56 -0700 (PDT) Received: from bapiya (97-122-110-68.hlrn.qwest.net. [97.122.110.68]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-42408aaecd8sm37240685ab.36.2025.09.17.07.51.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Sep 2025 07:51:56 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Have gdb.ThreadExitedEvent inherit from gdb.ThreadEvent Date: Wed, 17 Sep 2025 08:51:54 -0600 Message-ID: <20250917145154.2690156-1-tromey@adacore.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org The documentation says that ThreadExitedEvent is derived from ThreadEvent, but the code does not actually implement this. This patch fixes the problem. I propose applying this to gdb 17 as well. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33444 --- gdb/python/py-event-types.def | 2 +- gdb/testsuite/gdb.python/py-thread-exited.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/gdb/python/py-event-types.def b/gdb/python/py-event-types.def index 15cd9faae69..83167f36163 100644 --- a/gdb/python/py-event-types.def +++ b/gdb/python/py-event-types.def @@ -54,7 +54,7 @@ GDB_PY_DEFINE_EVENT_TYPE (new_thread, GDB_PY_DEFINE_EVENT_TYPE (thread_exited, "ThreadExitedEvent", "GDB thread exited event object", - event_object_type); + thread_event_object_type); GDB_PY_DEFINE_EVENT_TYPE (new_inferior, "NewInferiorEvent", diff --git a/gdb/testsuite/gdb.python/py-thread-exited.py b/gdb/testsuite/gdb.python/py-thread-exited.py index ef5a2441b8e..f725bd585c9 100644 --- a/gdb/testsuite/gdb.python/py-thread-exited.py +++ b/gdb/testsuite/gdb.python/py-thread-exited.py @@ -26,6 +26,8 @@ def thread_exited_handler(event): global threadOneExit, threadTwoExit, mainThreadExit print("{}".format(event)) assert isinstance(event, gdb.ThreadExitedEvent) + # Also check the inheritance. + assert isinstance(event, gdb.ThreadEvent) if threadOneExit == "": threadOneExit = "event type: thread-exited. global num: {}".format( event.inferior_thread.global_num base-commit: 311378bc3b871b199f439152c39debb7ec02e21c -- 2.51.0