From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ZqcSMKXKxWjSMgMAWB0awg (envelope-from ) for ; Sat, 13 Sep 2025 15:48:53 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Wr1kSq5e; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AC5601E0BA; Sat, 13 Sep 2025 15:48:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F068B1E04C for ; Sat, 13 Sep 2025 15:48:52 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5B4C83858D32 for ; Sat, 13 Sep 2025 19:48:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5B4C83858D32 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Wr1kSq5e Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 8F91A3858D21 for ; Sat, 13 Sep 2025 19:48:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8F91A3858D21 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8F91A3858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757792902; cv=none; b=ip/SFIyye7sZxhBlob7ViyQ1nT2ruPKYONrbcQEj7/X3VtUWIAak/gpyg9prGae/pKmqJe6ljJF7ZZh2AV1+Dkrmkr52fnMtCiVTdADnIDOx9y8qdj4eC5XszvqOB33eLVrY/3EUlPQnzBqdfnpjdZOo4uFP0FFlstDCRFKFJfk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757792902; c=relaxed/simple; bh=bxeRuLCl6MCV4BxdN6XHrxmO1uZ1fvjqoBnZ0GUl7oM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=UCx9mj2Yga5mFIZp/tS3nI3j+fYlrpOry5Y+FfFJwCIIb6nVh3O+PHV77rS8LZOQVq0HI/7v4eJp2KyoTOyaQU8wkpKMPON2SJwOznbbW/38P5R1aKphoI5XsWXYca8+3Hopop1fpHFiIlyGsmQ4rvpq3Xp5oxABiOan8wTOBWI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8F91A3858D21 Received: from eig-obgw-5002b.ext.cloudfilter.net ([10.0.29.226]) by cmsmtp with ESMTPS id x88wul4ITKXDJxWEQue2RT; Sat, 13 Sep 2025 19:48:22 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xWEPu2WjacGiCxWEPuIqds; Sat, 13 Sep 2025 19:48:22 +0000 X-Authority-Analysis: v=2.4 cv=V8590fni c=1 sm=1 tr=0 ts=68c5ca86 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=yJojWOMRYYMA:10 a=ItBw4LHWJt0A:10 a=8S97KhT0LDiSB82IaM8A:9 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=eP9MDl1qYPTtZDl3WnkB0iFgXf7xnIbC2xZJVCZic/s=; b=Wr1kSq5e+fSG6YM3hlShPj+SsE y2F2iZjeuL0pSmaFxGywYjkpxmW+wHHJ32NuUPauIm+q2kdZY4lgO90Z8tRnyW2aXWZxN+JUpjoCV 3UA1Vp0KvoDqyH4r7h0LFscnt; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:53434 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uxWEP-00000000hEb-0zT7; Sat, 13 Sep 2025 13:48:21 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Fix crash in f-typeprint.c Date: Sat, 13 Sep 2025 13:48:11 -0600 Message-ID: <20250913194811.933550-1-tom@tromey.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1uxWEP-00000000hEb-0zT7 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (localhost.localdomain) [97.122.110.68]:53434 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfGiXy7smj6/muDbtAdey/7eIR0mcuEVgUfRjkACw4XGchJD/qQIPSdfq/+sYNH+U0st1QNWbLfaFR3gzDMPt1YRrSxN/Pd9wQdt/SEdqyK7zFFzLDYoY xqL1lhf1kIn2/PcegqhuYtWHdKOiAPJ2gUBwqlpjF5+me2XB4lTIhbcWWJZjT/szlhSPwKycLeglS2KY4ExEDUjKQUcvzb53L9Q= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I noticed a crash in f-typeprint.c that was hidden by an xfail: XFAIL: gdb.fortran/vla-array.exp: print variable length string array type (GDB internal error) (PRMS gcc/101826) I think this was introduced by commit 6594ca4a ("do not handle a NULL linebuffer in pager_file::puts") but not detected due to the xfail. It seems bad for an xfail to cover up a crash but I haven't investigated that. Meanwhile, this patch fixes the crash by checking for a NULL pointer when calling gdb_puts. --- gdb/f-typeprint.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gdb/f-typeprint.c b/gdb/f-typeprint.c index e96d27c537e..65c58b59b2d 100644 --- a/gdb/f-typeprint.c +++ b/gdb/f-typeprint.c @@ -414,7 +414,8 @@ f_language::f_type_print_base (struct type *type, struct ui_file *stream, gdb_puts (" ", stream); - gdb_puts (type->name (), stream); + if (type->name () != nullptr) + gdb_puts (type->name (), stream); /* According to the definition, we only print structure elements in case show > 0. */ @@ -432,7 +433,8 @@ f_language::f_type_print_base (struct type *type, struct ui_file *stream, gdb_puts ("\n", stream); } gdb_printf (stream, "%*sEnd Type ", level, ""); - gdb_puts (type->name (), stream); + if (type->name () != nullptr) + gdb_puts (type->name (), stream); } break; -- 2.49.0