From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8wQ0GdLmxWhxTAMAWB0awg (envelope-from ) for ; Sat, 13 Sep 2025 17:49:06 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ElN8I5SQ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 489471E047; Sat, 13 Sep 2025 17:49:06 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 55ED41E047 for ; Sat, 13 Sep 2025 17:49:05 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EE7EE3858C40 for ; Sat, 13 Sep 2025 21:49:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EE7EE3858C40 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ElN8I5SQ Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 6FE4B3858D21 for ; Sat, 13 Sep 2025 21:48:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6FE4B3858D21 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6FE4B3858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757800111; cv=none; b=j1DPIC+XwUPo5AjRWGZI8j9gnVzZ3ytVfT2jMsulxlKkWSU0YVfoBQi72KLuZUfC5iF692jLPQsYvFk2/xhkmtYbAFhQksmRkm3SJI510lc1NA5IGp7K68nU7NtiGXRuYH7yqpeL1A2XoqrYJcmMi5lbB0YrTpN7jU0vfEn2tP8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757800111; c=relaxed/simple; bh=KV5BUbr9JggIcKsmlyDmJGlWMugSatrQ8wvpXjQv/LM=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=V08G2oCxkWXRPPsLZdWTMRyfKHKoczNwthVe/GcwFl/OC/hF91TTWUCe+ZTPGLNyG4sDKk8ytxOheGsJ5tDMjt67biR8Ip66H6BY8V/MAC4tS2ugUPOw+KjpYfH8UoiiJAM+qsDP8mr8IDR6pcCatBnT5qo01cX4WHOT/9uhgMI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6FE4B3858D21 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757800110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0pgsio5/USBu7Qolj+jjcdfncTSs8RKHSO/gdfaAVjI=; b=ElN8I5SQAPPWBjG06jzo3Vcr4Heb1DYWgEiMJ44/vmqQF7uNT7KAeiJAsr7oIcW6HkRLUy IWmuGY0sNkY6wm5i+AhZkelXcekBUaf8IRD6+3W463GIG+fsI5684RpXPhN+cbKFy93OWO HVAchtNTNRBUQn8FUrd4UlQfbQoIWUY= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-678-akXpAQ4iP-ebmuFbGlZZWA-1; Sat, 13 Sep 2025 17:48:29 -0400 X-MC-Unique: akXpAQ4iP-ebmuFbGlZZWA-1 X-Mimecast-MFC-AGG-ID: akXpAQ4iP-ebmuFbGlZZWA_1757800108 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 784B21956050; Sat, 13 Sep 2025 21:48:28 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.64.42]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9A42F1954126; Sat, 13 Sep 2025 21:48:27 +0000 (UTC) Date: Sat, 13 Sep 2025 14:48:23 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: Re: [PATCH] Fix crash in f-typeprint.c Message-ID: <20250913144716.5ecd1209@f41-zbm-amd> In-Reply-To: <20250913194811.933550-1-tom@tromey.com> References: <20250913194811.933550-1-tom@tromey.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xWgbMuoxgrYNYaaqpbvLcffMo0j-5_1CmhLdmIqRAVQ_1757800108 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Sat, 13 Sep 2025 13:48:11 -0600 Tom Tromey wrote: > diff --git a/gdb/f-typeprint.c b/gdb/f-typeprint.c > index e96d27c537e..65c58b59b2d 100644 > --- a/gdb/f-typeprint.c > +++ b/gdb/f-typeprint.c > @@ -414,7 +414,8 @@ f_language::f_type_print_base (struct type *type, > struct ui_file *stream, > gdb_puts (" ", stream); > > - gdb_puts (type->name (), stream); > + if (type->name () != nullptr) > + gdb_puts (type->name (), stream); If you can't print the type, I'm wondering if it makes sense to print the space before it? (I.e. look at the gdb_puts a few lines above...) Kevin