From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2VhmMazdvWgUlzAAWB0awg (envelope-from ) for ; Sun, 07 Sep 2025 15:31:56 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=a8Qdb0zm; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9E5391E047; Sun, 07 Sep 2025 15:31:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C6F9D1E047 for ; Sun, 07 Sep 2025 15:31:55 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 450143858D3C for ; Sun, 7 Sep 2025 19:31:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 450143858D3C Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=a8Qdb0zm Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id ED7993858D33 for ; Sun, 7 Sep 2025 19:29:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ED7993858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ED7993858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757273362; cv=none; b=dBKpX4B5vk4Pte9yY/AIFiJI7uVk3K0f8mvLgNjIQvHvjgwj6RVHi1j4SIbxxeGjMIqG33V/NHlAZmM9b/h+HMdDcuSmuZKqByMii9UenbtiTNg3IQIkgrC1pYASh/I/aBFrUr78FpxebLho2T+wYaGcmxuw/d90hHyuaBdWl/E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757273362; c=relaxed/simple; bh=EGLP1lFiFv+0HY/av85wLb0qN+K1xy8Zm/TK1Eo5Lfs=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=Qwq4VgWyMRkHdfN7eeDMQE0EGZ97u1rrjW0bC8wqGskn0I9pDqkEsaCSeO4OB0EFjLXosUcvzQVnuvHsWXmfn6GQHgL8ZRKoIUK/iY2lLl9keR4P3KAQVS/+decUb7odwJ2p4Vir2h3LjA9/hZRnq2G/vYhapmgcAQeIzg9sGao= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ED7993858D33 Received: from eig-obgw-5005b.ext.cloudfilter.net ([10.0.29.189]) by cmsmtp with ESMTPS id vGs7uSXCFv724vL4euroeb; Sun, 07 Sep 2025 19:29:16 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id vL4duvtpxHNANvL4euAuz7; Sun, 07 Sep 2025 19:29:16 +0000 X-Authority-Analysis: v=2.4 cv=UOHdHDfy c=1 sm=1 tr=0 ts=68bddd0c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=ItBw4LHWJt0A:10 a=EPNUssaFdvoqvQrepmEA:9 a=QEXdDO2ut3YA:10 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=m5ItSZc8lyxstqe0yUlpw5MXI9TrS6ooGqDB5ue0Nhc=; b=a8Qdb0zm0rLtQZENziReOYzV23 /4h4osCinRkM6ehiiZnV/VIzYfdcjWo2gUO8ksKRsz8HTm8LWcou6B3JX8Gj2Lty3s4m8V+7iDbIH pmRUAuQWV6bXA85oZr52k8bio; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:43620 helo=[192.168.0.17]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uvL4d-00000003nLh-1syJ; Sun, 07 Sep 2025 13:29:15 -0600 From: Tom Tromey Date: Sun, 07 Sep 2025 13:29:15 -0600 Subject: [PATCH 3/7] Boolify line-program.c MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250907-breakpoint-cu-expand-v1-3-dd2beef9d475@tromey.com> References: <20250907-breakpoint-cu-expand-v1-0-dd2beef9d475@tromey.com> In-Reply-To: <20250907-breakpoint-cu-expand-v1-0-dd2beef9d475@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.2 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1uvL4d-00000003nLh-1syJ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net ([192.168.0.17]) [97.122.110.68]:43620 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDixIPBMG4zQJUKnxXGCGBFQiOdsT/1hx9dBAmKvXDskZWyuplET0lZz3Q1gW/YlbJAyanjOivSauH2/sMwKn+gQy/TwnHVMxzjT/HGn/KzlZoXiqXPn fKEroDG8xRx6BIlELyS8QuKNUy0cL0/7Faj4UyBo+xkqqrP18/dDFK0fdSCgHquMKs5g8nhK1pYEKmEUg+YJmR0NTtat6PHI07E= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This changes some code in line-program.c to use bool rather than int. --- gdb/dwarf2/line-program.c | 12 ++++++------ gdb/dwarf2/line-program.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/gdb/dwarf2/line-program.c b/gdb/dwarf2/line-program.c index 72bdd1f5a748ce228114105597b1e5a162254f69..5292d3d5e86722bc6d60b049740982c06550ef76 100644 --- a/gdb/dwarf2/line-program.c +++ b/gdb/dwarf2/line-program.c @@ -291,22 +291,22 @@ lnp_state_machine::handle_const_add_pc () Note: Addresses in the line number state machine can never go backwards within one sequence, thus this coalescing is ok. */ -static int +static bool dwarf_record_line_p (struct dwarf2_cu *cu, unsigned int line, unsigned int last_line, int line_has_non_zero_discriminator, struct subfile *last_subfile) { if (cu->get_builder ()->get_current_subfile () != last_subfile) - return 1; + return true; if (line != last_line) - return 1; + return true; /* Same line for the same file that we've seen already. As a last check, for pr 17276, only record the line if the line has never had a non-zero discriminator. */ if (!line_has_non_zero_discriminator) - return 1; - return 0; + return true; + return false; } /* Use the CU's builder to record line number LINE beginning at @@ -706,7 +706,7 @@ dwarf_decode_lines_1 (struct line_header *lh, struct dwarf2_cu *cu, void dwarf_decode_lines (struct line_header *lh, struct dwarf2_cu *cu, - unrelocated_addr lowpc, int decode_mapping) + unrelocated_addr lowpc, bool decode_mapping) { if (decode_mapping) dwarf_decode_lines_1 (lh, cu, lowpc); diff --git a/gdb/dwarf2/line-program.h b/gdb/dwarf2/line-program.h index c84403253e635225d7c27d49a91dd1581fa0fa2e..824f18f9613c55a714d1889666ad25045ba1dba8 100644 --- a/gdb/dwarf2/line-program.h +++ b/gdb/dwarf2/line-program.h @@ -42,6 +42,6 @@ extern void dwarf_decode_lines (struct line_header *lh, struct dwarf2_cu *cu, - unrelocated_addr lowpc, int decode_mapping); + unrelocated_addr lowpc, bool decode_mapping); #endif /* GDB_DWARF2_LINE_PROGRAM_H */ -- 2.49.0