From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sZ+RGeflumhL6hYAWB0awg (envelope-from ) for ; Fri, 05 Sep 2025 09:30:15 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=TDow7O16; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4AE391E087; Fri, 05 Sep 2025 09:30:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_LOW,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6F57B1E023 for ; Fri, 05 Sep 2025 09:30:14 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EA6ED3857C5F for ; Fri, 5 Sep 2025 13:30:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EA6ED3857C5F Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=TDow7O16 Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id E16C83858D37 for ; Fri, 5 Sep 2025 13:29:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E16C83858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E16C83858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757078981; cv=none; b=QNqfUvoIOlJcCm5Bk9KODgss2/OlSDlC2mK8QCTt6epCHaydvLxxdB5lgomz6hIyhsinjQcsL6Il0ioSkJBzOMkpKIpKAbVaKZqK+ORn/gTPSvwAt+ENxz/rDruJVZJUn5tqWFrx+oXyQ0kvk8EYh4U5HOUSVp6dLW1IsiZ0fQA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757078981; c=relaxed/simple; bh=AwrDpUBjmdnHTU/JuKpYUBbIcrg3WkfVoZPYZm0Lh0M=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=WQoC95aY+C4quBgAb01L06LqeZRf14KhVflhPBKq9Pr6vUDtSvaqQkc4SlN0WSs5rheOChGz6CrMWlQiTntdUsD1fcORLBnvyZ33EXeZZ3ItwmATaDd4xEXP1RfW/pwACfGOigxcFk0xRqPbvrg1lYhEiJ0TL5h/0UidLNrPHwQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E16C83858D37 Received: from eig-obgw-6005b.ext.cloudfilter.net ([10.0.30.162]) by cmsmtp with ESMTPS id uJs4uSU1ljzfwuWVYub7vk; Fri, 05 Sep 2025 13:29:40 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id uWVXugoZgOIXAuWVXuDpCP; Fri, 05 Sep 2025 13:29:39 +0000 X-Authority-Analysis: v=2.4 cv=bKsWIO+Z c=1 sm=1 tr=0 ts=68bae5c3 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=yJojWOMRYYMA:10 a=ItBw4LHWJt0A:10 a=CCpqsmhAAAAA:8 a=zVk4FHR8BQB7KGqt8B0A:9 a=ul9cdbp4aOFLsgKbc677:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=J/Mu/cdf4JbsK3kXviQW83bfmT7pcqg+vOF1FQ1GOfo=; b=TDow7O16fzGn7xgMeKzCwP8AlV x5kzSWq3JYa6G6DaZdU2+Ql6LCIqn9tzVVX+1j+NHM75mXC3m+8OI2eBqokFX7QPbu/CqP6vKA1eR r2CZ+tPa2mVTUNDO2IMnVkUke; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:48288 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uuWVX-00000001mt6-0tIq; Fri, 05 Sep 2025 07:29:39 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Allow conversion of 128-bit integers to Python Date: Fri, 5 Sep 2025 07:29:26 -0600 Message-ID: <20250905132926.460147-1-tom@tromey.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1uuWVX-00000001mt6-0tIq X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (localhost.localdomain) [97.122.110.68]:48288 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfAcrvcK3KVAlhl3THPUbQ1ZW6W7nOtYp1cqRgKuLt8fB+UopDMPER0Q/j7AYxNiUW3FEDbNqo4XmfWTQebPFw9vF18cIJA3U5no3VwRcANu5TMFiU5af ZeVOi4exCzLGHON0UwR8BAIfjqb2HMjRhnufBXuR8/njVCvPoMIfIN5/WmtjLcGmV96QSgIgaJnaj6MD2sKjJEMm8JeMFtgjyOY= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Currently, trying to convert a 128-bit integer from a gdb.Value to a Python integer will fail. This is surprising because Python uses bigints internally. The bug here is that valpy_long uses value_as_long, which fails for anything wider than LONGEST. This patch fixes the problem by using the recommended Python API. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33366 --- gdb/python/py-value.c | 41 +++++++++++++++++++++++---- gdb/testsuite/gdb.python/py-value.exp | 12 ++++++++ 2 files changed, 47 insertions(+), 6 deletions(-) diff --git a/gdb/python/py-value.c b/gdb/python/py-value.c index 833ce26d5a3..973785b5e4a 100644 --- a/gdb/python/py-value.c +++ b/gdb/python/py-value.c @@ -1866,7 +1866,7 @@ valpy_long (PyObject *self) { struct value *value = ((value_object *) self)->value; struct type *type = value->type (); - LONGEST l = 0; + PyObject *result; try { @@ -1882,17 +1882,46 @@ valpy_long (PyObject *self) && type->code () != TYPE_CODE_PTR) error (_("Cannot convert value to long.")); - l = value_as_long (value); + gdb::array_view contents = value->contents (); +#if PY_VERSION_HEX >= 0x030d0000 + int flags = (type_byte_order (type) == BFD_ENDIAN_BIG + ? Py_ASNATIVEBYTES_BIG_ENDIAN + : Py_ASNATIVEBYTES_LITTLE_ENDIAN); + if (type->is_unsigned ()) + flags |= Py_ASNATIVEBYTES_UNSIGNED_BUFFER; + result = PyLong_FromNativeBytes (contents.data (), contents.size (), + flags); +#else + /* We need this roundabout approach because int.from_bytes + requires "signed" to be a keyword arg. */ + gdbpy_ref<> args + (Py_BuildValue ("(y#s)", contents.data (), + (Py_ssize_t) contents.size (), + (type_byte_order (type) == BFD_ENDIAN_BIG + ? "big" : "little"))); + if (args == nullptr) + return nullptr; + + gdbpy_ref<> kwargs (Py_BuildValue ("{sO}", "signed", + type->is_unsigned () + ? Py_False : Py_True)); + if (kwargs == nullptr) + return nullptr; + + gdbpy_ref<> callable (PyObject_GetAttrString ((PyObject *) &PyLong_Type, + "from_bytes")); + if (callable == nullptr) + return nullptr; + + result = PyObject_Call (callable.get (), args.get (), kwargs.get ()); +#endif } catch (const gdb_exception &except) { return gdbpy_handle_gdb_exception (nullptr, except); } - if (type->is_unsigned ()) - return gdb_py_object_from_ulongest (l).release (); - else - return gdb_py_object_from_longest (l).release (); + return result; } /* Implements conversion to float. */ diff --git a/gdb/testsuite/gdb.python/py-value.exp b/gdb/testsuite/gdb.python/py-value.exp index ab49f2deb92..089bf7563bf 100644 --- a/gdb/testsuite/gdb.python/py-value.exp +++ b/gdb/testsuite/gdb.python/py-value.exp @@ -844,3 +844,15 @@ if {[allow_cplus_tests]} { test_subscript_regression "${binfile}-cxx" "c++" } } + +if {[allow_rust_tests]} { + gdb_test "set lang rust" + + set cst 0x80000000000000000000000000000000 + gdb_test "python print(int(gdb.parse_and_eval('${cst}u128')))" \ + "170141183460469231731687303715884105728" \ + "convert 128 bit unsigned constant to python int" + gdb_test "python print(int(gdb.parse_and_eval('${cst}i128')))" \ + "-170141183460469231731687303715884105728" \ + "convert 128 bit signed constant to python int" +} -- 2.49.0