Re: [PATCH 2/3] gdbsupport: make filtered_iterator work with pointers

Tom Tromey
2025-09-03T02:02:08Z

>> It seems to me that the presence of this constructor means that some
>> existing code could change meaning. It's not really likely but I wonder
>> how we would know.

Simon> Yeah, you're right. For the meaning of a call site to change, that call
Simon> site would need:
...
Simon> I don't know how to know for sure whether this happens.

I thought of one way, which is to remove the template constructor,
recompile, and count the errors. Then, add the two-argument constructor
and do it again. If the second compilation has fewer errors, then
there's some spot that calls the new constructor.

I don't think you should actually do this though, I'm not planning to
either.

Tom