From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yV93H7Qgp2jPpggAWB0awg (envelope-from ) for ; Thu, 21 Aug 2025 09:35:48 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=z87UtZyi; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=SbsCeDsf; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=z87UtZyi; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=SbsCeDsf; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7C0A61E047; Thu, 21 Aug 2025 09:35:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F2C5E1E047 for ; Thu, 21 Aug 2025 09:35:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A99333854816 for ; Thu, 21 Aug 2025 13:35:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A99333854816 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=z87UtZyi; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=SbsCeDsf; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=z87UtZyi; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=SbsCeDsf Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 1C8DC3854816 for ; Thu, 21 Aug 2025 13:31:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1C8DC3854816 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1C8DC3854816 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755783110; cv=none; b=f4Gn5oMpuY4tF3pPEQ70ZNB7+LZCiLV1or9jvDBPl/eI2w0yiV57xSoZ/aM5ACjgd7RSuD2e8mXo5MaDSz9FCa7xcJCgzw+wsBNyKRyMjLou4oHzP8mfdL+cH7edLhjKLC9D0OH//jOZXutuSdvdiQkFNc9Zl1hUihXbUHe7mSs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755783110; c=relaxed/simple; bh=q+OwZfAfKIumdRe8oFHfiBUpTMRBsPo6wGWaOKAe36o=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=n41kpFk057x44UXwdqeU3TPCNDJ15VmkJk15TDl/RstoCo/+i/1MpS446RURsXYvrRI1SpLigbKEtwcBrRdr0rDTIqpSUlEUTM/h1clUc0eIuVGJj0RBdc/5dA86V8UrOLcj3d7qA6XUdIsYpfjuaWzU+QMc/8GkmCPOfqiaRSE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1C8DC3854816 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C37131F846 for ; Thu, 21 Aug 2025 13:31:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1755783075; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AzAdUSJ7s6N2pS9bq3n55R1QEcQrUtHKG2ejcQhjdKI=; b=z87UtZyizPwS0+5nn1UpwDDCnOSYk2KlFvBnJ1bQZKerxd3Ztz05PZBWttzShBQcQUFMSS Y7RZbJH+BOPR3LxRYRjd+swzVrw2UfLVlFMnb+9kLoy9ZZa6KeUcmeXWRMN/DpwhBeSFfd ROVDGbGECy+K8qDpar/S25/Yf/2Of+4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1755783075; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AzAdUSJ7s6N2pS9bq3n55R1QEcQrUtHKG2ejcQhjdKI=; b=SbsCeDsflPZb6S3XohH5lPh3e+4JxSLgKE3gWMYaF+79GtaVd6J6wg5JaCIY4Xs1uOZrDZ jXKjTaocqHgw/9Bg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1755783075; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AzAdUSJ7s6N2pS9bq3n55R1QEcQrUtHKG2ejcQhjdKI=; b=z87UtZyizPwS0+5nn1UpwDDCnOSYk2KlFvBnJ1bQZKerxd3Ztz05PZBWttzShBQcQUFMSS Y7RZbJH+BOPR3LxRYRjd+swzVrw2UfLVlFMnb+9kLoy9ZZa6KeUcmeXWRMN/DpwhBeSFfd ROVDGbGECy+K8qDpar/S25/Yf/2Of+4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1755783075; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AzAdUSJ7s6N2pS9bq3n55R1QEcQrUtHKG2ejcQhjdKI=; b=SbsCeDsflPZb6S3XohH5lPh3e+4JxSLgKE3gWMYaF+79GtaVd6J6wg5JaCIY4Xs1uOZrDZ jXKjTaocqHgw/9Bg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AF28013AB7 for ; Thu, 21 Aug 2025 13:31:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id eJ6NKaMfp2g/bQAAD6G6ig (envelope-from ) for ; Thu, 21 Aug 2025 13:31:15 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH v2 5/5] [gdb/symtab] Turn complaints in create_addrmap_from_gdb_index into warnings Date: Thu, 21 Aug 2025 15:31:14 +0200 Message-ID: <20250821133114.24091-6-tdevries@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250821133114.24091-1-tdevries@suse.de> References: <20250821133114.24091-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_TLS_ALL(0.00)[] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Rather than issuing a complaint, which is off by default, warn when returning false in create_addrmap_from_gdb_index, informing the user that the .gdb_index was ignored, and why. Tested on aarch64-linux. --- gdb/dwarf2/read-gdb-index.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/gdb/dwarf2/read-gdb-index.c b/gdb/dwarf2/read-gdb-index.c index df20b20e081..5e18c21fb93 100644 --- a/gdb/dwarf2/read-gdb-index.c +++ b/gdb/dwarf2/read-gdb-index.c @@ -1441,15 +1441,17 @@ create_addrmap_from_gdb_index (dwarf2_per_objfile *per_objfile, if (!valid_range_p) { - complaint (_(".gdb_index address table has invalid range (%s - %s)"), - hex_string (lo), hex_string (hi)); + warning (_(".gdb_index address table has invalid range (%s - %s)," + " ignoring .gdb_index"), + hex_string (lo), hex_string (hi)); return false; } if (!valid_index_p) { - complaint (_(".gdb_index address table has invalid CU number %u"), - (unsigned) cu_index); + warning (_(".gdb_index address table has invalid CU number %u," + " ignoring .gdb_index"), + (unsigned) cu_index); return false; } @@ -1457,8 +1459,8 @@ create_addrmap_from_gdb_index (dwarf2_per_objfile *per_objfile, = mutable_map.set_empty (lo, hi_m1, index->units[cu_index]); if (!full_range_p) { - complaint (_(".gdb_index address table has a range (%s - %s) that" - " overlaps with an earlier range"), + warning (_(".gdb_index address table has a range (%s - %s) that" + " overlaps with an earlier range, ignoring .gdb_index"), hex_string (lo), hex_string (hi)); return false; } -- 2.43.0