From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qav5DBMgp2jPpggAWB0awg (envelope-from ) for ; Thu, 21 Aug 2025 09:33:07 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=cJtlhZSr; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=W5jMDGt1; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=cJtlhZSr; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=W5jMDGt1; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3026D1E0B3; Thu, 21 Aug 2025 09:33:07 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AE8781E047 for ; Thu, 21 Aug 2025 09:33:06 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 46EC33854816 for ; Thu, 21 Aug 2025 13:33:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 46EC33854816 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=cJtlhZSr; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=W5jMDGt1; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=cJtlhZSr; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=W5jMDGt1 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id EA464385DC1C for ; Thu, 21 Aug 2025 13:31:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EA464385DC1C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EA464385DC1C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755783085; cv=none; b=swar48sd91idpb3TrljJVb24WdhgZDgkT2SNKt9ECc2E+q44MMOMHywheh/hUBxCY1eoctetbWrlnk/bJfpfP6fimQXHqgN0nhdn3f1hW9PsnlPNyZedJmMT4/sZ/bCtIOYto4fxHUZryp+s0RN8tS/e5Ty4kS9tadE9JHmJTw8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755783085; c=relaxed/simple; bh=GU1Wz1Xv/mFX7+7EaewOCTtF059pgQxFNIoQMeT7yBE=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=Rke/36ob1vx891ncjsRusk+ykd5yP+ni7xVG3zOFDlOwZm2Pz+N92X/YSGQUlTNTb0rwl4lM4vHW2eK9WjWnDfJtvXBP6KRGRPaWBbLn2MUU8Pf3bZE685axyLolLgVVVGX33isIyzWybe8ouQvi9H01hrknSrjHWk9eETgtcLQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EA464385DC1C Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A87F622002 for ; Thu, 21 Aug 2025 13:31:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1755783075; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fTu7k56d6cuaSX7411rsNhfU36vDE0URe04w8zR88K4=; b=cJtlhZSrDdKK3SQSmn/fHXgHhP+bVFWPEOBH1ufCdBMKBnlrvK/kP/fVWU1a+p5q4O2h9B mXtC5XzKmvF1Wl6zsbe9xVY2oqSNzPLsVCG2opiVhlc/BAMaLiYQzBTPwenqocFFI8c6P5 /eOhSJVVHc6KNPJGBovQFWVfj3Wuwu4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1755783075; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fTu7k56d6cuaSX7411rsNhfU36vDE0URe04w8zR88K4=; b=W5jMDGt1itG8ckdtuLyx2/5qniA4GnWpLzYNEfH+9+SNWJcN4NChMFYU9slZALeTqmdyP+ sWrqCAppVz7dJ4Aw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=cJtlhZSr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=W5jMDGt1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1755783075; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fTu7k56d6cuaSX7411rsNhfU36vDE0URe04w8zR88K4=; b=cJtlhZSrDdKK3SQSmn/fHXgHhP+bVFWPEOBH1ufCdBMKBnlrvK/kP/fVWU1a+p5q4O2h9B mXtC5XzKmvF1Wl6zsbe9xVY2oqSNzPLsVCG2opiVhlc/BAMaLiYQzBTPwenqocFFI8c6P5 /eOhSJVVHc6KNPJGBovQFWVfj3Wuwu4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1755783075; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fTu7k56d6cuaSX7411rsNhfU36vDE0URe04w8zR88K4=; b=W5jMDGt1itG8ckdtuLyx2/5qniA4GnWpLzYNEfH+9+SNWJcN4NChMFYU9slZALeTqmdyP+ sWrqCAppVz7dJ4Aw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 94557139A8 for ; Thu, 21 Aug 2025 13:31:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id AN4DI6Mfp2g/bQAAD6G6ig (envelope-from ) for ; Thu, 21 Aug 2025 13:31:15 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH v2 4/5] [gdb/symtab] Improve invalid range check in create_addrmap_from_gdb_index Date: Thu, 21 Aug 2025 15:31:13 +0200 Message-ID: <20250821133114.24091-5-tdevries@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250821133114.24091-1-tdevries@suse.de> References: <20250821133114.24091-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: A87F622002 X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCPT_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org When running test-case gdb.tui/tui-missing-src.exp with target board gold-gdb-index (and likewise fission and fission-dwp) on aarch64-linux, I run into: ... FAIL: gdb.tui/tui-missing-src.exp: checking if inside f2 () ... Looking at the gold-gdb-index case, the problem is caused by the address table of the .gdb_index section: ... Address table: 000000000040066c 0000000000400694 0 000000000040053f 0000000000400563 1 ... The address range for f2 is [0x400694, 0x4006b8), but the address table says it's [0x40053f, 0x400563). The address 0x40053f is not even in a section: ... [Nr] Name Type Address Off Size ES Flg Lk Inf Al ... [12] .plt PROGBITS 00000000004004b8 0004b8 000050 10 AX 0 0 8 [13] .text PROGBITS 0000000000400540 000540 000178 00 AX 0 0 64 ... but part of the hole [0x400508, 0x400540) in between .plt and .text. Detect this in the invalid range check in create_addrmap_from_gdb_index. Tested on aarch64-linux. --- gdb/dwarf2/read-gdb-index.c | 25 ++++++++++++++++++++++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/gdb/dwarf2/read-gdb-index.c b/gdb/dwarf2/read-gdb-index.c index 79d19a3abaa..df20b20e081 100644 --- a/gdb/dwarf2/read-gdb-index.c +++ b/gdb/dwarf2/read-gdb-index.c @@ -1420,14 +1420,33 @@ create_addrmap_from_gdb_index (dwarf2_per_objfile *per_objfile, cu_index = extract_unsigned_integer (iter, 4, BFD_ENDIAN_LITTLE); iter += 4; - if (lo >= hi) + bool valid_range_p = lo < hi; + bool valid_index_p = cu_index < index->units.size (); + + /* Variable hi is the exclusive upper bound, get the inclusive one. */ + CORE_ADDR hi_m1 = (valid_range_p + ? hi - 1 + : 0); + + if (valid_range_p) + { + CORE_ADDR relocated_lo + = per_objfile->relocate (unrelocated_addr (lo)); + CORE_ADDR relocated_hi_m1 + = per_objfile->relocate (unrelocated_addr (hi_m1)); + struct obj_section *lo_sect = find_pc_section (relocated_lo); + struct obj_section *hi_sect = find_pc_section (relocated_hi_m1); + valid_range_p = lo_sect != nullptr && hi_sect != nullptr; + } + + if (!valid_range_p) { complaint (_(".gdb_index address table has invalid range (%s - %s)"), hex_string (lo), hex_string (hi)); return false; } - if (cu_index >= index->units.size ()) + if (!valid_index_p) { complaint (_(".gdb_index address table has invalid CU number %u"), (unsigned) cu_index); @@ -1435,7 +1454,7 @@ create_addrmap_from_gdb_index (dwarf2_per_objfile *per_objfile, } bool full_range_p - = mutable_map.set_empty (lo, hi - 1, index->units[cu_index]); + = mutable_map.set_empty (lo, hi_m1, index->units[cu_index]); if (!full_range_p) { complaint (_(".gdb_index address table has a range (%s - %s) that" -- 2.43.0