From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cZRkGVcgp2jPpggAWB0awg (envelope-from ) for ; Thu, 21 Aug 2025 09:34:15 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=uzD+R3EN; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=4G+EZsyO; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=uzD+R3EN; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=4G+EZsyO; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 644D21E0B3; Thu, 21 Aug 2025 09:34:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EC2881E047 for ; Thu, 21 Aug 2025 09:34:14 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 986A5385DC1C for ; Thu, 21 Aug 2025 13:34:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 986A5385DC1C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=uzD+R3EN; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=4G+EZsyO; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=uzD+R3EN; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=4G+EZsyO Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 2551E385DC21 for ; Thu, 21 Aug 2025 13:31:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2551E385DC21 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2551E385DC21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755783098; cv=none; b=Bs8OPFttjIvSR647ELP1WKHPNBRxsQdIga4iQgLNZzZrYbsoLuYwJmpuS7iGNoavOR/uHM9d8XpkSAMRZVDMKtYANUgAYbqPdiwzxVe/KSuwhBYUTZzYSYedZR2GzlEZpqoNneyCo0N/nSIo8juZs+2SbehPCp7GosQEuGWqcLE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755783098; c=relaxed/simple; bh=9usOrMmlKLx0qBRZ83jwi+H7HSvMUoiSDfNiqqMzR4o=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=aU+T29jQbd5yFCgF96KFiYjFO+VGY2vy3lf1VqzhRkddyNvSnsDiumUAjymAjx8ZvuqfCFxePMKjItNJzrwGt71/7+sFxQ+ApebwgXNzAv9xpZAWNI1U3GUnNbadKxlIuuJ0jmw994ukt0VGA9Umo03CPmE8Wi2Db1FaX/2PNns= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2551E385DC21 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 916241F83B for ; Thu, 21 Aug 2025 13:31:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1755783075; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TRvNnGpoA+E9Ehqswss2wkbYnvfqS0KUN1PGsSl1cms=; b=uzD+R3ENOBe/NKy6mYslC7lx/A86JR3XJEYut1H5uEUt+UqQnjsDbNU3BK3L+2TNE/3x/E qDkxenagbNJ7pcxWg+VPZFohA5QzqRwaSMK/ne4/KKH4lXILW3Y1KS770oZ2KpPgDJNtvA uHPLGyX3deK57lvkRdCUBF7jcdMuUFU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1755783075; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TRvNnGpoA+E9Ehqswss2wkbYnvfqS0KUN1PGsSl1cms=; b=4G+EZsyO8wwL4JCYJ5/C/dA9Hey4+6D9yI4kUFvtnw6KftVWknqp1sLDII9M09v3P7DfyG C5YiAZwK0ynaIgBQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=uzD+R3EN; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4G+EZsyO DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1755783075; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TRvNnGpoA+E9Ehqswss2wkbYnvfqS0KUN1PGsSl1cms=; b=uzD+R3ENOBe/NKy6mYslC7lx/A86JR3XJEYut1H5uEUt+UqQnjsDbNU3BK3L+2TNE/3x/E qDkxenagbNJ7pcxWg+VPZFohA5QzqRwaSMK/ne4/KKH4lXILW3Y1KS770oZ2KpPgDJNtvA uHPLGyX3deK57lvkRdCUBF7jcdMuUFU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1755783075; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TRvNnGpoA+E9Ehqswss2wkbYnvfqS0KUN1PGsSl1cms=; b=4G+EZsyO8wwL4JCYJ5/C/dA9Hey4+6D9yI4kUFvtnw6KftVWknqp1sLDII9M09v3P7DfyG C5YiAZwK0ynaIgBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7AC4F13ABE for ; Thu, 21 Aug 2025 13:31:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id oHu9HKMfp2g/bQAAD6G6ig (envelope-from ) for ; Thu, 21 Aug 2025 13:31:15 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH v2 3/5] [gdb/symtab] Detect overlapping ranges in create_addrmap_from_gdb_index Date: Thu, 21 Aug 2025 15:31:12 +0200 Message-ID: <20250821133114.24091-4-tdevries@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250821133114.24091-1-tdevries@suse.de> References: <20250821133114.24091-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCPT_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_HAS_DN(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_TLS_ALL(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: 916241F83B X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org In create_addrmap_from_gdb_index, use the return value of addrmap_mutable::insert_empty to detect overlapping ranges. Tested on x86_64-linux. --- gdb/dwarf2/read-gdb-index.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gdb/dwarf2/read-gdb-index.c b/gdb/dwarf2/read-gdb-index.c index 7db2834f4d3..79d19a3abaa 100644 --- a/gdb/dwarf2/read-gdb-index.c +++ b/gdb/dwarf2/read-gdb-index.c @@ -1434,7 +1434,15 @@ create_addrmap_from_gdb_index (dwarf2_per_objfile *per_objfile, return false; } - mutable_map.set_empty (lo, hi - 1, index->units[cu_index]); + bool full_range_p + = mutable_map.set_empty (lo, hi - 1, index->units[cu_index]); + if (!full_range_p) + { + complaint (_(".gdb_index address table has a range (%s - %s) that" + " overlaps with an earlier range"), + hex_string (lo), hex_string (hi)); + return false; + } } index->index_addrmap -- 2.43.0