From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ydByNS0gp2jPpggAWB0awg (envelope-from ) for ; Thu, 21 Aug 2025 09:33:33 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=N3Z0DzVz; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=bL23Y04p; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=N3Z0DzVz; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=bL23Y04p; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D3AA21E0B3; Thu, 21 Aug 2025 09:33:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B0BDF1E047 for ; Thu, 21 Aug 2025 09:33:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4E7B7385DC3E for ; Thu, 21 Aug 2025 13:33:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4E7B7385DC3E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=N3Z0DzVz; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=bL23Y04p; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=N3Z0DzVz; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=bL23Y04p Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 380CE385C6EE for ; Thu, 21 Aug 2025 13:31:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 380CE385C6EE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 380CE385C6EE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755783076; cv=none; b=NNIQ38STJV65stgrR/kwHZdfvrnCshz6q5PG11WGycC75httnZEkxYcK4T0OGyCVN7c3SqDNp/vmoxh++hGyoXDI3Q99mK3Bk3vjPRxTxf7aXpAPB10comJelZzGjasGajY21F0CraXUVJLM13YmHy3S1EEhjqyiOw5PG/QHAXc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755783076; c=relaxed/simple; bh=P5AIKsW22kqmtXtAmeBBN3XGI26mBOwaH2u8tL7tgeQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=G+QHeK1183Y1RF+2c3ffFKwPh5F7nmZ5u9L7d9Tuv8tSH8FnNpCgSXTmUIsc5rIF3pNIYgB92eHAyVrGLidTQGWuDOKnHLq9K3sLaLnZeO1R4ADHVur4gKu4cAMZaFbsiso9+2b/+FbG4sY6V0Wdc4Dr7NvOzN4o/lw5nQEq2l0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 380CE385C6EE Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AF9981F836 for ; Thu, 21 Aug 2025 13:31:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1755783074; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=S4BqfEKWTw5OigEMQ/9Tz8ProvriyBlFr3tMZTgTwpI=; b=N3Z0DzVzyy3Q1hxsmSulngZDJxwRUQaptDm5IDBKP5p2AjyfrWlLXUSkXyqvtZWMiNiIzl lWjcRUf9LCtjNcB+CeUUHA47yCt/4JMGAYKpdKyEY8AERNGDaWHkNCi0SMTo6Eb+iXMaYj fkkSkZcIOBRprMZ9OWcDMvnZFgYeVyE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1755783074; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=S4BqfEKWTw5OigEMQ/9Tz8ProvriyBlFr3tMZTgTwpI=; b=bL23Y04pzzzmP5489lY7iftu1a6gE242OWyIDjqPl+QPS3yzXFh/rYDXvMVjbajiPP7DdA Y5IPAV3HkzrD+hCQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=N3Z0DzVz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=bL23Y04p DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1755783074; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=S4BqfEKWTw5OigEMQ/9Tz8ProvriyBlFr3tMZTgTwpI=; b=N3Z0DzVzyy3Q1hxsmSulngZDJxwRUQaptDm5IDBKP5p2AjyfrWlLXUSkXyqvtZWMiNiIzl lWjcRUf9LCtjNcB+CeUUHA47yCt/4JMGAYKpdKyEY8AERNGDaWHkNCi0SMTo6Eb+iXMaYj fkkSkZcIOBRprMZ9OWcDMvnZFgYeVyE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1755783074; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=S4BqfEKWTw5OigEMQ/9Tz8ProvriyBlFr3tMZTgTwpI=; b=bL23Y04pzzzmP5489lY7iftu1a6gE242OWyIDjqPl+QPS3yzXFh/rYDXvMVjbajiPP7DdA Y5IPAV3HkzrD+hCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9715F139A8 for ; Thu, 21 Aug 2025 13:31:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id KqScIqIfp2g/bQAAD6G6ig (envelope-from ) for ; Thu, 21 Aug 2025 13:31:14 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH v2 0/5] [gdb/symtab] Handle invalid .gdb_index better Date: Thu, 21 Aug 2025 15:31:09 +0200 Message-ID: <20250821133114.24091-1-tdevries@suse.de> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: AF9981F836 X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I ran into a failure with test-case gdb.tui/tui-missing-src.exp and target board gold-gdb-index on aarch64-linux. Investigation showed that this was due to an incorrect address table entry in the .gdb_index section, with the start of the entry positioned in a hole between two sections. The fourth patch detects such entries. The third patch detects overlapping entries, and the second patch adds some infrastructure for that patch. The first patch rejects any .gdb_index with an incorrect adress table. The last patch changes the related complaints into warnings, making sure that rejecting the .gdb_index is reported to the user. The first and fourth patch fix aforementioned test-case. A v1 was submitted here [1]. New in v2: - moved the approved patch to be the first patch - added approved-by tag in first patch - rewrite commit messages to not refer to other patches, to better allow committing patches independently - add two patches for detecting overlapping entries - add missing function comment update for create_addrmap_from_gdb_index - fixed fourth patch to use relocated addresses, after review comment by Simon [1] https://sourceware.org/pipermail/gdb-patches/2025-August/220087.html Tom de Vries (5): [gdb/symtab] Bail out of create_addrmap_from_gdb_index on error [gdb] Make addrmap_mutable::insert_empty return bool [gdb/symtab] Detect overlapping ranges in create_addrmap_from_gdb_index [gdb/symtab] Improve invalid range check in create_addrmap_from_gdb_index [gdb/symtab] Turn complaints in create_addrmap_from_gdb_index into warnings gdb/addrmap.c | 23 +++++++++++---- gdb/addrmap.h | 4 +-- gdb/dwarf2/read-gdb-index.c | 57 +++++++++++++++++++++++++++++-------- 3 files changed, 65 insertions(+), 19 deletions(-) base-commit: 8186f0d31ddf339ba6803cde97ef6a6310ca2587 -- 2.43.0