From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qeLoIRHHoGiq/QQAWB0awg (envelope-from ) for ; Sat, 16 Aug 2025 13:59:45 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=etWe0z4r; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7A8031E047; Sat, 16 Aug 2025 13:59:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DADCB1E047 for ; Sat, 16 Aug 2025 13:59:44 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6022E3858C54 for ; Sat, 16 Aug 2025 17:59:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6022E3858C54 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=etWe0z4r Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id EB3253858D20 for ; Sat, 16 Aug 2025 17:59:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EB3253858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EB3253858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755367155; cv=none; b=i88B1zAN1ami48qCyrwPFZ2s4k1du/dHJm8HsM3z7GJJ4yZUEExDGhdQxkfiVV+vgIzUF/jM8MEvh6JCv6x+fVwotPBdZlU7kfXaWFSvFFOF6yM0Qf1eeYJ8ZqD9KnXuLsbCfHmzGABl4iPKwGKatWBOZPtVBeyzIzEorCiQUI0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755367155; c=relaxed/simple; bh=UcKdO9uiEENnai0VFLyZcQ/KZ5rjcfkiC+6FuzCy+lk=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=ffSoyf6ddlZpSH+BnoUa5cSr4z49eK8asBgXK+uernFLBQfkRuDvEbyz643h21bh3hFYTPvyuJ7RnB5wOPJwvaE9FACitXQ2NZwkpdVAIp/GvEIVOp3TqciknXsqcR4Or6HOvZDRQzfaQ41ex4V8ROd36LDncpBsisWP100cmrk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EB3253858D20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755367154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Be28Vy6VqDwB4Qp1QOlht/fa7LJ8JRzEIeVMt6EiSv0=; b=etWe0z4rno6CvZMHL/qZkxIHxYe0msfOurcpelR4AkR4RZzkdEH5UPPcXKhW94ojYXDeN5 Bo/6iBlGCrlgQd7IHoAGF4ijlSiMczOqTDLsQjGDlW/G485T/99vkBKO8aRHh1ei/QKRj+ vL2LurSSzLRhtX0tuqDo/2jtWjtKL50= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-LIdzVE7pNTGGTXBhA2EEAA-1; Sat, 16 Aug 2025 13:59:12 -0400 X-MC-Unique: LIdzVE7pNTGGTXBhA2EEAA-1 X-Mimecast-MFC-AGG-ID: LIdzVE7pNTGGTXBhA2EEAA_1755367152 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D50FD195605A; Sat, 16 Aug 2025 17:59:11 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.88.17]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1676819560AD; Sat, 16 Aug 2025 17:59:09 +0000 (UTC) Date: Sat, 16 Aug 2025 10:59:05 -0700 From: Kevin Buettner To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Automatically handle includes in testsuite/lib/ Message-ID: <20250816105721.5f0d5da8@f41-zbm-amd> In-Reply-To: <20250813004100.2525141-1-pedro@palves.net> References: <20250813004100.2525141-1-pedro@palves.net> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zihao9Wc4-H0tnS-HSuhR8vV5ne6tLaEBx2TeUqiERo_1755367152 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Wed, 13 Aug 2025 01:41:00 +0100 Pedro Alves wrote: > Instead of manually calling lappend_include_file in every testcase > that needs to include a file in testsuite/lib/, handle testsuite/lib/ > includes automatically in gdb_compile. > > As an example, gdb.base/backtrace.exp is adjusted to no longer > explicitly call lappend_include_file for testsuite/lib/attributes.h. > > Tested on x86-64 GNU/Linux with both: > > $ make check RUNTESTFLAGS=" \ > --host_board=local-remote-host-native \ > --target_board=local-remote-host-native \ > HOST_DIR=/tmp/foo/" \ > TESTS="gdb.base/backtrace.exp" > > and: > > $ make check TESTS="gdb.base/backtrace.exp" > > and confirming that the testcase still compiles and passes cleanly. > > Also ran full testsuite on x86-64 GNU/Linux in normal mode. > > Change-Id: I5ca77426ea4a753a995c3ad125618c02cd952576 > --- > gdb/testsuite/gdb.base/backtrace.exp | 6 +-- > gdb/testsuite/lib/gdb.exp | 63 ++++++++++++++++++++++++++++ > 2 files changed, 64 insertions(+), 5 deletions(-) LGTM. Approved-by: Kevin Buettner