From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GX/xK3f2n2gXlwQAWB0awg (envelope-from ) for ; Fri, 15 Aug 2025 23:09:43 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LXfCgRFx; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B084F1E0B3; Fri, 15 Aug 2025 23:09:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 62A4D1E08D for ; Fri, 15 Aug 2025 23:09:43 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0935B3858C42 for ; Sat, 16 Aug 2025 03:09:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0935B3858C42 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LXfCgRFx Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 525913858D1E for ; Sat, 16 Aug 2025 03:09:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 525913858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 525913858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755313755; cv=none; b=vv8wl6itf3g2lSt5el/LlOOxcr9cM5hfu8Z0cPoV1Tz27zuu/uPyS4XBg4t1QnZLSokAi345m2ig1t+nTqQAUYAHJEfq6yeHlJkrDmyqGzsgoh95TSjPlY9qSwLxokKdVIi2Nw1aCvVh5gh5Z8TZgsXM00jdtPqjCucfk1KYdM4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755313755; c=relaxed/simple; bh=MUbclg/UUBEVb2D5EHkL29xHW4WtV+F2jyHHX8ir/us=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=gyZi/1cIwxAb97+SZz0VfYgyZBtaGTsSZsrsSFuLBp2J7TmUuDzPM3nNRYtcCkn0XQRNyvY1BzjsQ3DsOyVJLe5AuIZBEcooZ3cJNmAKHj15YjJrT8o2WsV/Hdi8ULV7FFxZM14z5cglmev2aGlRSVihib+3d21dn9Gnca3NakM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 525913858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755313755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7vbf6y7lKLHvBWgKSQS86uOVRR/9XCudFuAI5e4OEOs=; b=LXfCgRFxw3MGRcXXXb/IPEiOnGJSYO8zduv5SrFVTnYHTywKr7+Xp9ldqhOhXLY0H1zES+ 2VUxu+AbOBxKh067cb2QAT/JjbztsBGJfmP/ujBB6nNzD7EaGwmz9yvbSqP3IgQOmDw/X0 PZFsGW6yzuAxzGLc+Xqfu1b004VPvQA= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-501-ohNy-fV5O0m9sY8KlrYg6g-1; Fri, 15 Aug 2025 23:09:13 -0400 X-MC-Unique: ohNy-fV5O0m9sY8KlrYg6g-1 X-Mimecast-MFC-AGG-ID: ohNy-fV5O0m9sY8KlrYg6g_1755313752 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0BB2A180047F; Sat, 16 Aug 2025 03:09:12 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.88.20]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C36DD1800295; Sat, 16 Aug 2025 03:09:10 +0000 (UTC) Date: Fri, 15 Aug 2025 20:09:08 -0700 From: Kevin Buettner To: Simon Marchi Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH] gdb: rename gdbarch_software_single_step -> gdbarch_get_next_pcs Message-ID: <20250815200908.131101fa@f41-zbm-amd> In-Reply-To: <20250814201418.164267-1-simon.marchi@efficios.com> References: <20250814201418.164267-1-simon.marchi@efficios.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: p_UphHUdwCOD-aTEiAScNCakWPvVjzY_d-zmgvulEp4_1755313752 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Thu, 14 Aug 2025 16:14:17 -0400 Simon Marchi wrote: > From: Simon Marchi > To: gdb-patches@sourceware.org > Cc: Simon Marchi > Subject: [PATCH] gdb: rename gdbarch_software_single_step -> > gdbarch_get_next_pcs Date: Thu, 14 Aug 2025 16:14:17 -0400 > > From: Simon Marchi > > I spotted this while reviewing a patch adding a new > gdbarch_software_single_step implementation. I find the name > "software_single_step" a bit misleading or unclear. It makes it sounds > as if the function executed a single step. In reality, this function > returns the possible next PCs for current instructions. > > We have a similar concept in GDBserver: > linux_process_target::low_get_next_pcs. I like that name, it's clear > and straight to the point. > > Rename gdbarch_software_single_step to gdbarch_get_next_pcs. I find > this name more indicative of what happens. > > There is some code for ARM shared between GDB and GDBserver to implement > both sides, also called "get next pcs", so I think it all fits well > together. > > Tested by rebuilding. This one makes sense to me too. Approved-by: Kevin Buettner