From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8yfWAENVk2haNAUAWB0awg (envelope-from ) for ; Wed, 06 Aug 2025 09:14:43 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=O7qRce6e; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E9B111E100; Wed, 6 Aug 2025 09:14:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 915471E089 for ; Wed, 6 Aug 2025 09:14:41 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 911753858D29 for ; Wed, 6 Aug 2025 13:14:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 911753858D29 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=O7qRce6e Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by sourceware.org (Postfix) with ESMTPS id CA6073858D26 for ; Wed, 6 Aug 2025 13:13:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CA6073858D26 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CA6073858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d29 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1754486017; cv=none; b=ht3zliK9C9HIUn8/BZ4OxaUZBOllWnobaRFpuW3xJegvZxvAjF5HOLKH4SRLbCf1ZH0mjAYNeoXMt3eaeAhRVOGf0fbpTgp13gkPWLhakbdyhU6MWGJfqdE5DXGcHvGm1x4Dy2TBPOpHPbUWHt/ut8WEnts5lAzAnm7dOi7V1xw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1754486017; c=relaxed/simple; bh=lvt7RvQypNqF9YTcOi5TF1+AvTouycVGBwWf+yYt0BM=; h=DKIM-Signature:From:Subject:Date:Message-Id:MIME-Version:To; b=b18EFlXkXXnOFTENunt9YN3UBBpJ5U8XcOuIiUufo322jm7xepP+OlAgas1FhMc6p6zf160FIBo54sIpeZgNNwOfXiSAmkBCBfS+u7xqTxVmuxtonpeA9kY9jytn6LHJQFVaKPPYxEqr/W35s7MpqOIeCYjPcoUI7FGv8d54ueA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CA6073858D26 Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-88182bb2336so79274239f.3 for ; Wed, 06 Aug 2025 06:13:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1754486015; x=1755090815; darn=sourceware.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=fE6VdEPO0p6gRy8CsfsLUIhQ5EClQPRam24TQzZDPZQ=; b=O7qRce6eIWkLStr3SANKToxYOxtuLdx0wKtbETVi0zq8jbfoUUWQCjfTehEgppjqyy 8hMPAoclzTS/JFle3/EJWKjXO3a/ZCffzXZM2ft+hyYnQhSTzzdOc5bC3hblZ+rueLgk 9gfBTm9H/gZ73BKfDIvF9NSeerstgbqsi27BqukCIbUsE73IpPICavMP5IqdrOOzq1fT un/z95+Vwo9TD6cD7q2NdiYo8aBGhZvfxQkb+4PKghVrVPAFc0z4BBcrqTs71THws9QE bIMtMAuTvdAUoegac8JHwju+q6A2Dzinxv0QWL0n3CHmCjY4KBsKFG7uDnhTzZwyu0/M 71MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754486015; x=1755090815; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fE6VdEPO0p6gRy8CsfsLUIhQ5EClQPRam24TQzZDPZQ=; b=HvgsfXh2i6KUOZDYlpFasiy0vlM+AC+7sXP0x8RcpZi/kz1Ip4pGU7/lW8T8OchnYg fUI6L2CsitnzS/d/PS4yHztkCipHuEieC/bJHUdze3OAX2JtJZoKv128GmuFNIFY5yCY 8j/IJPBIDGaoRXyGuD3lzuqfBmA47DCh567Iglg0GzUQcXbhlY0najEwcU0l8jkNmeFv /xEX8DOlwBINawZ5IP1lUIP73D9uXOT2NXJP15/QoYffkOWb4X6SCpMqGgCtL5DqmtL4 ptMbm2pHvwGmtkVFYQsPmgO5MuJGwVQvmUsuSYWvqLThNGOMefXGThp3eqynOVrEuewY EC9g== X-Gm-Message-State: AOJu0YyC28Icv1JiorX45hi78SgBqatPVX1UMSO6tYeSbO2iw84rsarB KvEphrvrlEcxvNv53qFbRbXoDvNhOUabcSvxrYqqYRWbcJmKffXjaUp9uDmPEPZFimQoa1Apb2z 37YOg5Q== X-Gm-Gg: ASbGncuvd1LYNaksOZLqS9wSjQPdbH+EiYSO7VpfPgsvdJqgdamxQ/DLSAFORkfY+cL jAZif4fS8v5hjIynMM4IKJEEr76CyMuEvGtw2jGpxoNdNN/wRj0ZUa9T3ufqR6Fr8W29/HXv9j7 KYKi0FnOOrI130rUW6JNujjJX/UocD2aqgE1X/zGoYKNBfYIXHTmdFbPMGf4rC2SeCFoCd4m61u CZAqaKA6v4ZK7+lSPWRWTY4gxhjPzgoFEU1MZNrdudz9rUHaJDS/Sc5fBAk+G1wBBwpuueZynvI QJ+gchMqP9CmdHP7n3v5tNLw5nYZnfrW9njqGycuUJkMKIlDZqLIyW9cy2hsW4f4u0wij/cq1kp 1V52+n3Kz4CiGTYdEauDeHsp8dqYVw2SgAEntb9tV09hMCsKSJY68//6NoYuGG9s= X-Google-Smtp-Source: AGHT+IEUUPEuIrWPVkDY9ddI7GbRvwPGK1scJphFCh22IuK3So389OeO4Md0oRi5tnLycfACjKkOzQ== X-Received: by 2002:a05:6602:2b0f:b0:864:4b3a:9e3a with SMTP id ca18e2360f4ac-8819f4cad00mr548149739f.13.1754486015469; Wed, 06 Aug 2025 06:13:35 -0700 (PDT) Received: from [192.168.0.26] (97-122-110-68.hlrn.qwest.net. [97.122.110.68]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-8818b151319sm181295339f.0.2025.08.06.06.13.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Aug 2025 06:13:34 -0700 (PDT) From: Tom Tromey Subject: [PATCH 0/3] Use gnulib c-ctype module, not Date: Wed, 06 Aug 2025 07:13:31 -0600 Message-Id: <20250806-gnulib-c-ctype-v1-0-10f33e9f22a4@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAPxUk2gC/x3MwQrCMAyA4VcZORvsBpXiq4iHpmZdQLORTFHG3 t3q8Tv8/wbOJuxw7jYwfonLrA39oYMyZa2McmuGIQwxpBCx6vMuhAXL+lkYe0ojpZRPJTK0aDE e5f0fXq7NlJ2RLGuZfpvZpIoeH9lXNtj3L5Ny+qWAAAAA X-Change-ID: 20250805-gnulib-c-ctype-1b8fb88a6c5e To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.2 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This series changes gdb to use the gnulib c-ctype module rather than or "safe-ctype.h". The rationale is mostly in patch #3. I do wonder if it would be better to just add the casts everywhere. Regression tested on x86-64 Fedora 41. This doesn't cover solib-rocm.c though. Signed-off-by: Tom Tromey --- Tom Tromey (3): Import the c-ctype module from gnulib Use c-ctype.h (not safe-ctype.h) in gdb Use gnulib c-ctype module in gdb gdb/aarch64-linux-tdep.c | 9 +- gdb/ada-exp.y | 5 +- gdb/ada-lang.c | 87 ++++---- gdb/ada-lex.l | 23 +-- gdb/ada-typeprint.c | 3 +- gdb/ada-valprint.c | 5 +- gdb/arm-linux-tdep.c | 9 +- gdb/arm-tdep.c | 1 - gdb/auto-load.c | 3 +- gdb/break-catch-exec.c | 4 +- gdb/break-catch-fork.c | 2 +- gdb/break-catch-syscall.c | 3 +- gdb/break-catch-throw.c | 3 +- gdb/break-cond-parse.c | 4 +- gdb/breakpoint.c | 7 +- gdb/btrace.c | 5 +- gdb/c-exp.y | 19 +- gdb/c-lang.c | 11 +- gdb/c-support.h | 10 +- gdb/charset.c | 1 - gdb/cli/cli-cmds.c | 16 +- gdb/cli/cli-decode.c | 9 +- gdb/cli/cli-dump.c | 1 - gdb/cli/cli-option.c | 4 +- gdb/cli/cli-script.c | 7 +- gdb/cli/cli-setshow.c | 3 +- gdb/cli/cli-utils.c | 27 ++- gdb/coff-pe-read.c | 3 +- gdb/coffread.c | 7 +- gdb/completer.c | 2 +- gdb/cp-name-parser.y | 11 +- gdb/cp-support.c | 9 +- gdb/d-exp.y | 22 +- gdb/darwin-nat.c | 1 - gdb/dictionary.c | 4 +- gdb/disasm.c | 1 - gdb/dwarf2/cooked-index-entry.c | 3 +- gdb/dwarf2/index-common.c | 10 +- gdb/dwarf2/read.c | 4 +- gdb/eval.c | 1 - gdb/exec.c | 3 +- gdb/expprint.c | 1 - gdb/f-exp.y | 5 +- gdb/fbsd-nat.c | 2 +- gdb/findcmd.c | 7 +- gdb/gdb_wchar.h | 4 +- gdb/gnu-nat.c | 3 +- gdb/gnu-v2-abi.c | 3 +- gdb/go-exp.y | 9 +- gdb/go-lang.c | 3 +- gdb/go32-nat.c | 1 - gdb/guile/scm-cmd.c | 1 - gdb/i386-tdep.c | 25 ++- gdb/ia64-linux-tdep.c | 5 +- gdb/infcmd.c | 7 +- gdb/infrun.c | 3 +- gdb/language.c | 1 - gdb/linespec.c | 19 +- gdb/linux-fork.c | 3 +- gdb/linux-nat.c | 1 - gdb/linux-tdep.c | 17 +- gdb/linux-thread-db.c | 1 - gdb/location.c | 17 +- gdb/main.c | 3 +- gdb/maint.c | 5 +- gdb/mi/mi-cmd-break.c | 3 +- gdb/mi/mi-cmd-stack.c | 2 - gdb/mi/mi-cmd-var.c | 3 +- gdb/mi/mi-main.c | 1 - gdb/mi/mi-parse.c | 11 +- gdb/minsyms.c | 2 - gdb/minsyms.h | 2 +- gdb/nat/linux-osdata.c | 15 +- gdb/netbsd-nat.c | 2 +- gdb/objc-lang.c | 13 +- gdb/or1k-tdep.c | 1 - gdb/p-exp.y | 17 +- gdb/p-lang.c | 1 - gdb/p-typeprint.c | 5 +- gdb/parse.c | 1 - gdb/ppc-linux-tdep.c | 13 +- gdb/printcmd.c | 1 - gdb/probe.c | 3 +- gdb/procfs.c | 5 +- gdb/producer.c | 4 +- gdb/python/py-mi.c | 6 +- gdb/python/py-micmd.c | 4 +- gdb/python/py-objfile.c | 2 +- gdb/python/python.c | 1 - gdb/record.c | 9 +- gdb/remote-sim.c | 1 - gdb/remote.c | 7 +- gdb/riscv-tdep.c | 5 +- gdb/rust-lang.c | 3 +- gdb/s12z-tdep.c | 2 +- gdb/s390-tdep.c | 4 +- gdb/serial.c | 3 +- gdb/solib-rocm.c | 6 +- gdb/stabsread.c | 7 +- gdb/stack.c | 4 +- gdb/stap-probe.c | 23 +-- gdb/symfile.c | 3 +- gdb/symtab.c | 17 +- gdb/thread.c | 5 +- gdb/tid-parse.c | 7 +- gdb/top.c | 1 - gdb/tracectf.c | 1 - gdb/tracepoint.c | 6 +- gdb/tui/tui-layout.c | 7 +- gdb/tui/tui-win.c | 3 +- gdb/tui/tui-winsource.c | 3 +- gdb/typeprint.c | 5 +- gdb/unittests/command-def-selftests.c | 4 +- gdb/utils.c | 47 ++--- gdb/valprint.c | 1 - gdb/value.c | 5 +- gdb/windows-nat.c | 6 +- gdb/xcoffread.c | 1 - gdb/xml-support.c | 5 +- gdbserver/gdbreplay.cc | 1 - gdbserver/linux-low.cc | 3 +- gdbserver/remote-utils.cc | 7 +- gdbserver/server.cc | 9 +- gdbserver/thread-db.cc | 3 +- gdbserver/tracepoint.cc | 3 +- gdbsupport/common-defs.h | 6 + gdbsupport/common-utils.cc | 21 +- gdbsupport/gdb-safe-ctype.h | 49 ----- gdbsupport/pathstuff.cc | 2 +- gnulib/configure | 25 +-- gnulib/import/Makefile.am | 7 + gnulib/import/Makefile.in | 33 ++- gnulib/import/c-ctype.c | 21 ++ gnulib/import/c-ctype.h | 366 ++++++++++++++++++++++++++++++++++ gnulib/import/m4/gnulib-cache.m4 | 2 + gnulib/import/m4/gnulib-comp.m4 | 3 + gnulib/update-gnulib.sh | 1 + 137 files changed, 828 insertions(+), 561 deletions(-) --- base-commit: c2729c37f10af09126b2916215cae425ae724f55 change-id: 20250805-gnulib-c-ctype-1b8fb88a6c5e Best regards, -- Tom Tromey