From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pKr+KcH5e2jPlx0AWB0awg (envelope-from ) for ; Sat, 19 Jul 2025 16:02:09 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=F+MxLBdS; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4C3471E11C; Sat, 19 Jul 2025 16:02:09 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 149FD1E089 for ; Sat, 19 Jul 2025 16:02:07 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 56A223857C4F for ; Sat, 19 Jul 2025 20:02:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 56A223857C4F Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=F+MxLBdS Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by sourceware.org (Postfix) with ESMTPS id 0B75C3858C53 for ; Sat, 19 Jul 2025 20:01:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0B75C3858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0B75C3858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1030 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752955295; cv=none; b=etohTnH/V69j04a302J0iEu9/Ug4KABtzY7z18lFJ1/lytnjZesjhMQTeQG/mUqfe1YjhRCI9lAHxDPKC2fhAqnCC4+4AgyvRoa+y2EAjm95GSCYpB4cUrm8j3hC3+uyCGh74FELSqXpDh94uQIw8Loe2XLSRinZasAQykZOKTc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752955295; c=relaxed/simple; bh=AAcNMQotowL30iRr64jWtoKxdhT8qkUZiZXVVnZKz5E=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=QVbcHLWsk1lA0Pn5+tds2OjilTNyRB3CZUOB/bSuCjaXVvDnisUhFlGFrQAjhKWy+mHaMdsm8TT/27v+Yz01wEePrNDHnZg0sCcketW/swtG4izkxBP9Mu31ZEZuR7bgPv0p+jTkOlM2Y4H+0YjjsKPj8XgNYTkhSDIGnb9g6kk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0B75C3858C53 Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-313fab41fd5so762015a91.1 for ; Sat, 19 Jul 2025 13:01:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752955294; x=1753560094; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lzU3uTswKFbUAQ9v2lLLp39Jy/3yNWFTEiq77ZS5INE=; b=F+MxLBdSSHIlp7GJ16ME7q+br8fIFbzfr1dAoDnEKwINypSEcCcaZ1MtqWuh5LOF/c Kn0we++SY+AMQyFzJ7739i3yChj0PdUZq5Hk7Q2MOhuD15v+zYRBXKi4vpogsP15grNM qU6wh2WMo7rVjDdkfg0/YymVPRTdwzhUTaJzp3Mgo3qfax8LaPMrx0XLv+gqhtC0Z9d2 mpm/PM11AjsEu666xyUPcAsHvmhrBBiQWlihW+xK+a2oPYW1mPrkFsVr2HMuJ4AOgzGk dz10jCiRW3CR7sS/ux359FktIWeS/w3/KznCCKmQLi83FLsmgQFEd09HVWcC7wZowH3K y3cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752955294; x=1753560094; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lzU3uTswKFbUAQ9v2lLLp39Jy/3yNWFTEiq77ZS5INE=; b=lGwdasv34/NfcbrTqDVlARVifZDMzs1MpPVq3tmJZA+RTJmpltR/8CIk6pqUWHdCaq 8nht2dsRAzpiAz6q0XtAvg3QNEgE1l8bvnQnBULLaakCZaf0c8eyfcBfOZiz8HnO6LLU w+YSZyHnCvM4UnBwve0FCT5tkYZHe5hYOF2wYoVFK1vTo4MxhWXIc9LjMlTKl/bEgiu6 ESpbExTi3sGfApELdRdqCz4FABYZRAW7eJCBz1T1uNcZlGXiz96wZz/C4fBJjBqt1Rjl yt2YW0QFF7aY1kAVwMLI2KHh9qnSQbEsphBg+V2gabH1Rkjakl42TbhBxiNYob/FAwlW 7svg== X-Gm-Message-State: AOJu0YywU0bwkqlcq3lIyABqYbtH3hvbQRbaDqK1UPNcC6s5KwbTX0Sg J4tFf1rcnalHx/ArWVMC5fxJzcbVzRzM24J4goiKO1Lrj0m1CEkwadouMwn6SS/v X-Gm-Gg: ASbGncvbuNdc/JpmIzKij/qJQPdm6Qpb9TdNmRawHmf7J0uaqYHKU6mKYiSwCx9EotI yYcO43YHclK6IndSw28a9QGI7JJexJD1GRWTZwaH5tp0XoSJYmPZwG6h8bsFFuMNPzFx7dmdpRK bvkGks6pWI62nfCEkXkZcB7s8Ix4fIwnK5j8sk1LiJ984rNcqfhTp2zbTmllZye+iJgyT6skXIk WrNz9Q+9OT2ySO2Cu8J/o9Pi9jIBsh5hzkGJv16QeC46/s1KrMRDWfcLEX+DGdXL1zhVHk0Ksr6 EjNCk2r3GD0V08tzrqSS4JV54+shfrNFWSgpFAoFmtajZ5JGP18sRfl6kBt4ihO7dEt9va1hRQY ur+jHwC4CfsRrulWFUgMLhQ== X-Google-Smtp-Source: AGHT+IHVeF2iCRg2nAXJFWPocQfHz0wzXR4pRRBHDPWHnPgclY4V9PU9k5yLd+Y5lup0m/QDl+/VlQ== X-Received: by 2002:a17:90b:2ec7:b0:31c:3871:27ad with SMTP id 98e67ed59e1d1-31c9e5febd9mr9104903a91.0.1752955293708; Sat, 19 Jul 2025 13:01:33 -0700 (PDT) Received: from Chet ([122.177.100.161]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31cc0bd12b5sm3659645a91.12.2025.07.19.13.01.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Jul 2025 13:01:33 -0700 (PDT) From: Shiven Kashyap To: gdb-patches@sourceware.org Cc: guinevere@redhat.com, Shiven Kashyap Subject: [PATCH 1/1] [gdb/reverse] Fix failing test: i386-avx-reverse Date: Sun, 20 Jul 2025 01:30:48 +0530 Message-ID: <20250719200052.28404-1-shivenkashyap24@gmail.com> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Running the standalone test `gdb.reverse` leads to the following failure: ''' FAIL: gdb.reverse/i386-avx-reverse.exp: verify ymm15 before vbroadcastsd ''' This happens because the AVX broadcast instructions expect an actual value, but instead it cast memory address of a buffer like so (see 'vpbroadcast_test' in 'i386-avx-reverse.c'): ''' asm volatile ("vbroadcastss %0, %%xmm15": : "m" (dyn_buf0)); ''' which lead to the test failing for the next instruction (`vbroadcastsd`), which depended on the correct value being broadcast to the register. Also, updated the corresponding expected output (gdb.reverse/i386-avx-reverse.exp) to match. Tested on x86-64 Linux. Signed-off-by: Shiven Kashyap --- gdb/testsuite/gdb.reverse/i386-avx-reverse.c | 4 ++-- gdb/testsuite/gdb.reverse/i386-avx-reverse.exp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gdb/testsuite/gdb.reverse/i386-avx-reverse.c b/gdb/testsuite/gdb.reverse/i386-avx-reverse.c index a3d64272f24..bf6cb77f313 100644 --- a/gdb/testsuite/gdb.reverse/i386-avx-reverse.c +++ b/gdb/testsuite/gdb.reverse/i386-avx-reverse.c @@ -299,10 +299,10 @@ vpbroadcast_test () asm volatile ("vbroadcastss %xmm1, %xmm0"); asm volatile ("vbroadcastss %xmm1, %ymm15"); asm volatile ("vbroadcastss %0, %%ymm0" : : "m" (global_buf0)); - asm volatile ("vbroadcastss %0, %%xmm15": : "m" (dyn_buf0)); + asm volatile ("vbroadcastss %0, %%xmm15": : "m" (*dyn_buf0)); asm volatile ("vbroadcastsd %xmm1, %ymm0"); asm volatile ("vbroadcastsd %0, %%ymm15": : "m" (global_buf0)); - asm volatile ("vbroadcastf128 %0, %%ymm0" : : "m" (dyn_buf0)); + asm volatile ("vbroadcastf128 %0, %%ymm0" : : "m" (*dyn_buf0)); /* We have a return statement to deal with epilogue in different compilers. */ diff --git a/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp b/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp index 7e75542720c..fb04260766e 100644 --- a/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp +++ b/gdb/testsuite/gdb.reverse/i386-avx-reverse.exp @@ -395,7 +395,7 @@ if {[record_full_function "vpbroadcast"] == true} { test_one_register "vbroadcastf128" "ymm0" \ "0x17161514131211101716151413121110, 0x17161514131211101716151413121110" test_one_register "vbroadcastsd" "ymm15" \ - "0x404060004040600040406000404060, 0x0" + "0x23222120232221202322212023222120, 0x0" test_one_register "vbroadcastsd" "ymm0" \ "0x13121110131211101312111013121110, 0x13121110131211101312111013121110" -- 2.50.1