From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2FwCCulFemimcxcAWB0awg (envelope-from ) for ; Fri, 18 Jul 2025 09:02:33 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=e+HAJeF8; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=YxqHUidQ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=v7Mf9qrj; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=m+9c/MaH; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 238A81E11C; Fri, 18 Jul 2025 09:02:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AF5AE1E089 for ; Fri, 18 Jul 2025 09:02:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 586AA3851AA0 for ; Fri, 18 Jul 2025 13:02:32 +0000 (GMT) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 81110385F014 for ; Fri, 18 Jul 2025 13:02:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 81110385F014 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 81110385F014 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752843723; cv=none; b=FMqexdf2GSC36EAWqW6rHPuK8gMVKFCtbQdy0CipK3YSumbQPdLuVHO17+JRkGzFSvs11mN6bgMykyx5ZDtkVO1Q/tHxORo/TFVJI+eRFQVbJBaNED/88urpYQD8L6WjkL1aR1G3kj/LXyivk4ED5f6EmERS1IHCA3NJOmlbdKA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752843723; c=relaxed/simple; bh=beayW4mi3SvV+zz0WnjYsOWOnvugPLvqLwhPcejGl6w=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=Rr30/UybuQZY7YwcLyzMTzboNkv76HWM1A06th5D6123Tp2efr0rcC+sROqN8BhobQaWXcFm4/OQKQr9KLssJaXbwcD5pafT1usWCQ1+DgcEPHVr7Wsuqn7kWJX0LCxPRBPDd5DsZ5v3C5+dlZpeKsEOLenZExYKkl+WAWCriig= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 83EDB218E1 for ; Fri, 18 Jul 2025 13:01:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752843716; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X07aBn3my87avtci9HHAyYSk3XyJj+LILEf/RgiFbh4=; b=e+HAJeF8eS5/gw1+dlMFMQa/8DBRTmu5k9YIBj5RjjPo0qVd5AYQbP9UyFETXHKXdmqHxR 10+gFLL/EGg5hRnp5R/VQg9sfpE6zwCQl65VJVhhG7iRDMsQBLDfXJHczO1N3067Tcts3b jR9TzM/TBzh3bNdGUTpzAQNbRxPikIA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752843716; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X07aBn3my87avtci9HHAyYSk3XyJj+LILEf/RgiFbh4=; b=YxqHUidQMFJ7rNSmZUiRNHOUA3LcaVnIF8LQ8O5Z/mrSiJ5+GN4ywx6yHB7kOd5x++dJfY 97SZtISMMpI3hvAg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752843715; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X07aBn3my87avtci9HHAyYSk3XyJj+LILEf/RgiFbh4=; b=v7Mf9qrjSzH9n/+dHa+Tlp1kkCR4Pkf83T6t4WJrUeLaepQ62o+jsAR7tZrb6Plr6MmB/X nan2GdMZ5+i4SPL85AAomEFuLn6UrGdQQ3iN/53cZtXN31IlhEPbjGhqwJzxoZxdGk90H7 uxKNyl4kFq/BTZR29NmYxjmM7j0+s7k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752843715; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X07aBn3my87avtci9HHAyYSk3XyJj+LILEf/RgiFbh4=; b=m+9c/MaHofKT/SAVN++P2k/vXbT1h0Kjptyp92Da2pjnRzfRiqpme416HCCW8hpax+jnko 9PJcYKEflVPARuAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 641D413A73 for ; Fri, 18 Jul 2025 13:01:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id mJIOF8NFemjOHAAAD6G6ig (envelope-from ) for ; Fri, 18 Jul 2025 13:01:55 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 1/7] [gdb/testsuite] Fix Cursor Horizontal Absolute clipping Date: Fri, 18 Jul 2025 15:01:47 +0200 Message-ID: <20250718130153.24989-2-tdevries@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250718130153.24989-1-tdevries@suse.de> References: <20250718130153.24989-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,gdb.tui:url]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_TLS_ALL(0.00)[] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I looked at the tuiterm implementation of Cursor Horizontal Absolute: ... proc _csi_G {args} { set arg [_default [lindex $args 0] 1] _log_cur "Cursor Horizontal Absolute ($arg)" { variable _cur_col variable _cols set _cur_col [expr {min ($arg - 1, $_cols)}] } } ... and noticed a problem with the clipping behavior. If we have say $_cols == 80, and we do _csi_G 81 we get $_cur_col == 80, while $_cur_col is zero-based and should be in the 0..79 range. Fix this by using: ... set _cur_col [expr {min ($arg, $_cols)} - 1] ... which gets us $_cur_col == 79. Add two boundary tests to gdb.tui/tuiterm.exp. Tested on x86_64-linux. --- gdb/testsuite/gdb.tui/tuiterm.exp | 16 ++++++++++++++++ gdb/testsuite/lib/tuiterm.exp | 2 +- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.tui/tuiterm.exp b/gdb/testsuite/gdb.tui/tuiterm.exp index 9dc2402562f..fff7c37a56e 100644 --- a/gdb/testsuite/gdb.tui/tuiterm.exp +++ b/gdb/testsuite/gdb.tui/tuiterm.exp @@ -435,6 +435,22 @@ proc test_horizontal_absolute { } { "qrstuvwx" "yz01234 " } 3 2 + + Term::_csi_G 8 + check "cursor horizontal absolute 3" { + "abcdefgh" + "ijklmnop" + "qrstuvwx" + "yz01234 " + } 7 2 + + Term::_csi_G 9 + check "cursor horizontal absolute 4" { + "abcdefgh" + "ijklmnop" + "qrstuvwx" + "yz01234 " + } 7 2 } proc test_cursor_position { } { diff --git a/gdb/testsuite/lib/tuiterm.exp b/gdb/testsuite/lib/tuiterm.exp index a0cd199aed3..71ef6a4eacd 100644 --- a/gdb/testsuite/lib/tuiterm.exp +++ b/gdb/testsuite/lib/tuiterm.exp @@ -251,7 +251,7 @@ namespace eval Term { variable _cur_col variable _cols - set _cur_col [expr {min ($arg - 1, $_cols)}] + set _cur_col [expr {min ($arg, $_cols)} - 1] } } -- 2.43.0