From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id al7ZI5Ysb2iLPzAAWB0awg (envelope-from ) for ; Wed, 09 Jul 2025 22:59:34 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BuXd5PhM; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 802D01E11C; Wed, 9 Jul 2025 22:59:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1A2521E0C2 for ; Wed, 9 Jul 2025 22:59:34 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A0BE73858420 for ; Thu, 10 Jul 2025 02:59:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A0BE73858420 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BuXd5PhM Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 0CB253858CD9 for ; Thu, 10 Jul 2025 02:59:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0CB253858CD9 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0CB253858CD9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752116344; cv=none; b=QXEV6QbtF36NR9RDrCcn7Ha/e/+InM0umtfd/Bf/IdYcRIYyBIuGXJCzRlez/JyiOGI00o2avWrdfcoky7RdOrGQCcu0DjVZGbrF9fL5mewaChaffEkDGUFnK26WZahgQGzS7IbQ5/KIR6mHVJL5yOAfzbwBumjOS18JjlqO34k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752116344; c=relaxed/simple; bh=8aHMPX5hx2uYgwcVeMVAr3F6h5vuzrdJYh41fDljWG8=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=VG2iTKH8oWpYGvFaP7mTv1NaKjaPV2/wr3VHKF+YreUiYvak+dzeIeZBcGyMRNwLrxpvE4WUlQKgz+RpbcXHo04w6FxDSATl9Umq4k0TQz/QZrDL2pN2nl8KdwbWQ8CyLdXlkBh5L29+QyUNgf18L9kUZAjqj1s3D8OGGqJLxSo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0CB253858CD9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752116343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XLyW9wAXCMWHYTbUnFwDizXClzH0vJMcadI/Wvn8x3s=; b=BuXd5PhMu3Gsk0DlJLquRmUTtSSU3MGVLv51SaN2/gvVsW8Z+sxmVhat4/RUuSarKgOllF OXetmTUUoYE3CPkEJwKUZ09MT5Jas+LKIoDO1R+2++C09oKyt2AAkdg7w/0Op9D7NxbWkM OirIpLYOkda6XLWJETxLI0/QC7lINaE= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-680-Di_2W5MtO8-2ExodxhdADw-1; Wed, 09 Jul 2025 22:59:02 -0400 X-MC-Unique: Di_2W5MtO8-2ExodxhdADw-1 X-Mimecast-MFC-AGG-ID: Di_2W5MtO8-2ExodxhdADw_1752116341 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8540E1801BD8; Thu, 10 Jul 2025 02:59:01 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.64.8]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6CCCB1955E9D; Thu, 10 Jul 2025 02:59:00 +0000 (UTC) Date: Wed, 9 Jul 2025 19:58:57 -0700 From: Kevin Buettner To: Tom Tromey Cc: gdb-patches@sourceware.org, Klaus Gerlicher Subject: Re: [PATCH 1/1] gdb, breakpoint: use breakpoint_debug_printf Message-ID: <20250709195857.5f77b521@f41-zbm-amd> In-Reply-To: <87zfddcgr9.fsf@tromey.com> References: <20250708132123.561491-1-klaus.gerlicher@intel.com> <87zfddcgr9.fsf@tromey.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Iccxrllssa7MwxzP77xbZ51kxc7IE-Ibji09apyXG2Y_1752116341 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Wed, 09 Jul 2025 13:21:14 -0600 Tom Tromey wrote: > >>>>> "Klaus" == Klaus Gerlicher writes: > > Klaus> Some debug prints in breakpoint.c are using > Klaus> infrun_debug_printf (). This does not seem to be the > Klaus> right debug print macro. > > Klaus> Use breakpoint_debug_printf () exclusively in this file. > > I am not so sure about this. It seems to me that some of these may > mostly of interest when infrun debugging is enabled. For example: > > Klaus> - infrun_debug_printf ("incorrect thread or task, not > Klaus> stopping"); > Klaus> + breakpoint_debug_printf ("incorrect thread or task, not > Klaus> stopping"); > > This kind of thing is a decision impacting infrun decisions. Hmm, good point. I rescind my approval. Kevin