From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AbW0OVwfb2g+NDAAWB0awg (envelope-from ) for ; Wed, 09 Jul 2025 22:03:08 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=arLIwpbO; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D690D1E11C; Wed, 9 Jul 2025 22:03:08 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 297F51E0C2 for ; Wed, 9 Jul 2025 22:03:08 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8BDB73858280 for ; Thu, 10 Jul 2025 02:03:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8BDB73858280 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=arLIwpbO Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id D33213858CD9 for ; Thu, 10 Jul 2025 02:02:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D33213858CD9 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D33213858CD9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752112952; cv=none; b=TJThYjFDpPG+QABZJVIIccI3+NPX1+cJkSC7F1zvksfoWMJGagbsiw9rAVPDnVBjwuUE+yeyMGgD+rHUnj9J/Dpu87zuNCCWn1HjIm/zHwrB3AcaOgkluT4Q2PLPTbrSG0W69166bSfn92FQHVYpvhP39CG90LQstXaNZRMmSuE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752112952; c=relaxed/simple; bh=AbfOxouXOTcTI/fiza2B6pROd65Qs3dsthqxGJFWA10=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=XjYBAIvahfU3Aj0uhJaI5lm5SD7+xoXWgrI02aiH3MGoYaHPtXj3me8Cc8snk04Qeow8snyjBWsFj7vLrT6/keb96iCzXrc8FjPNqmUBXIuMe38vkZIWng/OREexwEQL0sZbjRIQDyqsPiiIYNmz7WhUKb4L9ToV2mPcit7FvDA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D33213858CD9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752112952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/eM2sInhV/vNUmkq0Q925Z2L5xA7uImBI689yGZW77o=; b=arLIwpbOxBaY4YsnjrghpY4YuUzxL8280A2e6KV5VN0dc0TQVrh/q/NB9UlXtOznl51Jmr TC8KLzC2OylGUG+IB9LASNjUG2Zl0TQ9JSTvKOKOFzvn4ocPOAq1+YUONSqkq4OEImQwCe 3cr0lfktJ5XWGAquyCElvrHe6bh1qC4= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-Q8bq3VvfMEydpUKJpYA-Cw-1; Wed, 09 Jul 2025 22:02:31 -0400 X-MC-Unique: Q8bq3VvfMEydpUKJpYA-Cw-1 X-Mimecast-MFC-AGG-ID: Q8bq3VvfMEydpUKJpYA-Cw_1752112950 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7B90D1956077 for ; Thu, 10 Jul 2025 02:02:30 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.64.8]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 88B11195608F; Thu, 10 Jul 2025 02:02:29 +0000 (UTC) Date: Wed, 9 Jul 2025 19:02:26 -0700 From: Kevin Buettner To: Guinevere Larsen Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 3/3] gdb: extend the [[N]]::foo syntax for files Message-ID: <20250709190226.41d1be21@f41-zbm-amd> In-Reply-To: <20250619180540.2315103-4-guinevere@redhat.com> References: <20250619180540.2315103-1-guinevere@redhat.com> <20250619180540.2315103-4-guinevere@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PKohrlbMU4YewJXmHTYf68e3CWeOj1AD-77z8jdM2ro_1752112950 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Gwen, On Thu, 19 Jun 2025 15:05:40 -0300 Guinevere Larsen wrote: > diff --git a/gdb/parse.c b/gdb/parse.c > index 64653c8ae6e..6edd9058dcb 100644 > --- a/gdb/parse.c > +++ b/gdb/parse.c > @@ -421,7 +421,8 @@ parse_exp_in_context (const char **stringptr, > CORE_ADDR pc,=20 > parser_state ps (lang, get_current_arch (), expression_context_block, > =09=09 expression_context_pc, flags, *stringptr, > -=09=09 completer !=3D nullptr, tracker); > +=09=09 completer !=3D nullptr, tracker, > +=09=09 current_program_space->solib_ops ()); > =20 > scoped_restore_current_language lang_saver (lang->la_language); > =20 I'm seeing a build error related to the bit above: /mesquite2/sourceware-git/worktree-review/gdb/parse.c: In function =E2=80=98expression_up parse_exp_in_context(const char**, CORE_ADDR, const = block*, parser_flags, innermost_block_tracker*, std::unique_ptr*)=E2=80=99: /mesquite2/sourceware-git/worktree-review/gdb/parse.c:425:53: error: invalid conversion from =E2=80=98const solib_ops*=E2=80=99 to =E2=80=98soli= b_ops*=E2=80=99 [-fpermissive] 425 | current_program_space->solib_ops ()); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ | | | const solib_ops* In file included from /mesquite2/sourceware-git/worktree-review/gdb/parse.c:41: /mesquite2/sourceware-git/worktree-review/gdb/parser-defs.h:152:28: note: initializing argument 9 of =E2=80=98parser_state::parser_state(const language_defn*, gdbarch*, const block*, CORE_ADDR, parser_flags, const char*, bool, innermost_block_tracker*, solib_ops*)=E2=80=99 152 | solib_ops *ops) | ~~~~~~~~~~~^~~ Kevin