From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FknVCXt6bmi2wi8AWB0awg (envelope-from ) for ; Wed, 09 Jul 2025 10:19:39 -0400 Received: by simark.ca (Postfix, from userid 112) id 0AD7B1E11C; Wed, 9 Jul 2025 10:19:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 905CB1E089 for ; Wed, 9 Jul 2025 10:19:38 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 88F943858C62 for ; Wed, 9 Jul 2025 14:19:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 88F943858C62 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 2A2D73858C62 for ; Wed, 9 Jul 2025 14:18:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A2D73858C62 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2A2D73858C62 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752070730; cv=none; b=fmRkJjci1zbHfbx7h4LHAIef/nyy1dC7MTDlEmxn8VzYeBx9ruRkU2ok1AvfkjRj8KOdzja7+hJ1AmTaDxK+YGBOOhRGcE50NEzojGW4oxFUkyhyOXLM3sZTQHdU8W+gAbbyQO3/p51BEGGE4k4ddggrHLXIOzzEK4Lo9vjD6tw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752070730; c=relaxed/simple; bh=+Ehgnndrl1SqH12u3GUteY9jsRktwIWNTQCepze7+JA=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=ffrtYOQOldNF2LECMXgk7jqtiw1Iio2tOzAr+Op5BGVTnnnFxSpuyH6f93XCg6jF+BEbX8FPi5/7osAJ0sMzFNHWHfqF9hxfrmnMB9aLzvPJx8bqzXlKts5m9spTNwYdnOViC7NwI+XQ9GeVHo4dT5myoexoVI7YauewNtq8sg8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2A2D73858C62 Received: by simark.ca (Postfix, from userid 112) id 995121E11E; Wed, 9 Jul 2025 10:18:49 -0400 (EDT) Received: from smarchi-efficios.internal.efficios.com (192-222-132-26.qc.cable.ebox.net [192.222.132.26]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B25C01E089; Wed, 9 Jul 2025 10:18:48 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH] gdb/solib-svr4: use program space from solib in find_debug_base_for_solib Date: Wed, 9 Jul 2025 10:18:46 -0400 Message-ID: <20250709141848.155865-1-simon.marchi@efficios.com> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Instead of using the current global program space, I think it makes sense to fetch the program space from the solib. The comment for solib::objfile indicates that it may be nullptr (which is true), but in this case, the callers (all in svr4_iterate_over_objfiles_in_search_order) find the solib from an objfile, so we know that solib::objfile (the link in the opposite direction) is set for these solibs at this point. Change-Id: I75037d0b2c39ab1b3a3792432be134e200438efe --- gdb/solib-svr4.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c index 9b4cabfd5f4b..e45425438790 100644 --- a/gdb/solib-svr4.c +++ b/gdb/solib-svr4.c @@ -3582,7 +3582,10 @@ find_debug_base_for_solib (const solib *solib) if (solib == nullptr) return 0; - svr4_info *info = get_svr4_info (current_program_space); + /* This is always called for solibs with an associated objfile. */ + gdb_assert (solib->objfile != nullptr); + + svr4_info *info = get_svr4_info (solib->objfile->pspace ()); gdb_assert (info != nullptr); auto *lm_info base-commit: 61be4420118b4039b80894ff57ad25f063218bfe -- 2.50.1