From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WuZdIltdUWgO9BEAWB0awg (envelope-from ) for ; Tue, 17 Jun 2025 08:19:39 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=K+T2ALwN; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6D19A1E11C; Tue, 17 Jun 2025 08:19:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3147B1E102 for ; Tue, 17 Jun 2025 08:19:37 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EAA533A4AF76 for ; Tue, 17 Jun 2025 12:19:36 +0000 (GMT) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by sourceware.org (Postfix) with ESMTPS id 03EAC3A39926 for ; Tue, 17 Jun 2025 12:12:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 03EAC3A39926 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 03EAC3A39926 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=192.198.163.14 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1750162354; cv=none; b=YsZFxG+JdXOtk/VgdSDPpJ1q3VB4F244ygsmgqpy1FnvtB2GzDMnkdFPJ4SMPlX7xlWenFj/ndQzQYozHDUzio2Mov0bu5W9L2CnBxF5ErhNVTogVqJFthKhmTc2GTMWUilSJ+Ncwb34fpLfQfZvVdFCHpP/bvcsseqDqVokkNg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1750162354; c=relaxed/simple; bh=asQvVw6IeE2tnRIxx/Ce/MaXNuY3Tn0mttjLRLsIpyg=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=XjPWp4DynBq7W7Kiwd8ONAX7dG/ErmCh8SHF7EL7+wKLumXdtBkrhE9IRrSz8q2z/cRQdeYT+DnTkJvqmse/Ip0mnYQqhq9IcSWOQd/DB3CDF+jzYggZtIcGOOBZlPBVdkGClzUVR8FR5MntJCxE+kIlPpCCmEActItHKagJVnA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 03EAC3A39926 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=K+T2ALwN DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750162354; x=1781698354; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=asQvVw6IeE2tnRIxx/Ce/MaXNuY3Tn0mttjLRLsIpyg=; b=K+T2ALwN1mtQd44iF79wQlSkQSKiihqh1R+FqoQvd58XUKKsTB+tfeNB OMUrfPlEbSIyjkibYvC5I5u/Bg32PiBh6GV448OT8+F5L8uEDYziFUmul jdCj2w7RMW+bCf+5kg9BCZyjes4YK7XFRihfNhjqqs6tABbs7+DSZcHIc 9dKELwXt5oE9SefXyPijCzjMTx4hJ7nt4H3Q1nSCgXB3hqGY0vUulVkpJ ZhS26Xdy0G2Rrszcj36fV+DVAq/8V0YxfEhAED1ZAg6Z/6uNhiaBHNPV8 MfQd1hXZ8fcYrczpE5djqdNB37ke75YaWS0p4erXk1DLiJCa2YtrGu8Ro A==; X-CSE-ConnectionGUID: rZXEshuyTIKoFEyXFpWjEA== X-CSE-MsgGUID: gMrocbznR/uVpcJEE7lisw== X-IronPort-AV: E=McAfee;i="6800,10657,11467"; a="52429461" X-IronPort-AV: E=Sophos;i="6.16,243,1744095600"; d="scan'208";a="52429461" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2025 05:12:33 -0700 X-CSE-ConnectionGUID: igqxq4rHSUaIleNF9VKoww== X-CSE-MsgGUID: VhBDfdleQPSTTn2BMgDKJA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,243,1744095600"; d="scan'208";a="148748632" Received: from gkldtt-dev-004.igk.intel.com (HELO localhost) ([10.123.221.202]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2025 05:12:31 -0700 From: Christina Schimpe To: gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org, eliz@gnu.org Subject: [PATCH v4 02/11] gdbserver: Add assert in x86_linux_read_description. Date: Tue, 17 Jun 2025 12:11:38 +0000 Message-Id: <20250617121147.1956686-3-christina.schimpe@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250617121147.1956686-1-christina.schimpe@intel.com> References: <20250617121147.1956686-1-christina.schimpe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On x86 the PTRACE_GETREGSET request is currently only used for the xstate regset. The size of the xstate regset is initialized to 0 such that it can be reset to the appropriate size once we know it is supported for the current target in x86_linux_read_description. However, this configuration would not just affect the xstate regset but any regset with PTRACE_GETREGSET request that is added in the future. The new regset would be misconfigured with the xstate regset size. To avoid this we add an assert for unsupported regsets and check explicitly for the note type of the register set. Reviewed-by: Thiago Jung Bauermann --- gdbserver/linux-x86-low.cc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gdbserver/linux-x86-low.cc b/gdbserver/linux-x86-low.cc index 918630d4b61..24920e71a53 100644 --- a/gdbserver/linux-x86-low.cc +++ b/gdbserver/linux-x86-low.cc @@ -894,7 +894,12 @@ x86_linux_read_description () regset++) { if (regset->get_request == PTRACE_GETREGSET) - regset->size = xsave_len; + { + if (regset->nt_type == NT_X86_XSTATE) + regset->size = xsave_len; + else + gdb_assert_not_reached ("invalid regset type."); + } else if (regset->type != GENERAL_REGS) regset->size = 0; } -- 2.34.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928