From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kSN3AS8tLmh0Ni0AWB0awg (envelope-from ) for ; Wed, 21 May 2025 15:44:47 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=agpt89Yk; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EB7AD1E11C; Wed, 21 May 2025 15:44:46 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9C73C1E102 for ; Wed, 21 May 2025 15:44:46 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3B34E3858427 for ; Wed, 21 May 2025 19:44:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3B34E3858427 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=agpt89Yk Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id C79D13858C56 for ; Wed, 21 May 2025 19:44:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C79D13858C56 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C79D13858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1747856658; cv=none; b=CSdWA1WkY31VDtudmTsuDoTdgiwLylhmcJzKk+xj47D0N37NrT061cB2kh2xRK12+l8KEIH4EBqhkfocYeeSPw9haaBSrX2R7cLOMZSdQUGr3oC92AluGemXz26X0ZVmSQXULk+TjCUlCAxYdGFagzZFTBFPhk3nN5OM5iMRv1U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1747856658; c=relaxed/simple; bh=qy7GZ47lP/GfHvjsBzi2vjoFac4tQZrxG577C/u7sBc=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=uK0wz+0ZSg5Fac8j/00n49841l+3ZjDlBv8avDq5mJgxl/SwQsiMEScLa8ynufhasTRU/pwF2smRNoCwNL/Q2zggW+0SzHzkuhrzRu8WAmpig//GNjC6B1EBAQAEYslpwcdH75dkxaGtLCkijfLnRQpZ5bVWrgLywf3SeVYSJ/g= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C79D13858C56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747856658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xP38LMJhcPymeNXObd1d6NeT6ybhyciLGnPErm1StD8=; b=agpt89YkgvYqJSQZspuUY00RFFGwU8FHcvESsGlc6rXo1PA5uakS+4nEStcuw3ZliSyVZr 6iFLwJpdcCG6GnIzKQuF6l20u1w9E+Qmcp1m054KAVwLpUgYe/PDtvhdl4dWohbi7xJm/i g/Owq2e37zgst/uIDggAt62JL1dL/rs= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-519-aohdB-OIPB6hL_QZwtixwQ-1; Wed, 21 May 2025 15:44:17 -0400 X-MC-Unique: aohdB-OIPB6hL_QZwtixwQ-1 X-Mimecast-MFC-AGG-ID: aohdB-OIPB6hL_QZwtixwQ_1747856656 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 501AE18004A7; Wed, 21 May 2025 19:44:16 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.80.66]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 60E6C1800570; Wed, 21 May 2025 19:44:15 +0000 (UTC) Date: Wed, 21 May 2025 12:44:10 -0700 From: Kevin Buettner To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 03/47] infrun: Remove unnecessary currently_stepping call Message-ID: <20250521124410.08b8489e@f41-zbm-amd> In-Reply-To: <20250519132308.3553663-4-pedro@palves.net> References: <20250519132308.3553663-1-pedro@palves.net> <20250519132308.3553663-4-pedro@palves.net> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: EMywm0vZE4Mm8MSqxlJY4Iq0GxcFnkhr6HNXXgYh08M_1747856656 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Mon, 19 May 2025 14:22:24 +0100 Pedro Alves wrote: > There's one unnecessary check for currently_stepping in > handle_signal_stop that can be removed. It is unnecessary because > currently_stepping is only ever called if > ecs->event_thread->control.trap_expected is true, and then if it is > true, then currently_stepping always returns true too. After looking at the definition of currently_stepping(), I agree with your reasoning (and your patch). Approved-by: Kevin Buettner