From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SDToHYgxK2hNNioAWB0awg (envelope-from ) for ; Mon, 19 May 2025 09:26:32 -0400 Received: by simark.ca (Postfix, from userid 112) id 7831E1E11C; Mon, 19 May 2025 09:26:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2419A1E102 for ; Mon, 19 May 2025 09:26:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8F98E3858415 for ; Mon, 19 May 2025 13:26:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8F98E3858415 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by sourceware.org (Postfix) with ESMTPS id 25D623858406 for ; Mon, 19 May 2025 13:23:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 25D623858406 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 25D623858406 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1747661010; cv=none; b=ZJwMOAt9cLp8Ys/w4Lry38Esodc04w5k6XjlJ7WwMsv//d8WgT5yyv1JgR0jmGXP2Y+HAxdnY/nyop9YlC+Ll0CYu81a75ZjCMmfOuNS18I3BPgaZHno5vEqPzOvItXsH5s7BOcMDzy3r8P09zww2SWm30izbP/nZ4WClqBPNzU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1747661010; c=relaxed/simple; bh=7VgU/jhW9NGS5f1sER+UKJZ9VQ4icCRjeCXr6EoUfNQ=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=ZZgPpZte1X8biNAqBsNd+wEyZ7RXmpKNTdcBD+zGjPLxSkiyPjf8qhYgoLfGTWJvgKpJF6O0F9O0OihLqBRPMUiSWPWu7Ys8H5GubPipOlTC1q+/2+aqBN8cPf9j5iW+aWPt21xDiZWOQwULpTSCe5vLkiKOzk1QGKaYQXLkxtc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 25D623858406 Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-43cfba466b2so47793815e9.3 for ; Mon, 19 May 2025 06:23:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747661009; x=1748265809; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X/jsX9blz2WcVK41ox14xbS+J9lbyIlz/aiUnhdsko4=; b=V43HBgwu9Bhn1BhuODGQYJWKi5fHeP5Hw56+r6KZxSoAkmJ5U3lpqde44Jfg8LNUpa ifMow9rDjzEcF2Id+XQvWYayP9sJ4Ff7DAcQNL0M/3ZKykzMhgtj904GIxKLHZhrZxoH yWa36dotHbTz8/R3U2nPlHhpLYWin8wOmfBPBWLxShjxy674L+wmVL9MO0DNAs6nCboF matRDumsDn+3PWM9aitiiAPuHOKXh678GQm7LFKlfJXwjtrrhWCR8KkSKNRZP1PdU/W6 dF3n/VkZx2I0UpGGb3X5kaBZ6IWXhCSQRd91i51RLpRoI42RGhkrFSpGz0v4E8SSiqAa fUqw== X-Gm-Message-State: AOJu0YxNOy3r/Hk5DbenS1fM8DWBgztBw9vARt2dnJwwbC1NeRs583F8 fniMO9rHPYSVqilKZqe+KJDu+y02akcP+ViARk/ezyQ6iB/zgUlv5QbJqdHRMAfZ X-Gm-Gg: ASbGncv9Oo0jmKehYhpxwpOqbBIVcZx5aA3ESyUMxN8QZdlVb8DdVqa7GF+XFi7B8xW UyPrShJgSidrs29BPtDKz+8KJdfoRtVVZOY0CUI1qj7r9CVn6wEB7rSCnmnF1DBMzcU77C5zNul 5GIpq9ZpWUuXopRLStp3pJ+wdjFSu/e5q80mxdKyolrZ+62QH4QTmsTjeM3VQJo3Wpt3TF6Ki52 B4LZ+YtUmfKJtTc0NxHAp3zNpKQVw90wa9xBuq44c81X/3iANeHTe8GrX1nOwFIgNwpH8T8zlgc 0veYo0Ok6tHxs5byylF7EjkMHz9OIIb38rlRPUb1aNxQcYFa3rk= X-Google-Smtp-Source: AGHT+IG0hs7KNT2s62BqloDvSQ8Yi1yhaGwcVj853BD22lFNn3pUhxEG3aFpm6NVTe7FDuiwe/qB6Q== X-Received: by 2002:a05:600c:c1b:b0:43c:e481:3353 with SMTP id 5b1f17b1804b1-442feffbb8dmr135152465e9.17.1747661008570; Mon, 19 May 2025 06:23:28 -0700 (PDT) Received: from localhost ([2001:8a0:4fe9:b400:8d90:6f0d:36bf:32df]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a36a83b63bsm6896013f8f.97.2025.05.19.06.23.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 May 2025 06:23:28 -0700 (PDT) From: Pedro Alves To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH v2 06/47] Windows gdb: Dead code in windows_nat_target::do_initial_windows_stuff Date: Mon, 19 May 2025 14:22:27 +0100 Message-ID: <20250519132308.3553663-7-pedro@palves.net> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250519132308.3553663-1-pedro@palves.net> References: <20250519132308.3553663-1-pedro@palves.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org In windows_nat_target::do_initial_windows_stuff, there's no point in setting windows_process.current_event.dwProcessId. It's a nop, given the following memset. Approved-By: Tom Tromey Change-Id: I2fe460341b598ad293ea60d5f702b10cefc30711 --- gdb/windows-nat.c | 1 - 1 file changed, 1 deletion(-) diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index 0fee4ad5866..092cb699a4a 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -1783,7 +1783,6 @@ windows_nat_target::do_initial_windows_stuff (DWORD pid, bool attaching) windows_process.cygwin_load_start = 0; windows_process.cygwin_load_end = 0; #endif - windows_process.current_event.dwProcessId = pid; memset (&windows_process.current_event, 0, sizeof (windows_process.current_event)); inf = current_inferior (); -- 2.49.0