From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EJ6DFNcxK2hNNioAWB0awg (envelope-from ) for ; Mon, 19 May 2025 09:27:51 -0400 Received: by simark.ca (Postfix, from userid 112) id 4D14F1E11E; Mon, 19 May 2025 09:27:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C0F031E102 for ; Mon, 19 May 2025 09:27:50 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 745A43858426 for ; Mon, 19 May 2025 13:27:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 745A43858426 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by sourceware.org (Postfix) with ESMTPS id 4D4883858C24 for ; Mon, 19 May 2025 13:23:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4D4883858C24 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4D4883858C24 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1747661000; cv=none; b=tjX2ZsbbOLC+G8RQT+5Qx6V/e5tspmPXWsquiJZ14w5pITIpcHWpVb2bQSO3YUJkzTlAPczmse1T8nIxUEkRT23xinfPJrIw150mbx9PQhF72K4oJrxU3J8CpQWZNZuYYfVnhwvsHj+xcKSuMUqIA3hDbdoUiWIXBecKbwwiUHE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1747661000; c=relaxed/simple; bh=JPO8Ubc/KtJaW/symM1IJ+Hks6HXgYqn5cpyiYA4YLs=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=CTF0WKPRYhvmWHH/MLmg3hK7NZp/pKHOPvIMNuaLL0WpxedLIBgzP66s6bjrsJ0bKUAfew3FvF5PAwID7pBg28xtOVhy/nzi7f9iD/ql1FSUPGFGXMZgiVN4tZvqE3WCRM6gz5t3XSV3Ax4FLpq1SSsI5P6PP10iNkmh4gxJQxI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4D4883858C24 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-441d1ed82faso33327865e9.0 for ; Mon, 19 May 2025 06:23:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747660999; x=1748265799; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S1NZbe8poFniy6x0zcLhS3tfznvYsdMnnq5Fo2R68sk=; b=U/i3ZEupWhdp8GrKIUIeLr0eNphCVnI18PTd3TsEDz+xTmrbX54XJN4SVW9qt8VdAk nn6DlthtkpRhgv1ClETTblbCrIWQryYZNqtBa32HGDm/olGt8Tyy7g2ohs1S1vr+qlWn xpoWzyWhIvabXgA068pbesb0qf5Gw/7WhzjDbbf0MJl3JdRq3q2hqHt9inluI6hwi5eD bJ2VaDj83iaRI/y8alssOxhs/yQwluQkM95zL0+DBHdVaQdOCwc/phRSpDQ77lPIbuXn +eroUitfjpoD3imdKZUun5YFTgSMRGtKAOhzbFRePTH41jxiNWV9zhsrtorsi/PYD2lu 097g== X-Gm-Message-State: AOJu0Yz1d0SU7tQa3Q8xMH4F+0Yh58Jm0tmDXxuLvh97ufDfPzXQ8JSm 1uIG77E4kO1VTJgECexlXVXpuPmcupZNsrttzlizLECKbl1HfymToH0fflXuQm+R X-Gm-Gg: ASbGnctp6ojdO0MhDK2NYqW2088y4Q2HsyB3czcJKkGfoJTaOHJuDzbbj3HekAKvRvR l0saGjugilM/1vMBN7LF9VrkjXGh0o51D+wsfGldQFBsGzb59j63/nzzOvL9FTU/KmtCxGeCVvg AhIW7/27f2ZsbqlBusI6nZorirNAUUem73qsTtcnR0KsZcvpumQRyZWNA1AT1J+e2CizhIHQlPb Ht/WGQ1Ai63yat6nd490m6dbr6JgnoljIBy0t3VwjqFZJaMwLD2102aCnBFZ8xzHgNozvNYfrO7 90NoQ4QmKd4InCm9icNrMjAn974HNqNwaLrAVJqqz35m8+8W02D9MqhMsRJkiw== X-Google-Smtp-Source: AGHT+IFJBHcjTF6TbPfYC/aqZ7MMqUgDXas1BQaXMuF+0+6cfdQdy21dlsj2lvVeHM1YalPxyAwJNg== X-Received: by 2002:a05:600c:34d5:b0:43c:e7a7:1e76 with SMTP id 5b1f17b1804b1-442fefd5e7fmr113804085e9.1.1747660998790; Mon, 19 May 2025 06:23:18 -0700 (PDT) Received: from localhost ([2001:8a0:4fe9:b400:8d90:6f0d:36bf:32df]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-442fd59701dsm136339235e9.35.2025.05.19.06.23.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 May 2025 06:23:18 -0700 (PDT) From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH v2 03/47] infrun: Remove unnecessary currently_stepping call Date: Mon, 19 May 2025 14:22:24 +0100 Message-ID: <20250519132308.3553663-4-pedro@palves.net> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250519132308.3553663-1-pedro@palves.net> References: <20250519132308.3553663-1-pedro@palves.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org There's one unnecessary check for currently_stepping in handle_signal_stop that can be removed. It is unnecessary because currently_stepping is only ever called if ecs->event_thread->control.trap_expected is true, and then if it is true, then currently_stepping always returns true too. Change-Id: I7b07bc62e8570333d2e4856d2e55ae6e58f8260c --- gdb/infrun.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gdb/infrun.c b/gdb/infrun.c index 0b872879961..119bd151034 100644 --- a/gdb/infrun.c +++ b/gdb/infrun.c @@ -7069,8 +7069,7 @@ handle_signal_stop (struct execution_control_state *ecs) if (ecs->event_thread->stop_signal () == GDB_SIGNAL_TRAP && ecs->event_thread->control.trap_expected - && gdbarch_single_step_through_delay_p (gdbarch) - && currently_stepping (ecs->event_thread)) + && gdbarch_single_step_through_delay_p (gdbarch)) { /* We're trying to step off a breakpoint. Turns out that we're also on an instruction that needs to be stepped multiple -- 2.49.0