From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KLLXL98yK2hiOCoAWB0awg (envelope-from ) for ; Mon, 19 May 2025 09:32:15 -0400 Received: by simark.ca (Postfix, from userid 112) id C0DA11E11C; Mon, 19 May 2025 09:32:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E24141E102 for ; Mon, 19 May 2025 09:32:14 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2E6833858D37 for ; Mon, 19 May 2025 13:32:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2E6833858D37 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by sourceware.org (Postfix) with ESMTPS id 638293858428 for ; Mon, 19 May 2025 13:24:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 638293858428 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 638293858428 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1747661051; cv=none; b=lmjkERngsvfCaz7yUF0GuEyRINKLBBDLUNRoUaEPRLvUsTpu1lB8b3E3SBIu/SWVFAW9EdFnNTHuROgA7oIZsA0Q6QD8cRWs85l7eHSH6nYlOvJ3q2LUWIXvv33+kFxMvXPo4jqZ+o4ku+dKD1qi/sLU0r1JtjUmPE9tl2NbZBI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1747661051; c=relaxed/simple; bh=BxbbPTeqfmGz1fWSy2X/Y0KFcqCGCoHzJVTXtiCFAwQ=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=xu0dph2ZOpbDGPSvxgIDgFXtE7/ufFAVYGHX/XadtfcNXFUebYB1ICz/PbNjjRrMMk3o4lkW3lB3DbZK00RnziDz2axYxky+x6plsKzUN4koPgEVzHYGBReokDmxaMbvZ0yTkmRklG8GTV+vdyZ75BYLZZr//eQWGw1RvYWI8eU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 638293858428 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-43cfebc343dso32409845e9.2 for ; Mon, 19 May 2025 06:24:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747661050; x=1748265850; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jRXFkYqPKIkddriUVcdfMZcxUkNFNM6WfewLqvXpCA8=; b=qUauALIIdxpNKPepqC14+9nInsxhHAboGo3Dw9Sn/Az/McGCiGGbTq6JViRm4dtxZc Ri6/KQD1bhxaMmxcwUcBn7IP7wixjYVAG7tc6CGIEYoatAHxXnlkh5Ug1pQtqzR9N2s/ RK3X97flM1RFTcearQ01HVoaM+3pwRyCnLvZycOPii7mEAXrxfqb7wb8NDs/dG6pV9b0 bhHe7n30v0rYG6vML63hCgHEIq8gdbBRcyZgX1JbHfeI/tU7pxe9u8GEZSmFKFuYhhaD IuVRzRF0N3Zqq37C0XPzpykkNyEZfVKnWLtWVupY0kxHxFXr18JHNxSMN8YZEFR9rGlN NA5g== X-Gm-Message-State: AOJu0YxkVcuELZ+8ezQPaYno0IaikTXHABGyF9pq+8HbN0DwTSKuHhJV PpK2HiM3Vx9i5LmiJrs3gK+4xffBgZPnwu4cdSDuq/qCK/ZflvcG3sFTcUI6dxfL X-Gm-Gg: ASbGnct6v2Bmd51nk/gl7olN0UdbG/ULVG3HIi4lIFj6wILpvTlhYJwSE/6FNoAD9c8 J0Ki158cbTW4t6WM1NasPp7ZN0TCZpE8ngBmN9P3+yFyUuw2wyzgXyUQCCbdxmWoeKmN4VLgfI/ WFLIqOAhzkjw18MethrrAUp2lYeOsZvrlO5M2KL4HkigthkqG3iGJnRhWW3SsYEKbRmVN4VbH0g 3Se3CSXQSzGaKh+Vi2E9/T7QSPwWe0V2dNM3QpoaPmVmlFwjfQAt2u/B9bNHSD8VNULg9ItO8KT iU0Ft1Y9WHEU+SF76Kb0p43viWVn+iwRftEI1SEMYTKJdyaZnFM= X-Google-Smtp-Source: AGHT+IElvFQTveg0z2+w6mNOoSzCgFO0yY00XClBszbm1vqvuEZHlJy7cWBSrvuPphX5Kp+j4BhZ4Q== X-Received: by 2002:a05:600c:c10:b0:442:f989:3dfb with SMTP id 5b1f17b1804b1-442fd60b448mr116621245e9.1.1747661049785; Mon, 19 May 2025 06:24:09 -0700 (PDT) Received: from localhost ([2001:8a0:4fe9:b400:8d90:6f0d:36bf:32df]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-442f33691f2sm210253645e9.3.2025.05.19.06.24.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 May 2025 06:24:09 -0700 (PDT) From: Pedro Alves To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH v2 19/47] Windows gdb: Pending stop and current_event Date: Mon, 19 May 2025 14:22:40 +0100 Message-ID: <20250519132308.3553663-20-pedro@palves.net> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250519132308.3553663-1-pedro@palves.net> References: <20250519132308.3553663-1-pedro@palves.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I noticed that windows_nat_target::get_windows_debug_event does not copy the event recorded in pending stop to windows_process.current_event. This seems like an oversight. The equivalent code in gdbserver/win32-low.cc does copy it. This change will become moot later in the series, but I figure its still clearer to correct the buglet as preparatory patch. Approved-By: Tom Tromey Change-Id: Ic8935d854cf67a3a3c4edcbc1a1e8957b800d907 --- gdb/windows-nat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index 1f6293aa8c0..2bed29edc50 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -1452,6 +1452,7 @@ windows_nat_target::get_windows_debug_event { thread_id = stop->thread_id; *ourstatus = stop->status; + windows_process.current_event = stop->event; ptid_t ptid (windows_process.current_event.dwProcessId, thread_id); windows_thread_info *th = windows_process.find_thread (ptid); -- 2.49.0