From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uL9pKKkcGWhjUhYAWB0awg (envelope-from ) for ; Mon, 05 May 2025 16:16:41 -0400 Received: by simark.ca (Postfix, from userid 112) id A15041E10E; Mon, 5 May 2025 16:16:41 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 26CFD1E089 for ; Mon, 5 May 2025 16:16:41 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C80273857712 for ; Mon, 5 May 2025 20:16:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C80273857712 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 875CF3857820 for ; Mon, 5 May 2025 20:15:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 875CF3857820 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 875CF3857820 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1746476153; cv=none; b=hhsOm5OOL6MEz4plAUxLLQEXI4Sqbdt9XbDcfivxKOZVNL/cEytGBqD7e4XcP7uoNLN9IeVJVrXqLqQpgTApVgIh2jLuQnB5VquOknzuSR8ETf0HqD3uzo6xaeifQJ7rXMBq+hPMnGvv63+VlvfnyWxYecbXWi/XY8NTJ32R5tc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1746476153; c=relaxed/simple; bh=RzP9s0bx90RZ3GXj62psCe76eSzFiiEOug8WTdSUS4w=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=Zza1Wosjj+eOKF55P/m9RjqE65ry34nkMnwwjHS8hwiHxyDkiOpKCpzyRxCOrsEjlxLtdKpbBax/CUgUHoQqUIOGEplFnwBD/94NJ8l7i9KnIddofr4FppWH6hgcUX+YkjIugBjeX9ivHYg1bP70L73HIMeZQYclUiTwKl9Pwy4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 875CF3857820 Received: by simark.ca (Postfix, from userid 112) id 2BB871E12B; Mon, 5 May 2025 16:15:53 -0400 (EDT) Received: from smarchi-efficios.internal.efficios.com (96-127-217-162.qc.cable.ebox.net [96.127.217.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 18E1D1E100; Mon, 5 May 2025 16:15:49 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 2/6] gdbsupport: make gdb::parallel_for_each's n parameter a template parameter Date: Mon, 5 May 2025 16:15:26 -0400 Message-ID: <20250505201548.184917-2-simon.marchi@efficios.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250505201548.184917-1-simon.marchi@efficios.com> References: <20250505201548.184917-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Simon Marchi This value will likely never change at runtime, so we might as well make it a template parameter. This has the "advantage" of being able to remove the unnecessary param from gdb::sequential_for_each. Change-Id: Ia172ab8e08964e30d4e3378a95ccfa782abce674 --- gdb/minsyms.c | 2 +- gdb/unittests/parallel-for-selftests.c | 4 ++-- gdbsupport/parallel-for.h | 10 ++++------ 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/gdb/minsyms.c b/gdb/minsyms.c index 124d96d90b56..4a6459a6f2d2 100644 --- a/gdb/minsyms.c +++ b/gdb/minsyms.c @@ -1479,7 +1479,7 @@ minimal_symbol_reader::install () msymbols = m_objfile->per_bfd->msymbols.get (); /* Arbitrarily require at least 10 elements in a thread. */ - gdb::parallel_for_each (10, &msymbols[0], &msymbols[mcount], + gdb::parallel_for_each<10> (&msymbols[0], &msymbols[mcount], [&] (minimal_symbol *start, minimal_symbol *end) { scoped_time_it time_it ("minsyms install worker"); diff --git a/gdb/unittests/parallel-for-selftests.c b/gdb/unittests/parallel-for-selftests.c index c9a1689acfb0..f3d85a85704c 100644 --- a/gdb/unittests/parallel-for-selftests.c +++ b/gdb/unittests/parallel-for-selftests.c @@ -94,9 +94,9 @@ test_parallel_for_each () const std::vector for_each_functions { [] (int start, int end, foreach_callback_t callback) - { gdb::parallel_for_each (1, start, end, callback); }, + { gdb::parallel_for_each<1> (start, end, callback); }, [] (int start, int end, foreach_callback_t callback) - { gdb::sequential_for_each (1, start, end, callback);} + { gdb::sequential_for_each (start, end, callback);} }; for (int n_threads : { 0, 1, 3 }) diff --git a/gdbsupport/parallel-for.h b/gdbsupport/parallel-for.h index c485c36d4859..b74c8068cf2c 100644 --- a/gdbsupport/parallel-for.h +++ b/gdbsupport/parallel-for.h @@ -40,10 +40,9 @@ namespace gdb at least N elements processed per thread. Setting N to 0 is not allowed. */ -template +template void -parallel_for_each (unsigned n, RandomIt first, RandomIt last, - RangeFunction callback) +parallel_for_each (RandomIt first, RandomIt last, RangeFunction callback) { /* If enabled, print debug info about how the work is distributed across the threads. */ @@ -73,7 +72,7 @@ parallel_for_each (unsigned n, RandomIt first, RandomIt last, if (parallel_for_each_debug) { debug_printf (_("Parallel for: n_elements: %zu\n"), n_elements); - debug_printf (_("Parallel for: minimum elements per thread: %u\n"), n); + debug_printf (_("Parallel for: minimum elements per thread: %zu\n"), n); debug_printf (_("Parallel for: elts_per_thread: %zu\n"), elts_per_thread); } @@ -141,8 +140,7 @@ parallel_for_each (unsigned n, RandomIt first, RandomIt last, template void -sequential_for_each (unsigned n, RandomIt first, RandomIt last, - RangeFunction callback) +sequential_for_each (RandomIt first, RandomIt last, RangeFunction callback) { callback (first, last); } -- 2.49.0