From: Kevin Buettner <kevinb@redhat.com>
To: Luis Machado <luis.machado@arm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v7 00/11] GDB-internal TLS support for Linux targets
Date: Thu, 24 Apr 2025 10:03:11 -0700 [thread overview]
Message-ID: <20250424100311.104bf428@f41-zbm-amd> (raw)
In-Reply-To: <64bc73f4-cbed-4a2c-a877-0f37ff631020@arm.com>
On Thu, 24 Apr 2025 09:20:58 +0100
Luis Machado <luis.machado@arm.com> wrote:
> I spotted a few whitespace issues across the series (and git am
> also complained about them). Trailing whitespace and
> spaces-instead-of-tabs issues. Could you please clean those up
> before pushing?
Done.
> The tests also work fine, failing without the series and passing
> with the series applied.
>
> Just an observation, and not something that needs to be addressed,
> but it seems we have many more PASSes than FAIL's in these new tests
> without the series applied.
>
> # of expected passes 1026
> # of unexpected failures 131
>
> Makes me wonder if gdb should start moving towards not flagging a PASS
> for every little supporting operation we have to do to validate
> a particular feature. That would make a PASS mean something is really
> working as opposed to some trivial command that just got executed as
> a sync point.
>
> Anyway...
>
> Tested-By: Luis Machado <luis.machado@arm.com>
> Approved-By: Luis Machado <luis.machado@arm.com>
I've pushed this series. Thanks for testing and the review!
Kevin
prev parent reply other threads:[~2025-04-24 17:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 6:03 Kevin Buettner
2025-04-24 6:03 ` [PATCH v7 01/11] Don't attempt to find TLS address when target has no registers Kevin Buettner
2025-04-24 6:03 ` [PATCH v7 02/11] Allow TLS access to work in gdb.server/no-thread-db.exp Kevin Buettner
2025-04-24 6:03 ` [PATCH v7 03/11] Track and fetch TLS module ids for MUSL and GLIBC Kevin Buettner
2025-04-24 6:03 ` [PATCH v7 04/11] Implement internal TLS address lookup for select Linux targets Kevin Buettner
2025-04-24 6:03 ` [PATCH v7 05/11] Internal TLS support for aarch64, x86_64, riscv, ppc64, and s390x Kevin Buettner
2025-04-24 6:03 ` [PATCH v7 06/11] Internal, but disabled, TLS support for i386 Kevin Buettner
2025-04-24 6:03 ` [PATCH v7 07/11] Delete disabled i386 internal TLS support Kevin Buettner
2025-04-24 6:03 ` [PATCH v7 08/11] New test - gdb.base/tls-nothreads.exp Kevin Buettner
2025-04-24 6:03 ` [PATCH v7 09/11] New test - gdb.base/tls-multiobj.exp Kevin Buettner
2025-04-24 6:03 ` [PATCH v7 10/11] New test - gdb.base/tls-dlobj.exp Kevin Buettner
2025-04-24 6:03 ` [PATCH v7 11/11] Add TLS NEWS entry and document 'set force-internal-tls-address-lookup' command Kevin Buettner
2025-04-24 8:20 ` [PATCH v7 00/11] GDB-internal TLS support for Linux targets Luis Machado
2025-04-24 17:03 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250424100311.104bf428@f41-zbm-amd \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox