From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4by4OScE+2dPtTEAWB0awg (envelope-from ) for ; Sat, 12 Apr 2025 20:24:07 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=jNNaYaSN; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E01BE1E0C3; Sat, 12 Apr 2025 20:24:07 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8F8301E0C0 for ; Sat, 12 Apr 2025 20:24:07 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 13ED23858D35 for ; Sun, 13 Apr 2025 00:24:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 13ED23858D35 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=jNNaYaSN Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id D467F3858CD9 for ; Sun, 13 Apr 2025 00:22:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D467F3858CD9 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D467F3858CD9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1744503738; cv=none; b=eyc89HxqxyUQ+rJ40fBchg5rtHokKGm4aQUgPYU9HFiPwiwRO7xNXr94jEYKpGo0zQFd3WTk7IOtU+s1YrusJxzrCFhDLnZjz7mtCiDQ/oSLWGqmMtSiCHZVIghhWyx6I4YAOb7jASLM8JPW63bASGS2Hs3BTu7Ae5iFmqbqiVk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1744503738; c=relaxed/simple; bh=Wh0ZxPnrZpnG42MMD82N5bSDTxZAYXnPuvXJKI2CM1U=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=izEQT84yXvdo+Pcfu9oPrPvfGIKIIYeNbjJhC50e6bza3HvwSF67s53lz/XFyRgSdZo73hYq+uXTKHrFixOyW+cc9LxJbbghrBWVJArL7HQcUdow8txd0W9d0KUPKvFdI4Hr+9JS/VdGOGY9Ks/yXJx7MdhtWI/77g3bds6B+zU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D467F3858CD9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744503738; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wh0ZxPnrZpnG42MMD82N5bSDTxZAYXnPuvXJKI2CM1U=; b=jNNaYaSNI4TGMW2EF9zHklIhQEzaeByiNsaO4pLqmO+qEVb8BP5oKOJcPecPx5evS3BCm3 O6oNZCUaqhYZLjD6eBlOFObIz3+w70P6+pthL75DNUnZhrpzmxDsdgby5cLu8BEfdg/Toi COrnd4vcdvj2gme34QiZrJ21wMBDHwQ= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-369-DHwpDUyHN7q_G93fdoMDTA-1; Sat, 12 Apr 2025 20:22:17 -0400 X-MC-Unique: DHwpDUyHN7q_G93fdoMDTA-1 X-Mimecast-MFC-AGG-ID: DHwpDUyHN7q_G93fdoMDTA_1744503736 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 60CF5195609E; Sun, 13 Apr 2025 00:22:16 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.80.11]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1DD733001D13; Sun, 13 Apr 2025 00:22:14 +0000 (UTC) Date: Sat, 12 Apr 2025 17:22:09 -0700 From: Kevin Buettner To: Guinevere Larsen Cc: gdb-patches@sourceware.org, Eli Zaretskii Subject: Re: [PATCH v2 1/3] gdb: add convenience variables around linker namespace debugging Message-ID: <20250412172209.009b892c@f41-zbm-amd> In-Reply-To: <20250412164826.508c8143@f41-zbm-amd> References: <20250409204427.1680979-1-guinevere@redhat.com> <20250409204427.1680979-2-guinevere@redhat.com> <20250412164826.508c8143@f41-zbm-amd> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8h3tJx6iWWUxf-ooJA--Wb3OrOXegp8YyavoC9EhBwA_1744503736 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Sat, 12 Apr 2025 16:49:44 -0700 Kevin Buettner wrote: > I found two nits - see below. So... with the nits fixed: Approved-by: Kevin Buettner