From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id B5tSNy7/+mfEsDEAWB0awg (envelope-from ) for ; Sat, 12 Apr 2025 20:02:54 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GhFtBV7w; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CE4601E0C3; Sat, 12 Apr 2025 20:02:54 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 724F61E0C0 for ; Sat, 12 Apr 2025 20:02:54 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F0DEC3858CD9 for ; Sun, 13 Apr 2025 00:02:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F0DEC3858CD9 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GhFtBV7w Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 1934B3858D1E for ; Sun, 13 Apr 2025 00:02:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1934B3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1934B3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1744502542; cv=none; b=QWYwz5TiTWhJG66EbaLuRjN6B2h/kmhmE52CDzm8AH4xdU33lrmRJnF5iRPmnWjb9xZn63xbpwNvR19OG3WkBKGVN4ngpFPbKH4gbiEkg8HGx3GYL0vsD/mZOsj+RVeZwiHxPBgG4hZ6q1feQy9NHcSIuCSx7dnuqTXalLuiMJQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1744502542; c=relaxed/simple; bh=MGehUPLAdDAhjrSzG7S9jW+nCFUwjClgA1zPluH0QEs=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=odirpTd1y91a/cvYrrd2Tk8LDo9vc8oErmj+v74wbK2CTVfpjgRjHq3hRjlBR5qwXDjOSZeDtY4ax84/45lbgRw2ctQHK3IIaXHoo3ZbNX8kwfjEIYE785ssYU1VXZ0DzEEysCZ9H25lKP5PXK1Xsq1E1okixgWFqC7N5t+i+8s= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1934B3858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744502541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KU9EZNnp3491jPjltpVLeLDbBHyQaEga6smsEq3Ajc8=; b=GhFtBV7wsXB7relTYE+3To35Wp1hQ2He018B0lXiSznqj3tQfABFmcR3QbDCTfFgZyZRdh yfsM+sdQPZ2yJRBIDThKPMkor9iujT8PRu+Hf2P/gxaAfrUPCNZ6D2S7jl0JhvQif3A+T7 cOoZ+P/bhQTE3hIOKeva6r1t18GUUHA= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-487-l8bZaLjFO_2v65tIIigdEw-1; Sat, 12 Apr 2025 20:02:20 -0400 X-MC-Unique: l8bZaLjFO_2v65tIIigdEw-1 X-Mimecast-MFC-AGG-ID: l8bZaLjFO_2v65tIIigdEw_1744502539 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CB2ED180034D for ; Sun, 13 Apr 2025 00:02:19 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.80.11]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E55F9180AF7C; Sun, 13 Apr 2025 00:02:18 +0000 (UTC) Date: Sat, 12 Apr 2025 17:02:13 -0700 From: Kevin Buettner To: Guinevere Larsen Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/3] gdb: factor out printing a table of solibs for info sharedlibrary Message-ID: <20250412170213.34855791@f41-zbm-amd> In-Reply-To: <20250409204427.1680979-3-guinevere@redhat.com> References: <20250409204427.1680979-1-guinevere@redhat.com> <20250409204427.1680979-3-guinevere@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1JfSGu10qtJ-gpZs-_Jlh_Xo1UnleSGBNVjvfgUUGv0_1744502539 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Wed, 9 Apr 2025 17:44:26 -0300 Guinevere Larsen wrote: > The next patch will add a new command that will print libraries in a > manner very similar to the existing "info sharedlibrary" command. To > make that patch simpler to review, this commit does the bulk of > refactoring work, since it ends up being a non-trivial diff to review. Thanks for separating it out. > No functional changes are expected after this commit. > --- > gdb/solib.c | 137 ++++++++++++++++++++++++++++------------------------ > 1 file changed, 74 insertions(+), 63 deletions(-) Approved-by: Kevin Buettner