From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gKoKJQDQ7WdUkSQAWB0awg (envelope-from ) for ; Wed, 02 Apr 2025 20:02:08 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=SbUB/hay; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 939EB1E0C3; Wed, 2 Apr 2025 20:02:08 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3B5631E0C0 for ; Wed, 2 Apr 2025 20:02:08 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DCD39385843D for ; Thu, 3 Apr 2025 00:02:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DCD39385843D Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=SbUB/hay Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id ED8333856942 for ; Wed, 2 Apr 2025 23:45:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ED8333856942 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ED8333856942 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743637519; cv=none; b=bMqKFLrdDaOJtXdU6HV2fHCTBxd7ILie5kAG6x3NKc0Ma7vZEjVPAmDIlpq+/586fwhcGr9VAyJLEkqiwZ6pbN8Vxn+wkJMPZhHRzf8KsJ4/Yf29ljQQhL5MyeX/5W5NZB6S4BY5AkZ3Qb6dFVMSJGTeTx5jkfSat7u2mvGQHM4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743637519; c=relaxed/simple; bh=AN96AxwbjLDFu3AiVGreXeuAfMUTiBFghr0iBOItF5Q=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=XtUU239b75WWxlI2bCwqC/M7kYUeoDr/xVWIES/LqpQA7Uq7lwggU/by26nGb86v1oVvXz1RY/UeEvIuvPMJp1QVvdMls6QE+tCai7kTgKQvuVWZhJrp5CCEtcpjNZ4+sOt9o7nfPk9KucWTRL4oVt+8BjM4CV4afnsAGtkxjJs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ED8333856942 Received: from eig-obgw-6002a.ext.cloudfilter.net ([10.0.30.222]) by cmsmtp with ESMTPS id 05Bruva6jiuzS07lmunDp6; Wed, 02 Apr 2025 23:45:18 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 07lmuYz1h1vNy07lmuVSDe; Wed, 02 Apr 2025 23:45:18 +0000 X-Authority-Analysis: v=2.4 cv=VMQWnMPX c=1 sm=1 tr=0 ts=67edcc0e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=ItBw4LHWJt0A:10 a=BDyQ4xKupJWBFD7bsUgA:9 a=QEXdDO2ut3YA:10 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eXgb/KXKQkKcc0xG3kk1DD2mk/dDOMbblG8XW3QquBg=; b=SbUB/hayUXEO59n38DOfOw1u0I TFAWOraqxfVOthQeQwQ22I1nHm54zXtiOqm1oA2Ygcjt4KRcPFM0pqLwHLlMB+MhyOO6mZwerMEeT SxyUx7F1edF1kSWncfDHJyUTy; Received: from 97-122-123-18.hlrn.qwest.net ([97.122.123.18]:56394 helo=prentzel.local) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1u07ll-000000014hd-3XHN; Wed, 02 Apr 2025 17:45:17 -0600 From: Tom Tromey Date: Wed, 02 Apr 2025 17:45:16 -0600 Subject: [PATCH v2 17/28] Remove expand_symtabs_matching MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250402-search-in-psyms-v2-17-ea91704487cb@tromey.com> References: <20250402-search-in-psyms-v2-0-ea91704487cb@tromey.com> In-Reply-To: <20250402-search-in-psyms-v2-0-ea91704487cb@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.2 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.123.18 X-Source-L: No X-Exim-ID: 1u07ll-000000014hd-3XHN X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-123-18.hlrn.qwest.net (prentzel.local) [97.122.123.18]:56394 X-Source-Auth: tom+tromey.com X-Email-Count: 18 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfISDXkTKAU81XvScgbARoGWmWCn0l9EdbYQwzXuC944nitWEsbgcE2m5Im8GhYBE1hgCoRVB485xnx3tmpuI5QqYQaSxVom4VcBISwuSLmSkQnSU06QF netK7qn+zAGftuFmZ6/opb4/wJolVHiVMCkDgGcP5nqmjZeUKBM8xwVVOfPxkPuAd064UYkg+L3Mree/pZVYC9Zvs26AlHkNki0= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org The last caller of the global expand_symtabs_matching function has been changed, so now we can remove this function. --- gdb/symfile.c | 25 ------------------------- gdb/symfile.h | 9 --------- 2 files changed, 34 deletions(-) diff --git a/gdb/symfile.c b/gdb/symfile.c index b0c178a5aeb75c23862d6dd25a9e4bc6235ee231..8e229719b39f6cc4081448e5ec5fa82a0ead691f 100644 --- a/gdb/symfile.c +++ b/gdb/symfile.c @@ -3756,31 +3756,6 @@ symfile_free_objfile (struct objfile *objfile) objfile->pspace ()->remove_target_sections (objfile); } -/* Wrapper around the quick_symbol_functions expand_symtabs_matching "method". - Expand all symtabs that match the specified criteria. - See quick_symbol_functions.expand_symtabs_matching for details. */ - -bool -expand_symtabs_matching (expand_symtabs_file_matcher file_matcher, - const lookup_name_info &lookup_name, - expand_symtabs_symbol_matcher symbol_matcher, - expand_symtabs_expansion_listener expansion_notify, - block_search_flags search_flags, - domain_search_flags domain, - expand_symtabs_lang_matcher lang_matcher) -{ - for (objfile *objfile : current_program_space->objfiles ()) - if (!objfile->expand_symtabs_matching (file_matcher, - &lookup_name, - symbol_matcher, - expansion_notify, - search_flags, - domain, - lang_matcher)) - return false; - return true; -} - /* Wrapper around the quick_symbol_functions map_symbol_filenames "method". Map function FUN over every file. See quick_symbol_functions.map_symbol_filenames for details. */ diff --git a/gdb/symfile.h b/gdb/symfile.h index c2e5142c045dab72fad9d73abd259813f9caef1e..e72030f5f0e1e5e0b094d288e4a81c58264222b8 100644 --- a/gdb/symfile.h +++ b/gdb/symfile.h @@ -345,15 +345,6 @@ symfile_segment_data_up get_symfile_segment_data (bfd *abfd); extern scoped_restore_tmpl increment_reading_symtab (void); -bool expand_symtabs_matching - (expand_symtabs_file_matcher file_matcher, - const lookup_name_info &lookup_name, - expand_symtabs_symbol_matcher symbol_matcher, - expand_symtabs_expansion_listener expansion_notify, - block_search_flags search_flags, - domain_search_flags kind, - expand_symtabs_lang_matcher lang_matcher = nullptr); - void map_symbol_filenames (symbol_filename_listener fun, bool need_fullname); /* Target-agnostic function to load the sections of an executable into memory. -- 2.46.1