From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IWAMDdTM2GeQWRMAWB0awg (envelope-from ) for ; Mon, 17 Mar 2025 21:31:00 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Fs1J/Ipt; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 24FB41E100; Mon, 17 Mar 2025 21:31:00 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9AF1A1E05C for ; Mon, 17 Mar 2025 21:30:59 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 398103857C5D for ; Tue, 18 Mar 2025 01:30:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 398103857C5D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Fs1J/Ipt Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 315373858CDA for ; Tue, 18 Mar 2025 01:30:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 315373858CDA Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 315373858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742261430; cv=none; b=EJl29Tn4lWrM2RfjzlHPncJmTVleDFrpOC4BHndNdWqvxVohbQ2mVYsdd1vUUWr0+bMzOGtl+mA1YK0bm5nUFUC0Et5f/LxjBXLx2xQAqhTHoXAB3wNslJHq7Ov6D1dRx1CTkPvJOdx8q3TSYSdMd4iXPF5A7SFOp61FoiiTIL8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742261430; c=relaxed/simple; bh=Lqo2Tsbv44PbdAaV8/SKig1Sw5H6+wtfF0mukgwS0ig=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=SyI4J3nJNylu6mwY1BvtatNqsmZ+LsUUsbLiAk1gbA+XZW39ziZqUCWeqxTEr26AEXpZ9wOtDFBws1QE3TNdAjO11D+TFJ1DjkOROtc6LoZgxmI2KqqkwKK79eBnyW9fJZ93g83vvtIsaQUHkmQG8mVLtnSxs3JczdQdO1EB96c= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 315373858CDA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742261429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3hwdC20PgRRfqNN0D8r6ybrg3u++DW3elKHyJuo8xH8=; b=Fs1J/IptfRoF6ef2Htzmpl+C59Hnvs6cZ5XcXgBCJg9gGCYOI8ektrkt0NqtMyHeHGbR9W WtSRp3ocs3NmF8YfGERMPIIvpmB9qNWsYGSe2/yYbq0BKoR+woiwupm1tF9m+5M0vimua+ Qv8vi1Tp2I00sOThz/L/HwwXkxVNdYM= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622--KCq1APHP5GE40JPDrpUjg-1; Mon, 17 Mar 2025 21:30:28 -0400 X-MC-Unique: -KCq1APHP5GE40JPDrpUjg-1 X-Mimecast-MFC-AGG-ID: -KCq1APHP5GE40JPDrpUjg_1742261427 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8F3841956048; Tue, 18 Mar 2025 01:30:27 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.88.7]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 70DAD1956095; Tue, 18 Mar 2025 01:30:26 +0000 (UTC) Date: Mon, 17 Mar 2025 18:30:21 -0700 From: Kevin Buettner To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Use scoped_fd in linux-nat.c:proc_mem_file Message-ID: <20250317183021.19c404d6@f41-zbm-amd> In-Reply-To: <20250317205529.3885971-1-tom@tromey.com> References: <20250317205529.3885971-1-tom@tromey.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: EK8IMU6CA1htXP9DI7FfSsPCB8XhT7mbxB8xGKoqk9Y_1742261427 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Mon, 17 Mar 2025 14:55:29 -0600 Tom Tromey wrote: > This changes linux-nat.c:proc_mem_file to use a scoped_fd and fixes up > the users. Regression tested on x86-64 Fedora 40. LGTM. Approved-by: Kevin Buettner