From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id dkxvKUXr1GfNzQ8AWB0awg (envelope-from ) for ; Fri, 14 Mar 2025 22:51:49 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SY+Jq32v; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9A9A71E105; Fri, 14 Mar 2025 22:51:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6EFFD1E05C for ; Fri, 14 Mar 2025 22:51:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3C2F93857BBF for ; Sat, 15 Mar 2025 02:51:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3C2F93857BBF Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SY+Jq32v Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 11F523858C48 for ; Sat, 15 Mar 2025 02:51:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 11F523858C48 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 11F523858C48 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742007077; cv=none; b=cbMZ2dP4+OUxiBskClqshy1CbHMynxZFqMyAXaimKZqM4tq1xVfvWOZ/sMME69C9bkvMLPSZGkXtbOb+w1aORuQ63tbSI4A52InuHJfcEp1j7DIJH81pTkXu7i5TBSFsnGc645d3shblVl9tIJLHpVVB5xDywxnbOQz0EGD02s8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742007077; c=relaxed/simple; bh=v/WvJpH5R2O2vvA2/PN3IUb2i/Oskoo86fTwsf75+Vs=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=T74GjcRoLw/0f5CfLVe6cMe+oOMgSDHE1Ai04lyK9iNUNlmh7pEwYXedOO/J0MWpZTWy4xeFOOcgcgQw1/xhD06y3QAiMNnC/zfkh6X+Xr8slAdrmyHd4VuXfJG3uKL9aoddFv5mKPPLqW2f4MEJc0ePGi+xPkfGO1JGLfwAYrU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 11F523858C48 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742007076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=78/QLuDp72K0kIc1mAGrW2Xbuo2EQ8Sd0N7xfy/rlHg=; b=SY+Jq32vJFv8HBSz8wTtACkQk5vka3LHldXBeZUW/uVA0wTnchC6VrTCr6uSTEIFynlVR/ /JX+HvdCkQfsNIazG7O99v+y7VKeN1b1UblNAANYyDmVNT+A5S4CpCvS+ZqK6TGevmntJ3 ZMXkYOKVKZkA3BINlrb6oqpsqxwnlvM= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-154-T_dyeFxtMim8jXbgwUgZEg-1; Fri, 14 Mar 2025 22:51:15 -0400 X-MC-Unique: T_dyeFxtMim8jXbgwUgZEg-1 X-Mimecast-MFC-AGG-ID: T_dyeFxtMim8jXbgwUgZEg_1742007074 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B076C19560B4 for ; Sat, 15 Mar 2025 02:51:14 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.88.7]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DA3811801759; Sat, 15 Mar 2025 02:51:13 +0000 (UTC) Date: Fri, 14 Mar 2025 19:51:08 -0700 From: Kevin Buettner To: Guinevere Larsen Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: Introduce user-friendly namespace identifier for "info shared" Message-ID: <20250314195108.2c4891a9@f41-zbm-amd> In-Reply-To: <20250313170004.3362207-2-guinevere@redhat.com> References: <20250313170004.3362207-2-guinevere@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: sxRlb0Uzq9u1fEQwit-lM3omRRxpD-ewwz0m0juSoW0_1742007074 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Gwen, First, I'll note that I ran into a conflict in gdb/NEWS when applying this commit when using "git am". (It was easy to fix though.) On Thu, 13 Mar 2025 14:00:05 -0300 Guinevere Larsen wrote: > Finally, a new solib_ops function pointer was added, find_solib_ns, to > allow code outside of solib-svr4 to find and use the namespace > identifiers. As a sanity check, the command `info sharedlibraries` has > been changed to display the namespace identifier. Plus, a couple of tests > had to be tweaked to handle the possible new column. I applied the patch, built GDB, and ran the tests. But I didn't see the new NS column in any of the "info shared"/"info sharedlibrary" output. Should I have seen this column? (I.e, did I do something wrong?) Assuming that I didn't mess up, I think it'd be good to add some tests which show the new column. Kevin