From: Kevin Buettner <kevinb@redhat.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org, Tom de Vries <tdevries@suse.de>
Subject: Re: [RFC] gdb: block SIGTERM during fetch_inferior_event
Date: Sun, 9 Mar 2025 00:38:17 -0700 [thread overview]
Message-ID: <20250309003633.6969aa6a@f41-zbm-amd> (raw)
In-Reply-To: <bfbcc5496e653b77263c475dc36608513ca31cbe.1740655494.git.aburgess@redhat.com>
Hi Andrew,
On Thu, 27 Feb 2025 11:31:02 +0000
Andrew Burgess <aburgess@redhat.com> wrote:
> What I have here is different than any of the previous approaches
> posted, but I'm still not entirely sure this is the right solution,
> but I thought I'd share it. Might be nice to see if we can get this
> fixed.
>
> The patch might still need some cleanup, but it should be good enough
> to discuss this approach.
I've looked at your approach, plus the discussion surrounding earlier
attempts to fix this problem. What I find really compelling is
this observation in your commit log...
> But I think everything that is written in the comments in
> fetch_inferior_event can also apply to gdb_exception_forced_quit. So
> we should be blocking that too.
I agree with this observation, and, therefore, I think your approach
makes sense.
Kevin
prev parent reply other threads:[~2025-03-09 7:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 11:31 Andrew Burgess
2025-03-09 7:38 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250309003633.6969aa6a@f41-zbm-amd \
--to=kevinb@redhat.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox