From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0VCmBa5ntmelyTYAWB0awg (envelope-from ) for ; Wed, 19 Feb 2025 18:22:22 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Td7tJ7Ce; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 014041E105; Wed, 19 Feb 2025 18:22:21 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 98A9C1E08E for ; Wed, 19 Feb 2025 18:22:20 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2A77E385840E for ; Wed, 19 Feb 2025 23:22:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2A77E385840E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Td7tJ7Ce Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id BEFA43858C50 for ; Wed, 19 Feb 2025 23:21:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BEFA43858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BEFA43858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1740007292; cv=none; b=RbHeiC4s/VVC2aGU9AN+BWEszWgvEtJyig4KPaGVNUs0XM/Pkf0DW2uZ2vyY1FqZUN4x6kW5J9NAcjlrL4Kwx4pX3KxeDkpB7a3g9kuE4dZzPK3XHvn40aJjyjZD8E85+a8rfOF7IxO5XQkd3SIRbh9PPnwN0xcgjkBcfYIoH/8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1740007292; c=relaxed/simple; bh=Yq+jWGJYcu3uiQLxqT/KWDB10eR8gCgenGxKQ3CfVBk=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=F74a0aYaxoGUf5P3K8bx+bRo7KRzG5gky5j9pJst7xkASXgmSUbFKCaC1WqronaEVKvD66smCXW0/Bovrzd/Y65+O+kLvpSc5e7pliwYFan3y+zl6nSlB3ImOM2z58tIwBsoTGtVyounwGlHsV34dTlZ4P+if6SURD9bKLxk/V0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BEFA43858C50 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740007292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8K7My9ebuCGd7hWnoTA0wUn1aC9v0PnDEVX25n/4Ur4=; b=Td7tJ7CePchzZTPg8EP6J6Jy7+ZcN9H30AbGYwuEkSYWEj8qh4lmI99yG52nu8TgeFVlDk AxEiTYf5V6nbjiHiAbxMK+UCSK/qBura0xUvO3/IMKryeujVdmA3BXGeYwpTkqsDMlAFni LVIMrvf9bUgDpolQrsa/qv0VoTTcfiY= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-493-2oLLdHw3MDuKNuQRkSZedw-1; Wed, 19 Feb 2025 18:21:28 -0500 X-MC-Unique: 2oLLdHw3MDuKNuQRkSZedw-1 X-Mimecast-MFC-AGG-ID: 2oLLdHw3MDuKNuQRkSZedw_1740007288 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DD2861800268; Wed, 19 Feb 2025 23:21:27 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.81.226]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0A9F91800352; Wed, 19 Feb 2025 23:21:26 +0000 (UTC) Date: Wed, 19 Feb 2025 16:21:24 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Milica Matic Subject: Re: [PATCH v12 1/2] Apply coding guidelines Message-ID: <20250219162124.62880782@f41-zbm-amd> In-Reply-To: <20250219130125.356900-3-milica.matic@htecgroup.com> References: <20250219130125.356900-1-milica.matic@htecgroup.com> <20250219130125.356900-3-milica.matic@htecgroup.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: fW88y0tP2PnEtYKq0mLMMoS0K48KHenaBY-GXoQGGDQ_1740007288 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Wed, 19 Feb 2025 13:01:37 +0000 Milica Matic wrote: > Format mips-tdep.c code as described on links: > https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards > https://www.gnu.org/prep/standards/standards.html#Comments > --- > gdb/mips-tdep.c | 395 +++++++++++++++++++++++++++--------------------- > 1 file changed, 221 insertions(+), 174 deletions(-) This is okay. Approved-by: Kevin Buettner