From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id fFHpNuRls2eWezQAWB0awg (envelope-from ) for ; Mon, 17 Feb 2025 11:37:56 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=gvGumTD1; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=uWDOqAQh; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=gvGumTD1; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=uWDOqAQh; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CBE391E105; Mon, 17 Feb 2025 11:37:56 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E286B1E05C for ; Mon, 17 Feb 2025 11:37:55 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 75449385840E for ; Mon, 17 Feb 2025 16:37:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 75449385840E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=gvGumTD1; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=uWDOqAQh; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=gvGumTD1; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=uWDOqAQh Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 820863858D21 for ; Mon, 17 Feb 2025 16:36:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 820863858D21 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 820863858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739810177; cv=none; b=efhj69JsEItXXT/WgQVGm++jqsUhW4Fv7lhQ3nueSSTuDmmvc0D3hwUw6Y9m345+WZluZw2mdrHTEGxLg9O5drSZCZHNx8NcLEEIBxUee4YZ4i7fFD3uCUZxABtznvjlHoId66rRgY7UbVTfFyddGRDDZH/eT4pJ15z83J3w7j8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739810177; c=relaxed/simple; bh=alFlWSKJC6NrX9EfzT6GkliLRhHmsaFWNKLD+s3nO3c=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=keHLu4Gnxf5sl0ZaUGS53D/Fm6qNptsHMmYVwhdZB5Z2gJp364pmiuTB6LmgpQj/FB+VWqb9dN9FJTKiNFQ27SmEzUmYmjzpcS/jj7FwX/5RndYLVsLHNxXrIeESlQ1YB91BjbadZxUEJCG2+llIvtr504QKC9l2PRGy9zgZVVY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 820863858D21 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 73D4D21179 for ; Mon, 17 Feb 2025 16:36:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1739810176; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PkIt9ZN5BPPrtMtaImj5qA/W5vvBD0qMBLf7VrtfUOA=; b=gvGumTD1G0MQdJEk37me+VJyntWW211grKeyEyKaJoDWykvsktMVw8oHBW8SWsxSKNEIsn HH/cnkULFzXQLOFm4rVQM8mPx2/mMZ7lZhRSZEU9asBEFiermcKL5EYNLUR17Bdlc5pPCy 0iDAnxDxi3kn29RFStIykFrFuLPuW7w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1739810176; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PkIt9ZN5BPPrtMtaImj5qA/W5vvBD0qMBLf7VrtfUOA=; b=uWDOqAQh5n2ZRsbS9FbSz8JMhm1axhIdRAfPrDUONoOJhXlUqcFNv2mf6IpauTMv65zWj9 P/aV86U0sNSUhHDQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gvGumTD1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=uWDOqAQh DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1739810176; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PkIt9ZN5BPPrtMtaImj5qA/W5vvBD0qMBLf7VrtfUOA=; b=gvGumTD1G0MQdJEk37me+VJyntWW211grKeyEyKaJoDWykvsktMVw8oHBW8SWsxSKNEIsn HH/cnkULFzXQLOFm4rVQM8mPx2/mMZ7lZhRSZEU9asBEFiermcKL5EYNLUR17Bdlc5pPCy 0iDAnxDxi3kn29RFStIykFrFuLPuW7w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1739810176; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PkIt9ZN5BPPrtMtaImj5qA/W5vvBD0qMBLf7VrtfUOA=; b=uWDOqAQh5n2ZRsbS9FbSz8JMhm1axhIdRAfPrDUONoOJhXlUqcFNv2mf6IpauTMv65zWj9 P/aV86U0sNSUhHDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 55E2D133F9 for ; Mon, 17 Feb 2025 16:36:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id YB2/E4Bls2eBUAAAD6G6ig (envelope-from ) for ; Mon, 17 Feb 2025 16:36:16 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 1/3] [gdb/testsuite] Don't start gdb in gdb.base/gstack.exp Date: Mon, 17 Feb 2025 17:36:17 +0100 Message-ID: <20250217163619.8662-2-tdevries@suse.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250217163619.8662-1-tdevries@suse.de> References: <20250217163619.8662-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 73D4D21179 X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_NONE(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim, suse.de:mid, imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org In test-case gdb.base/gstack.exp we start a gdb implicitly using prepare_for_testing. The gdb is not really used, but its spawn_id (available in variable gdb_spawn_id) is used in a gdb_test_multiple, which is used to interact with the gstack process. Usually, a running gdb is cleaned up at test-case exit in gdb_finish, which calls gdb_exit, which by default calls gdb_default_exit, which does 'send_gdb "quit\n"'. However, this sends a quit to the host process expect is currently talking to, defined by board_info(host,fileid), and after spawning gstack that's gstack, not gdb. Fix this by: - using build_executable instead of prepare_for_testing to not spawn an unused gdb, and - changing the gdb_test_multiple into a gdb_expect, eliminating the implicit use of gdb_spawn_id. Tested on x86_64-linux. PR testsuite/32709 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32709 --- gdb/testsuite/gdb.base/gstack.exp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.base/gstack.exp b/gdb/testsuite/gdb.base/gstack.exp index f603f2b4ea3..8df36b1b3bc 100644 --- a/gdb/testsuite/gdb.base/gstack.exp +++ b/gdb/testsuite/gdb.base/gstack.exp @@ -18,7 +18,7 @@ require can_spawn_for_attach standard_testfile -if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug}] == -1} { +if {[build_executable "failed to prepare" $testfile $srcfile {debug}] == -1} { return -1 } @@ -62,7 +62,7 @@ if { ![gdb_assert { ![expr {$res < 0 || $res == ""}] } $test] } { set test "got backtrace" set saw_backtrace false set no_awk false -gdb_test_multiple "" $test { +gdb_expect { -i "$res" -re "#0 +(0x\[0-9a-f\]+ in )?main \(\).*\r\nGSTACK-END\r\n\$" { set saw_backtrace true pass $test -- 2.43.0