From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Q1pKG1XKoGecJyMAWB0awg (envelope-from ) for ; Mon, 03 Feb 2025 08:53:25 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=JyisGECD; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 60C201E105; Mon, 3 Feb 2025 08:53:25 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3A9C01E08E for ; Mon, 3 Feb 2025 08:53:24 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 516E13858415 for ; Mon, 3 Feb 2025 13:53:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 516E13858415 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=JyisGECD Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by sourceware.org (Postfix) with ESMTPS id 1A7813858C50 for ; Mon, 3 Feb 2025 13:52:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1A7813858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1A7813858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738590773; cv=none; b=P1X5p5dly1Utg5sT8TwdFbb8xwjT3QUU7e5HBF08EIfIQfKJbnAOIswuZFTLqI+56tWN/ho+csvjQ4qDM64pINDiCtZNNYQ9KtZiz41TxFcbWQhFMa6c1FExOTYdhn9dLyM63Sr6/H5fm2dt2bEiFh6klUIVoP9nTRPzz8UvFlw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738590773; c=relaxed/simple; bh=SZf4nQr7v7nUOyYiJbigb1muMPbDHBNEYixCQ00vZVk=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=Me7tKmIxEZg4uQFJYwUh6TwKCJaaQ9SEBW9ok0jxQ+vegXsTwzVQQPE9xl+VWs8yoebeWga+QKKnZ+4X6lbftrwzPmUa6AM6ZtPeypOAM/5taVUFRY7ohjxqd5meMgJIdLdz6kdsuOOnjX5s1cS8kWLVGbQa0VI9V79lM0kRiEg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1A7813858C50 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1738590773; x=1770126773; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=SZf4nQr7v7nUOyYiJbigb1muMPbDHBNEYixCQ00vZVk=; b=JyisGECDuaoLYh08r/mYgz2Twfg4MHwHW/Xgt4uZnnpXP2y7RB2gDyPS w49CspxO5abzg0xBd6kPQXaTG/2ZlMujp35o2e+G6LVkSYsu2cwwce3lW kYbmO06HRauHjaSikNtrD5248lF8xt/yhc5b9oasinOZalpiBSblcKDQ1 4TTA55+cHVeKz9ngv/my4Rjt89c8+2l7nBIRo3rihb1pmsOe2dTwHo1Tb xGIonl7RrF4mVxVdRNyshoOS/f3Yoc4MwZJnR2Awddh24U5Eq4YyuC/c5 iR1AgMQoHyghb2++yJnI9Kgt67CjWvSawEuptyB3amVXGBepKWQGBD4zo Q==; X-CSE-ConnectionGUID: QmHacFjfQQSgHPLry7tayg== X-CSE-MsgGUID: GFXSu5A3RDeh8VMCngG4Cg== X-IronPort-AV: E=McAfee;i="6700,10204,11335"; a="43006887" X-IronPort-AV: E=Sophos;i="6.13,255,1732608000"; d="scan'208";a="43006887" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2025 05:52:52 -0800 X-CSE-ConnectionGUID: 5ac7asJ+RPGogcV2nV1hVw== X-CSE-MsgGUID: egjIyqisS0Gda2288y8Z3A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,255,1732608000"; d="scan'208";a="110246253" Received: from dut1503dg2frd.igk.intel.com (HELO localhost) ([10.102.47.149]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2025 05:52:51 -0800 From: Klaus Gerlicher To: gdb-patches@sourceware.org, luis.machado@arm.com Subject: [PATCH 1/1] aarch64: fix a crash during maintenance print cooked-registers Date: Mon, 3 Feb 2025 13:52:40 +0000 Message-Id: <20250203135240.1030561-1-klaus.gerlicher@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi all, Luis, I found this accidently while looking at Thiago's GDBserver improvements. Luis I think added the pseudo register in question, so maybe he can comment on this issue. I used a aarch64 qemu 9.2. Thanks Klaus On aarch64 with pauth enabled I can see a crash when using "maintenance print cooked-registers". This happens because the register dump code tries to read a pseudo reg that is not handled here because it is supposedly only used in unwinding. Fix this by returning a zero value typed as a built-in uint64. --- gdb/aarch64-tdep.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c index 840f9877361..6e712b12b86 100644 --- a/gdb/aarch64-tdep.c +++ b/gdb/aarch64-tdep.c @@ -3290,6 +3290,9 @@ aarch64_pseudo_read_value (gdbarch *gdbarch, const frame_info_ptr &next_frame, return aarch64_pseudo_read_value_1 (next_frame, pseudo_reg_num, pseudo_offset - AARCH64_SVE_V0_REGNUM); + if (tdep->has_pauth () && pseudo_reg_num == tdep->ra_sign_state_regnum) + return value::zero (builtin_type (gdbarch)->builtin_uint64, lval_register); + gdb_assert_not_reached ("regnum out of bound"); } -- 2.34.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928