From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UCz8MQwVnWcvdiAAWB0awg (envelope-from ) for ; Fri, 31 Jan 2025 13:23:08 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Eq7FUmds; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C95351E105; Fri, 31 Jan 2025 13:23:08 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 51ECE1E08E for ; Fri, 31 Jan 2025 13:23:08 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ECC12385783B for ; Fri, 31 Jan 2025 18:23:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ECC12385783B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Eq7FUmds Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id E68FE3858C66 for ; Fri, 31 Jan 2025 17:49:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E68FE3858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E68FE3858C66 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738345770; cv=none; b=pbknnC4i5tA6nA84GleSpoji1b40cxRr6wuH1TMIjSZ7PruSPsl3PCDn9aFmh+jQ9TiLoS71bsVEbV4+1Xl7KsEhVcbaVROWuZqlREQ31OYyLkKchuZaTI6LNYHAecurp9Gl058qdZHvG7SLKJ/jMJk+sEC0kMHe9fsoBH/UYL8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738345770; c=relaxed/simple; bh=OVw6AJzhJwzHX1NhUTVlM+kDGx/ihE9ryIZ84y6WbBE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=vV2qZMCTrheiMEDr5Z6c3ZO0o9x5+ceq0wq/gFlo5pZCWvxbnw0S7xNz6jmq6XV/KKCokZPxV3Yjq83+SNcG+qR5bJ3g9Zk95Z0uvg+kaJH0GC89fMiA+O/PuyRJT08RsB1Oih3elw8jfhKKvwaLZOHtlt3lSb0Pk1I1+ucx4AU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E68FE3858C66 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738345764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=47SeA4qsiJWuUDU+LKiXfwGXjrtx3f5ZnxcwDoj/MiM=; b=Eq7FUmdsSl2On7DQfF3nldfK2tBy2jwufgxb7JpTRlG3LF+DY5a0TFdKcb+e9jiLImPB3c 6ULSoEfyQZSBYl88oXavaevlzFFv9YDEa21HKpeqDARUi6gFzQ6C/eU3FVJ2aKlTIA7mBU p85slVYrLaMa/VTH9aqN5qvmAvljYVA= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-281-0MHbPtVkMTKES22X1lHHpQ-1; Fri, 31 Jan 2025 12:49:21 -0500 X-MC-Unique: 0MHbPtVkMTKES22X1lHHpQ-1 X-Mimecast-MFC-AGG-ID: 0MHbPtVkMTKES22X1lHHpQ Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AA0B51955DCB; Fri, 31 Jan 2025 17:49:20 +0000 (UTC) Received: from f41-1.lan (unknown [10.22.64.223]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A6955180142F; Fri, 31 Jan 2025 17:49:19 +0000 (UTC) From: Kevin Buettner To: gdb-patches@sourceware.org Cc: tom@tromey.com, Kevin Buettner Subject: [PATCH v5 06/11] Internal, but disabled, TLS support for i386 Date: Fri, 31 Jan 2025 10:45:29 -0700 Message-ID: <20250131174747.921323-8-kevinb@redhat.com> In-Reply-To: <20250131174747.921323-2-kevinb@redhat.com> References: <20250131174747.921323-2-kevinb@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: H-s1DXPbLux75srh021F_sTa_Ah-PV5zR3DinL8FZXs_1738345760 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This commit shows how internal TLS address lookup support could be implemented for the i386 target. Unfortunately, it doesn't work due to I386_GSBASE_REGNUM being unavailable for Linux targets. I looked at trying to access the gsbase register via PTRACE_GET_THREAD_AREA, but did not understand it well enough to finish it. Since the i386 target is much less important than it used to be, I gave up working on it. I don't want to leave this disabled code in our sources, so I will delete it in the next commit, however, this commit will be in our git repo, so it'll be available for someone with sufficient interest in the i386 target to look at. --- gdb/i386-linux-tdep.c | 44 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/gdb/i386-linux-tdep.c b/gdb/i386-linux-tdep.c index 9dec83ac753..8e9ffe984a3 100644 --- a/gdb/i386-linux-tdep.c +++ b/gdb/i386-linux-tdep.c @@ -753,6 +753,45 @@ i386_linux_displaced_step_copy_insn (struct gdbarch *gdbarch, return closure_; } +#if 0 +/* Disabled because fetching I386_GSBASE_REGNUM causes an internal + error. */ + +/* Fetch and return the TLS DTV (dynamic thread vector) address for PTID. + Throw a suitable TLS error if something goes wrong. */ + +static CORE_ADDR +i386_linux_get_tls_dtv_addr (struct gdbarch *gdbarch, ptid_t ptid, + enum linux_libc libc) +{ + /* On i386, the thread pointer is found in the gsbase register. */ + regcache *regcache + = get_thread_arch_regcache (current_inferior (), ptid, gdbarch); + target_fetch_registers (regcache, I386_GSBASE_REGNUM); + ULONGEST gsbase; + if (regcache->cooked_read (I386_GSBASE_REGNUM, &gsbase) != REG_VALID) + throw_error (TLS_GENERIC_ERROR, _("Unable to fetch thread pointer")); + + /* The thread pointer (gsbase) points at the TCB (thread control + block). The first two members of this struct are both pointers, + where the first will be a pointer to the TCB (i.e. it points at + itself) and the second will be a pointer to the DTV (dynamic + thread vector). There are many other fields too, but the one + we care about here is the DTV pointer. Compute the address + of the DTV pointer, fetch it, and convert it to an address. */ + CORE_ADDR dtv_ptr_addr + = gsbase + gdbarch_ptr_bit (gdbarch) / TARGET_CHAR_BIT; + gdb_byte buf[gdbarch_ptr_bit (gdbarch) / TARGET_CHAR_BIT]; + if (target_read_memory (dtv_ptr_addr, buf, sizeof buf) != 0) + throw_error (TLS_GENERIC_ERROR, _("Unable to fetch DTV address")); + + const struct builtin_type *builtin = builtin_type (gdbarch); + CORE_ADDR dtv_addr = gdbarch_pointer_to_address + (gdbarch, builtin->builtin_data_ptr, buf); + return dtv_addr; +} +#endif + static void i386_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) { @@ -988,6 +1027,11 @@ i386_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) /* Enable TLS support. */ set_gdbarch_fetch_tls_load_module_address (gdbarch, svr4_fetch_objfile_link_map); +#if 0 + set_gdbarch_get_thread_local_address (gdbarch, + linux_get_thread_local_address); + linux_register_tls_methods (info, gdbarch, i386_linux_get_tls_dtv_addr); +#endif /* Core file support. */ set_gdbarch_iterate_over_regset_sections -- 2.48.0