Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: Guinevere Larsen <guinevere@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/configure: fail configure if all targets requested with 32bit bfd
Date: Mon, 27 Jan 2025 18:11:57 -0700	[thread overview]
Message-ID: <20250127181157.792d1d9e@f41-zbm-amd> (raw)
In-Reply-To: <20250123201338.158819-2-guinevere@redhat.com>

On Thu, 23 Jan 2025 17:13:39 -0300
Guinevere Larsen <guinevere@redhat.com> wrote:

> As PR sim/28684 explains, it isn't possible to compile GDB with all
> targets enabled and not enabling 64 bit bfd. In 64 bit hosts, 64 bit bfd
> is forced, so the build works, but in 32 bit hosts, that has to be
> explicitly enabled.
> 
> I ran into this when I tried compiling GDB on a mips64 machine running a
> 32 bit OS. Along with the errors in the PR, several other architectures
> are also required, notably aarch64 and other explicitly 64bit targets.
> Additionally, some 32 bit files required for the gdb mips target aren't
> added to the makefile.
> 
> Considering the last comment in the bug says this isn't going to be
> fixed on the binutils side, I didn't think it was worth trying to fix
> the GDB side. Instead, this commit causes the configure script to fail
> if all targets were requested and 64 bit bfd isn't enabled. If that is
> ever fixed, we can revert this commit.
> 
> I considered adding this to the top level configure script, but couldn't
> figure out how to detect the situation in there, so this was my next
> best idea.
> 
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28684

Sounds like the right approach to me...

Approved-by: Kevin Buettner <kevinb@redhat.com>


  reply	other threads:[~2025-01-28  1:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-23 20:13 Guinevere Larsen
2025-01-28  1:11 ` Kevin Buettner [this message]
2025-01-28 12:07   ` Guinevere Larsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250127181157.792d1d9e@f41-zbm-amd \
    --to=kevinb@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=guinevere@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox