From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KQc+N+Enh2d/eQ8AWB0awg (envelope-from ) for ; Tue, 14 Jan 2025 22:13:37 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=F0TSBBpM; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D42051E100; Tue, 14 Jan 2025 22:13:37 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AFCB41E08E for ; Tue, 14 Jan 2025 22:13:36 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 36739385C6E3 for ; Wed, 15 Jan 2025 03:13:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 36739385C6E3 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=F0TSBBpM Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 298A4385C6CF for ; Wed, 15 Jan 2025 03:13:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 298A4385C6CF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 298A4385C6CF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736910784; cv=none; b=Lwq0Y/N0vQ1m5X3DZmwKiON3Ymtd122CYgJUFZwrEhFHq6+Djathi4VDLOk+XS67vAkrU1pKDzdmYNxTp8FjUzhhMJ00vJuZRsSgigX5B8z71Zkujuy4MRknPLDsji+2SKxFjEYj4D+H71PWaNK4QvGi9enRS0oaw6zmi6aX/gE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736910784; c=relaxed/simple; bh=IMkhjlcmaBtx8gkiGFdekG1eDlJMs7T6NXqNpP2JgtY=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=ppG23nGmUcHdQopG1l82aZA1u87oA20cwng1d96+L7qJ9e7zUnOMDz7elRIC1GR5VDt1k5MelRBNOG6/EewfpP0S4N9UmbtCgL6IRt6iEKes1KTMLquPtZ0yR9UVgcgk3cv7S8gGvchyvoseWsArOADm/IEhIAotkVPpw1D5KXw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 298A4385C6CF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736910783; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bMSk3zOUFBE3lYe2zW91GbzwcqUax6Vxp3fDoFVf2nU=; b=F0TSBBpMnWguMLAxoaFUMDFq8vIhYLipmcxnX7w0MwtKrKvsrluSqG/24J2+V2Zbjm2fjc b0QbS78N2E/K0h/g11KTMO/MWiyhx0i1GObyK/o75n+0Ups3ACEIeHwW/R+9H3sLniPBnt ZH7Ebf0pDPJ2w3qAIpfsJDS0/ahId2w= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-472-QtdvJrSNNrKIIUWqNZQM8A-1; Tue, 14 Jan 2025 21:09:38 -0500 X-MC-Unique: QtdvJrSNNrKIIUWqNZQM8A-1 X-Mimecast-MFC-AGG-ID: QtdvJrSNNrKIIUWqNZQM8A Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 58C981956053; Wed, 15 Jan 2025 02:09:37 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.80.94]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7410B19560AA; Wed, 15 Jan 2025 02:09:36 +0000 (UTC) Date: Tue, 14 Jan 2025 19:09:31 -0700 From: Kevin Buettner To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix help formatting for string and filename options Message-ID: <20250114190931.5a4b2f8d@f41-zbm-amd> In-Reply-To: <20250113143349.198028-1-tromey@adacore.com> References: <20250113143349.198028-1-tromey@adacore.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Luq5uJyq3vUyUe37cxS85x4zrn8SCBWp4Stq8PjEJ_k_1736906977 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Mon, 13 Jan 2025 07:33:49 -0700 Tom Tromey wrote: > I happened to notice that "help add-inferior" said: > > -execFILENAME > FILENAME is the file name of the executable to use as the > main program. > > This is missing a space after "-exec". This patch fixes the bug. > > If ok'd on time I plan to check this in to the gdb-16 branch as well. LGTM. Approved-by: Kevin Buettner