From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YHatFyRcXGdfeRUAWB0awg (envelope-from ) for ; Fri, 13 Dec 2024 11:09:08 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=eWOABIu4; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5CC631E097; Fri, 13 Dec 2024 11:09:08 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D33FC1E091 for ; Fri, 13 Dec 2024 11:09:07 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8B8383858403 for ; Fri, 13 Dec 2024 16:08:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8B8383858403 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=eWOABIu4 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by sourceware.org (Postfix) with ESMTPS id 669E53858404 for ; Fri, 13 Dec 2024 15:58:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 669E53858404 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 669E53858404 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::531 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734105489; cv=none; b=gcbjqrAYa81qfvNqMxAYZhXz1sZ9rbapl7FW8z8VQ2hBWMd7MW8f5npb4FKz12AkEnWXzbdl4tFSBnOpCkJh31pIwLiyPU+WLj9XNAHesGxzwBbuePbzIDRYtLUvz7FQaLvCBl0ASvaEbw+rWW8jdWD6s52qzMy9cdwzfKRb8i4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734105489; c=relaxed/simple; bh=j9FKb6BU4/znc+8CRHrYZSPV8fXKw5l1Sc9yD9jU/0s=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=De5/Bjen9v4RghKeuE/yA9eF8sIlM5w5v15qYvS77vAI872TJi368wv1Lv8SkZfd7rAEWCr1ZGwQWvGWcfBoKPnt0lJKwvHiv5Y9J9sRd/1yzA7BLnTpVUjHwQDxuy32k/7w8VL2fIpzvz7EleQheGooxc4Hm/VTZf3ueO1lNlk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 669E53858404 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5d437235769so3270826a12.2 for ; Fri, 13 Dec 2024 07:58:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734105488; x=1734710288; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Im0VWmQA4kyrW69dsHvKaXBkBTELw3vMY/tzH9CJXh4=; b=eWOABIu4z3L70MBWpobr+tERs7T62bhENGTJEWzRwlc6tB4ZRaf80+vAulslTJ0zSo Kp3MD6jQELCc24cjL4iXXBaX6on0NVZgGL8CIwxjwPCPMHSu5tk3GIufx/LC9dDVC6Sa 2A2bfPtOZLRzV7pOcBX5JTWt0QDCO87GTXk/FdaqcM+99uFzSyzH0JP1a16WeQRlYw4d e+w0vZZ/20YQYetk1IZVCPZQVJlmshxh1sP18wmhwYVhQ9E6n9fkaXtdlKv6HiMdzOCY Ph7uQifD8SQThzzWfZGIrLrqzyvoPes2OR9RMxBtmemsyvlSKWcrYDzWo/ZtwQHCUt6Z 75lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734105488; x=1734710288; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Im0VWmQA4kyrW69dsHvKaXBkBTELw3vMY/tzH9CJXh4=; b=lBBue+DnKVNzl0OFllCWScxRFBKzx4zFUu4tbXJplLmZhQUyCL/LK9tQT7Fha3ZnNs GFwwj4u6jNAouy0mkgUS+b4OtISduGxgo15E6JHwX/HTD5Zz9XrLdJvm6dD+Jr66l29v 4gvjWq5D7plKX9qRUUFSitPd8rZaVv5KIE79bfEPee/QXL96y1ZSSIQ4er2fsVEQeV3a Vqc58iKL1DOI8mqybOQuMd91aJ1vf1E7gQulFIXqgxZuwiBLv3n8oJHBr4PnJNzNHf3P iWRSvb9qt1MKbQKjdwaP/CKXhjT/zhdgXIO2fNjxL0nAtXDC+VGZMKYj+HixQ+7JnJYY V3kQ== X-Gm-Message-State: AOJu0YyArbv+PRHmafzhuSqpPgPLGixZPrE3+KPR3Ai114Inbp8OWH9Z VpbiMfM+PfT8RVEYI3P/3M34DAc2+gqtrIQxA5b71n3aNBBtJrzITbiaHSEg X-Gm-Gg: ASbGnct6Zd3FRQ3C0mRtL3wgPWEeHf9Xtf1S+3X3YFX0+qzgS82fU7zXobDpKtR01R/ 5rFEzrftqGAHjQtQEQ3YvXRP/+cKRXMmM6oaR9VXM9BsG0HR6ucGqqxjf3Gg6X8kz5pu3EHh3Yo 1l1Aq1g4ec+Z25ise5YXcmWxXMTfcxPhQBJw3I/LwPg2QDj8Ah6TKtrWxEIN0dqjz4/q9byFVA4 i7EWzBBFQz1nS/MNfBEstrMlHs2UVplfLfnKybekwtbG37ZklPXSFR7ltezAm9nd+3FDbe0 X-Google-Smtp-Source: AGHT+IHkiSVE9I4IlYmf8rpv3lj6+Uhe/Ebby9ErqleFYIpgfZrskVvROh7v7x4helUPh9lxsxWevA== X-Received: by 2002:a05:6402:380a:b0:5d0:8106:aaf4 with SMTP id 4fb4d7f45d1cf-5d63c3b3b3cmr2470764a12.21.1734105487790; Fri, 13 Dec 2024 07:58:07 -0800 (PST) Received: from SYRN16-0224-L.. ([109.245.202.111]) by smtp.googlemail.com with ESMTPSA id 4fb4d7f45d1cf-5d6501d5863sm95355a12.76.2024.12.13.07.58.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Dec 2024 07:58:07 -0800 (PST) From: Milica Matic X-Google-Original-From: Milica Matic To: gdb-patches@sourceware.org Cc: milica.matic@htecgroup.com, simark@simark.ca, cfu@wavecomp.com, aburgess@redhat.com, kevinb@redhat.com, macro@orcam.me.uk, djordje.todorovic@htecgroup.com, Faraz Shahbazker Subject: [PATCH 21/21] Fix gold linker build issues for mingw Date: Fri, 13 Dec 2024 16:53:28 +0100 Message-Id: <20241213155328.406003-23-milica.matic@htecgroup.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241213155328.406003-1-milica.matic@htecgroup.com> References: <20241213155328.406003-1-milica.matic@htecgroup.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Faraz Shahbazker Release branch only. These functions are not defined as of mingw-w64 v6.0.0, so we work around them as follows: mkdtemp: simulate using tempnam and mkdir link: omit usage and fall back to file copy NOTE: use of tempnam is a security risk. Find a better solution!! Cherry-picked cf1e966 from https://github.com/MIPS/binutils-gdb Signed-off-by: Faraz Shahbazker Signed-off-by: Milica Matic --- gold/plugin.cc | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/gold/plugin.cc b/gold/plugin.cc index 89f2e3bb182..545c0d96e16 100644 --- a/gold/plugin.cc +++ b/gold/plugin.cc @@ -509,8 +509,12 @@ Plugin_recorder::init() // copies of replacement files. char dir_template[] = "gold-recording-XXXXXX"; #ifdef HAVE_MKDTEMP - if (mkdtemp(dir_template) == NULL) - return false; + #ifdef __MINGW32__ + if (mkdir (tmpnam(dir_template)) == 0) + #else + if (mkdtemp(dir_template) == NULL) + #endif + return false; #else if (mktemp(dir_template) == NULL) return false; @@ -574,7 +578,7 @@ link_or_copy_file(const char* inname, const char* outname) { static char buf[4096]; -#ifdef HAVE_LINK +#if defined(HAVE_LINK) && !defined(__MINGW32__) if (::link(inname, outname) == 0) return true; #endif -- 2.34.1