Re: [PATCH^7] gdb: mips: Add MIPSR6 support

[Kevin Buettner <kevinb@redhat.com>]

Hi Milica,

Thanks for adding comments on new functions introduced by your patch.
I still found a few nits; see below...

On Mon, 9 Dec 2024 17:01:07 +0000
Milica Matic <milica.matic@htecgroup.com> wrote:

>    return extract_unsigned_integer (buf, instlen, byte_order);
>  }
>  
> +

You are still introducing a extraneous newline here.

See: https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Whitespaces

Relevant quote from that link:

    "..., do not use more than one blank line to separate blocks,..."

> -      if (op >> 2 == 5)
> -	/* BEQL, BNEL, BLEZL, BGTZL: bits 0101xx */
> -	{
> -	  switch (op & 0x03)
> -	    {
> -	    case 0:		/* BEQL */
> -	      goto equal_branch;
> -	    case 1:		/* BNEL */
> -	      goto neq_branch;
> -	    case 2:		/* BLEZL */
> -	      goto less_branch;
> -	    case 3:		/* BGTZL */
> -	      goto greater_branch;
> -	    default:
> -	      pc += 4;
> -	    }
> -	}
> +      if (op >> 2 == 5 && ((op & 0x02) == 0 || itype_rt (inst) == 0))
> +    /* BEQL, BNEL, BLEZL, BGTZL: bits 0101xx */
> +    {
> +      switch (op & 0x03)
> +        {
> +        case 0:		/* BEQL */
> +          goto equal_branch;
> +        case 1:		/* BNEL */
> +          goto neq_branch;
> +        case 2:		/* BLEZL */
> +          goto lez_branch;
> +        case 3:		/* BGTZL */
> +          goto greater_branch;
> +        default:
> +          pc += 4;
> +        }
> +    }

In this change, it appears that leading tabs were replaced by spaces.
The GDB project prefers that tabs be used in place of leading spaces.
See: https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Code_indentation

Relevant quote from that link:

    "Lines should be indented with a mix of tabs and spaces.  8 spaces
     should be replaced with Tab."


>        else if (op == 17 && itype_rs (inst) == 8)
> -	/* BC1F, BC1FL, BC1T, BC1TL: 010001 01000 */
> -	pc = mips32_bc1_pc (gdbarch, regcache, inst, pc + 4, 1);
> -      else if (op == 17 && itype_rs (inst) == 9
> +    /* BC1F, BC1FL, BC1T, BC1TL: 010001 01000 */
> +    pc = mips32_bc1_pc (gdbarch, regcache, inst, pc + 4, 1);
> +      else if (!is_mipsr6_isa (gdbarch)
> +              && op == 17
> +              && itype_rs (inst) == 9

For the above change, and elsewhere too, make sure that you use tabs
in place of 8 spaces for the leading indentation.  (See above.)

Kevin